Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing test in FabricTable for legal addition of two different fabrics chaining to same root #21947

Closed
tcarmelveilleux opened this issue Aug 17, 2022 · 0 comments · Fixed by #21948
Closed

Missing test in FabricTable for legal addition of two different fabrics chaining to same root #21947

tcarmelveilleux opened this issue Aug 17, 2022 · 0 comments · Fixed by #21948
Assignees
@tcarmelveilleux
Labels
security sve cherry pick tests V1.0

Comments

@tcarmelveilleux
Copy link
Contributor

Problem

  • FabricTable has a TODO for a test validating that it works to add N fabrics that chain to same root, but have different fabric IDs (which is completely legal

Proposed Solution

  • Implement the test
@tcarmelveilleux tcarmelveilleux self-assigned this Aug 17, 2022
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Aug 17, 2022
@tcarmelveilleux
Implement 2 missing tests in FabricTable
a5ec099 
- In project-chip#19819, TODOs were left for a couple tests of
  things "anecdotally" known to work, or tested outside
  of SDK, but not tested yet in official SDK.

- This PR implements TestAddMultipleSameRootDifferentFabricId and
  TestInvalidChaining

Fixes project-chip#21946
Fixes project-chip#21947

Testing done:
- Added 2 new unit tests, both pass
- Did some messing about to make assertions fail on purpose
  and validated the the wrong behavior was not passing
@tcarmelveilleux tcarmelveilleux mentioned this issue Aug 17, 2022
Merged
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@tcarmelveilleux @isiu-apple
Implement 2 missing tests in FabricTable (project-chip#21948)
206ad9f 
- In project-chip#19819, TODOs were left for a couple tests of
  things "anecdotally" known to work, or tested outside
  of SDK, but not tested yet in official SDK.

- This PR implements TestAddMultipleSameRootDifferentFabricId and
  TestInvalidChaining

Fixes project-chip#21946
Fixes project-chip#21947

Testing done:
- Added 2 new unit tests, both pass
- Did some messing about to make assertions fail on purpose
  and validated the the wrong behavior was not passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcarmelveilleux tcarmelveilleux

Labels
security sve cherry pick tests V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement 2 missing tests in FabricTable tcarmelveilleux/connectedhomeip
1 participant
@tcarmelveilleux