Drop-off fabric sensitive event when fabric is undefined #21942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #21942: Size comparison from 0691bbc to 66a8249 Increases (15 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2, cyw30739)
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
|
yunhanw-google
force-pushed
the
feature/issue_14366_2
branch
from
66a8249 to
95577c2
Compare
|
PR #21942: Size comparison from a3cb409 to 95577c2 Increases (16 builds for bl602, cc13x2_26x2, cyw30739, esp32, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2, cyw30739)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Aug 17, 2022
woody-apple
approved these changes
Aug 17, 2022
pullapprove
bot
requested review from
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic and
vijs
yunhanw-google
force-pushed
the
feature/issue_14366_2
branch
from
4f89fce to
00375e0
Compare
|
PR #21942: Size comparison from 866e7ee to 00375e0 Increases (27 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
| @@ -72,6 +72,8 @@ CHIP_ERROR LogEvent(const T & aEventData, EndpointId aEndpoint, EventNumber & aE | |||
| eventOptions.mPath = path; | |||
| eventOptions.mPriority = aEventData.GetPriorityLevel(); | |||
| eventOptions.mFabricIndex = aEventData.GetFabricIndex(); | |||
| // this skips logging the event if it's fabric-scoped but no fabric association exists yet. | |||
| VerifyOrReturnError(eventOptions.mFabricIndex != kUndefinedFabricIndex, CHIP_NO_ERROR); | |||
There was a problem hiding this comment.
Why are we not returning an error here?
| await devCtrl.SendCommand(nodeid=NODE_ID, endpoint=1, payload=Clusters.TestCluster.Commands.TestEmitTestFabricScopedEventRequest(arg1=0)) | ||
| res = await devCtrl.ReadEvent(nodeid=NODE_ID, events=[ | ||
| (1, Clusters.TestCluster.Events.TestEvent, 0), | ||
| ]) |
There was a problem hiding this comment.
What is this actually testing? If it isn't testing anything meaningful, we shouldn't have it here.
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#14366
Change overview
Drop-off fabric sensitive event when fabric is undefined
Testing
Add python testing for it