Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigation: in particular, the way things are right now any events generated by a PASE session before it's picked up a fabric association will be visible to all consumers. #14366

Closed
yunhanw-google opened this issue Jan 26, 2022 · 3 comments
Assignees

Comments

@yunhanw-google
Copy link
Contributor

So in particular, the way things are right now any events generated by a PASE session before it's picked up a fabric association will be visible to all consumers.

Maybe that's not a problem in practice because you can't add ACLS via a PASE session before it picks up a fabric? But we would need to pretty carefully check the ordering of things in AddNOC....

On the other hand, if we allowed event.mFabricIndex to have the "no fabric" value (0).... I guess a later PASE session would be able to see the events, which is not desirable?

Maybe the right answer is that fabric-scoped events emitted not in the context of a fabric should just be dropped completely? Worth checking with @mlepage-google and @tcarmelveilleux whether they have thoughts on this. But we can also adjust it as a followup.

Originally posted by @bzbarsky-apple in #13907 (comment)

@bzbarsky-apple
Copy link
Contributor

@mrjerryjohns @anush-apple

@bzbarsky-apple
Copy link
Contributor

Needs to be v1.0, because this is a security problem if we get this wrong.

@bzbarsky-apple
Copy link
Contributor

Removing "deferral candidate". This exposes data across fabrics in ways that are not OK, last I checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants