You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Investigation: in particular, the way things are right now any events generated by a PASE session before it's picked up a fabric association will be visible to all consumers.
#14366
Closed
yunhanw-google opened this issue
Jan 26, 2022
· 3 comments
So in particular, the way things are right now any events generated by a PASE session before it's picked up a fabric association will be visible to all consumers.
Maybe that's not a problem in practice because you can't add ACLS via a PASE session before it picks up a fabric? But we would need to pretty carefully check the ordering of things in AddNOC....
On the other hand, if we allowed event.mFabricIndex to have the "no fabric" value (0).... I guess a later PASE session would be able to see the events, which is not desirable?
Maybe the right answer is that fabric-scoped events emitted not in the context of a fabric should just be dropped completely? Worth checking with @mlepage-google and @tcarmelveilleux whether they have thoughts on this. But we can also adjust it as a followup.
So in particular, the way things are right now any events generated by a PASE session before it's picked up a fabric association will be visible to all consumers.
Maybe that's not a problem in practice because you can't add ACLS via a PASE session before it picks up a fabric? But we would need to pretty carefully check the ordering of things in AddNOC....
On the other hand, if we allowed event.mFabricIndex to have the "no fabric" value (0).... I guess a later PASE session would be able to see the events, which is not desirable?
Maybe the right answer is that fabric-scoped events emitted not in the context of a fabric should just be dropped completely? Worth checking with @mlepage-google and @tcarmelveilleux whether they have thoughts on this. But we can also adjust it as a followup.
Originally posted by @bzbarsky-apple in #13907 (comment)
The text was updated successfully, but these errors were encountered: