Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access control events should be fabric scoped #14438

Closed
mlepage-google opened this issue Jan 27, 2022 · 4 comments
Closed

Access control events should be fabric scoped #14438

mlepage-google opened this issue Jan 27, 2022 · 4 comments
Assignees
Labels
acl Access Control feature spec Mismatch between spec and implementation V1.0

Comments

@mlepage-google
Copy link
Contributor

mlepage-google commented Jan 27, 2022

Events for access control cluster should be fabric scoped.

This will require a spec change, and because this may be the first instance of fabric scope/filtered events, a syntax may have to be defined. (I.e. no good example to copy.)

This also requires IM support for fabric filtered events. PR #13907 does that, so just need to validate and see if anything else needs to be done.

Slightly related issues:

@mlepage-google mlepage-google self-assigned this Jan 27, 2022
@mlepage-google mlepage-google added acl Access Control feature V1.0 labels Jan 27, 2022
@andy31415 andy31415 added v1_triage_split_4 V1.0 acl Access Control feature and removed V1.0 acl Access Control feature labels Jan 30, 2022
@mlepage-google
Copy link
Contributor Author

@turon turon added the spec Mismatch between spec and implementation label Jan 31, 2022
@turon
Copy link
Contributor

turon commented Jan 31, 2022

Removing triage tag v1_triage_split_4. This bug is v1 worthy.

@mlepage-google
Copy link
Contributor Author

Removing triage tag v1_triage_split_4. This bug is v1 worthy.

Yes this has to be done, it's no sense having fabric scoped/sensitive attributes but not fabric scoped/sensitive events which include the same content.

@mlepage-google
Copy link
Contributor Author

I tried this with Access Control.

In one REPL, I set up two controllers on fabric 1, one subscribed to this event on fabric 1.
In another REPL, I set up a controller on fabric 2, subscribed to this event on fabric 2.

In the first REPL, I wrote the ACL attribute with a new list value.
In the first REPL, I received event notifications for changed entries.
In the second REPL, I received no such notifications.

This appears to be working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acl Access Control feature spec Mismatch between spec and implementation V1.0
Projects
None yet
Development

No branches or pull requests

3 participants