Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status check in timed related test #21871

Conversation

yunhanw-google
Copy link
Contributor

Problem

#21863

Change overview

TestCommandHandlerWithProcessReceivedEmptyDataMsg not quite checking the
status returned from ProcessInvokeRequest, add the status check for ProcessInvokeRequest

Testing

improve existing test

TestCommandHandlerWithProcessReceivedEmptyDataMsg not quite checking the
status returned from ProcessInvokeRequest, add the status check for ProcessInvokeRequest
@github-actions
Copy link

github-actions bot commented Aug 12, 2022

PR #21871: Size comparison from 37b9f20 to 89b7e39

Increases (2 builds for bl602, esp32)
platform target config section 37b9f20 89b7e39 change % change
bl602 lighting-app bl602+rpc .text 1082216 1082220 4 0.0
esp32 all-clusters-app c3devkit (read only) 1027614 1027616 2 0.0
.flash.text 1027614 1027616 2 0.0
Decreases (1 build for efr32)
platform target config section 37b9f20 89b7e39 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1139116 1139100 -16 -0.0
.text 991536 991520 -16 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 37b9f20 89b7e39 change % change
bl602 lighting-app bl602 (read/write) 1383050 1383050 0 0.0
.bss 119882 119882 0 0.0
.data 4480 4480 0 0.0
.text 1050716 1050716 0 0.0
bl602+rpc (read/write) 1428290 1428290 0 0.0
.bss 127322 127322 0 0.0
.data 4600 4600 0 0.0
.text 1082216 1082220 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672303 672303 0 0.0
(read/write) 179208 179208 0 0.0
.bss 74404 74404 0 0.0
.data 3372 3372 0 0.0
.rodata 88703 88703 0 0.0
.text 583284 583284 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637679 637679 0 0.0
(read/write) 157980 157980 0 0.0
.bss 73692 73692 0 0.0
.data 3372 3372 0 0.0
.rodata 77951 77951 0 0.0
.text 559404 559404 0 0.0
lock-ftd LP_CC2652R7 (read only) 674027 674027 0 0.0
(read/write) 167676 167676 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76643 76643 0 0.0
.text 596904 596904 0 0.0
lock-mtd LP_CC2652R7 (read only) 656779 656779 0 0.0
(read/write) 180612 180612 0 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101731 101731 0 0.0
.text 554568 554568 0 0.0
pump-app LP_CC2652R7 (read only) 684771 684771 0 0.0
(read/write) 157740 157740 0 0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89931 89931 0 0.0
.text 594356 594356 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669223 669223 0 0.0
(read/write) 173408 173408 0 0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85487 85487 0 0.0
.text 583256 583256 0 0.0
shell LP_CC2652R7 (read only) 664994 664994 0 0.0
(read/write) 182036 182036 0 0.0
.bss 76724 76724 0 0.0
.data 3376 3376 0 0.0
.rodata 85650 85650 0 0.0
.text 579028 579028 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586006 586006 0 0.0
.app_xip_area 462672 462672 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591822 591822 0 0.0
.app_xip_area 463704 463704 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 598962 598962 0 0.0
.app_xip_area 476348 476348 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1099996 1099996 0 0.0
.bss 132980 132980 0 0.0
.data 2068 2068 0 0.0
.text 964928 964928 0 0.0
BRD4161A+rpc (read/write) 1154264 1154264 0 0.0
.bss 149668 149668 0 0.0
.data 2280 2280 0 0.0
.text 1002296 1002296 0 0.0
BRD4161A+rs911x (read/write) 989408 989408 0 0.0
.bss 162320 162320 0 0.0
.data 2056 2056 0 0.0
.text 825012 825012 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139116 1139100 -16 -0.0
.bss 145496 145496 0 0.0
.data 2064 2064 0 0.0
.text 991536 991520 -16 -0.0
window-app BRD4161A (read/write) 1091444 1091444 0 0.0
.bss 134412 134412 0 0.0
.data 2096 2096 0 0.0
.text 954916 954916 0 0.0
esp32 all-clusters-app c3devkit (read only) 1027614 1027616 2 0.0
(read/write) 1488218 1488218 0 0.0
.dram0.bss 70480 70480 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217704 217704 0 0.0
.flash.text 1027614 1027616 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1081007 1081007 0 0.0
(read/write) 490168 490168 0 0.0
.dram0.bss 75984 75984 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248044 248044 0 0.0
.flash.text 1075623 1075623 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 645028 645028 0 0.0
.bss 69848 69848 0 0.0
.data 2044 2044 0 0.0
.text 570408 570408 0 0.0
lock k32w0+release (read/write) 702572 702572 0 0.0
.bss 70320 70320 0 0.0
.data 2052 2052 0 0.0
.text 627472 627472 0 0.0
linux all-clusters-app debug (read only) 3032977 3032977 0 0.0
(read/write) 155888 155888 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85528 85528 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 274411 274411 0 0.0
.text 2579490 2579490 0 0.0
all-clusters-minimal-app debug (read only) 2872833 2872833 0 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274603 274603 0 0.0
.text 2421858 2421858 0 0.0
bridge-app debug+rpc (read only) 2371641 2371641 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50624 50624 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203432 203432 0 0.0
.text 2005586 2005586 0 0.0
chip-tool debug (read only) 10660169 10660169 0 0.0
(read/write) 650912 650912 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 615896 615896 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 552533 552533 0 0.0
.text 8601844 8601844 0 0.0
chip-tool-ipv6only arm64 (read only) 10070292 10070292 0 0.0
(read/write) 698673 698673 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643424 643424 0 0.0
.dynamic 560 560 0 0.0
.got 13720 13720 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 483556 483556 0 0.0
.text 7949732 7949732 0 0.0
lighting-app debug+rpc (read only) 2595625 2595625 0 0.0
(read/write) 130176 130176 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72360 72360 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220176 220176 0 0.0
.text 2204738 2204738 0 0.0
lock-app debug (read only) 2579537 2579537 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237232 237232 0 0.0
.text 2175650 2175650 0 0.0
ota-provider-app debug (read only) 2356697 2356697 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209208 209208 0 0.0
.text 1984018 1984018 0 0.0
ota-requestor-app debug (read only) 2522425 2522425 0 0.0
(read/write) 127288 127288 0 0.0
.bss 50304 50304 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68728 68728 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 215968 215968 0 0.0
.text 2133890 2133890 0 0.0
shell debug (read only) 2601297 2601297 0 0.0
(read/write) 142008 142008 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77128 77128 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 234546 234546 0 0.0
.text 2208402 2208402 0 0.0
thermostat-no-ble arm64 (read only) 2356244 2356244 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140508 140508 0 0.0
.text 1978016 1978016 0 0.0
tv-app debug (read only) 3173529 3173529 0 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79200 79200 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 259144 259144 0 0.0
.text 2724594 2724594 0 0.0
tv-casting-app debug (read only) 5413937 5413937 0 0.0
(read/write) 159088 159088 0 0.0
.bss 51448 51448 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98776 98776 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 342417 342417 0 0.0
.text 4803170 4803170 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454392 2454392 0 0.0
.bss 214692 214692 0 0.0
.data 5872 5872 0 0.0
.text 1417036 1417036 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180003 1180003 0 0.0
bss 143350 143350 0 0.0
rodata 143412 143412 0 0.0
text 814396 814396 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159899 1159899 0 0.0
bss 142588 142588 0 0.0
rodata 135108 135108 0 0.0
text 803384 803384 0 0.0
p6 all-clusters-app default (read only) 881392 881392 0 0.0
(read/write) 1697300 1697300 0 0.0
.bss 149296 149296 0 0.0
.data 2656 2656 0 0.0
.text 1536960 1536960 0 0.0
all-clusters-minimal-app default (read only) 882112 882112 0 0.0
(read/write) 1641340 1641340 0 0.0
.bss 148576 148576 0 0.0
.data 2656 2656 0 0.0
.text 1481720 1481720 0 0.0
light-app default (read only) 890432 890432 0 0.0
(read/write) 1560012 1560012 0 0.0
.bss 140464 140464 0 0.0
.data 2448 2448 0 0.0
.text 1408712 1408712 0 0.0
lock-app default (read only) 885936 885936 0 0.0
(read/write) 1597180 1597180 0 0.0
.bss 144944 144944 0 0.0
.data 2464 2464 0 0.0
.text 1441384 1441384 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808384 808384 0 0.0
bss 71096 71096 0 0.0
noinit 43488 43488 0 0.0
text 571310 571310 0 0.0
lighting-app tlsr9518adk80d (read/write) 830304 830304 0 0.0
bss 71952 71952 0 0.0
noinit 43488 43488 0 0.0
text 589388 589388 0 0.0

@woody-apple woody-apple enabled auto-merge (squash) August 15, 2022 23:19
@woody-apple woody-apple merged commit d71bb71 into project-chip:master Aug 15, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
TestCommandHandlerWithProcessReceivedEmptyDataMsg not quite checking the
status returned from ProcessInvokeRequest, add the status check for ProcessInvokeRequest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants