Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCommandHandlerWithProcessReceivedEmptyDataMsg not quite checking the status returned from ProcessInvokeRequest #21863

Closed
mrjerryjohns opened this issue Aug 12, 2022 · 4 comments
Assignees
Labels

Comments

@mrjerryjohns
Copy link
Contributor

Problem

In TestCommandInteraction::TestCommandHandlerWithProcessReceivedEmptyDataMsg, the act of sending an invoke where messageIsTimed did not match transactionIsTimed previously used to result in a status response being sent out.

I don't see that anymore after I synced up to master

@mrjerryjohns mrjerryjohns added spec Mismatch between spec and implementation V1.0 labels Aug 12, 2022
@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Aug 12, 2022

In a normal message reception flow it would be sent (by the caller). TestCommandHandlerWithProcessReceivedEmptyDataMsg directly calls an internal implementation function that returns status that the caller then sends. Perhaps it should check the returned status?

@mrjerryjohns
Copy link
Contributor Author

Ah ok. In that case, will take off the spec label.

@mrjerryjohns mrjerryjohns changed the title Status Response not being sent when isTimed flag is set incorrectly TestCommandHandlerWithProcessReceivedEmptyDataMsg not quite checking the status returned from ProcessInvokeRequest Aug 12, 2022
@yunhanw-google
Copy link
Contributor

#21871

@mrjerryjohns mrjerryjohns removed the spec Mismatch between spec and implementation label Aug 15, 2022
@yunhanw-google
Copy link
Contributor

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants