Spin up commissioners in chip-tool as needed. #21830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basic change is that instead of spinning up commissioners during "stack startup" for the three default identities plus the command's identity (in case that's not one of the three defaults) we: 1) Spin up the commissioner for the command's identity when we're actually running the command (on the Matter event loop). This allows commands in interactive mode to use an identity that is not one of the three default identities and fixes project-chip#21828 2) Spin up commissioners as needed when they are requested. This allows YAML test steps (which are not distinct commands) to use an identity that is not one of the three default identities.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton and
jepenven-silabs
pullapprove
bot
requested review from
woody-apple,
saurabhst,
xylophone21,
selissia,
yunhanw-google,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple and
wbschiller
msandstedt
reviewed
Aug 11, 2022
msandstedt
approved these changes
Aug 11, 2022
tcarmelveilleux
approved these changes
Aug 11, 2022
|
PR #21830: Size comparison from f2bbce7 to bb7383f Increases above 0.2%:
Increases (5 builds for bl602, efr32, esp32, linux)
Decreases (5 builds for linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
The basic change is that instead of spinning up commissioners during "stack startup" for the three default identities plus the command's identity (in case that's not one of the three defaults) we: 1) Spin up the commissioner for the command's identity when we're actually running the command (on the Matter event loop). This allows commands in interactive mode to use an identity that is not one of the three default identities and fixes project-chip#21828 2) Spin up commissioners as needed when they are requested. This allows YAML test steps (which are not distinct commands) to use an identity that is not one of the three default identities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic change is that instead of spinning up commissioners during "stack
startup" for the three default identities plus the command's identity (in case
that's not one of the three defaults) we:
Spin up the commissioner for the command's identity when we're actually
running the command (on the Matter event loop). This allows commands in
interactive mode to use an identity that is not one of the three default
identities and fixes Using different commissioner name other than beta or gamma in chip-tool interactive mode throws segmentation error #21828
Spin up commissioners as needed when they are requested. This allows YAML
test steps (which are not distinct commands) to use an identity that is not
one of the three default identities.
Problem
See #21828
Change overview
See above.
Testing
Checked the steps from #21828. CI should check YAML bits.