Align Actions cluster better with spec. #21638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
robszewczyk and
saurabhst
pullapprove
bot
requested review from
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
github-actions
bot
added
app
controller
darwin
documentation
|
PR #21638: Size comparison from a42dffb to 8205b1b Increases (8 builds for cc13x2_26x2, esp32, linux, telink)
Decreases (4 builds for bl602, cc13x2_26x2, esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mrjerryjohns
approved these changes
Aug 4, 2022
The primary change is the change in the cluster name. Specific actions taken to generate this PR: * Install the git-extras package * git sed -f g bridged-actions-cluster.xml actions-cluster.xml * git sed -f g "Bridged Actions" Actions * git sed -f g BridgedActions Actions * git sed -f g BRIDGED_ACTIONS_CLUSTER ACTIONS_CLUSTER * Manual fixup of src/app/tests/suites/README.md to realign the table. * Remove Actions from .wordlist.txt * Manual naming alignment with the spec in actions-cluster.xml. * git sed -f g EndpointList::Id EndpointLists::Id * git sed -f g SetupUrl::Id SetupURL::Id * Ran ./scripts/tools/zap_convert_all.py (and fixed the script to work with the chef not-real-zap-file bits). * Ran ./scripts/tools/zap_regen_all.py * Ran restyle
bzbarsky-apple
force-pushed
the
actions-cluster-rename
branch
from
8205b1b to
c1c9393
Compare
|
PR #21638: Size comparison from dc85dad to c1c9393 Increases (9 builds for bl602, cc13x2_26x2, esp32, linux, telink)
Decreases (3 builds for cc13x2_26x2, esp32, linux)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Aug 8, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
The primary change is the change in the cluster name. Specific actions taken to generate this PR: * Install the git-extras package * git sed -f g bridged-actions-cluster.xml actions-cluster.xml * git sed -f g "Bridged Actions" Actions * git sed -f g BridgedActions Actions * git sed -f g BRIDGED_ACTIONS_CLUSTER ACTIONS_CLUSTER * Manual fixup of src/app/tests/suites/README.md to realign the table. * Remove Actions from .wordlist.txt * Manual naming alignment with the spec in actions-cluster.xml. * git sed -f g EndpointList::Id EndpointLists::Id * git sed -f g SetupUrl::Id SetupURL::Id * Ran ./scripts/tools/zap_convert_all.py (and fixed the script to work with the chef not-real-zap-file bits). * Ran ./scripts/tools/zap_regen_all.py * Ran restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change is the change in the cluster name.
Specific actions taken to generate this PR:
chef not-real-zap-file bits).
Fixes #21625
Problem
Cluster name and some attribute/field names do not match spec.
Change overview
Align with spec.
Testing
Should be no behavior changes.