Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions cluster, enum ActionStruct, field State is printed as "Status" in chip-tool #21625

Closed
leorozendaal opened this issue Aug 4, 2022 · 3 comments · Fixed by #21638
Closed
Assignees

Comments

@leorozendaal
Copy link
Contributor

leorozendaal commented Aug 4, 2022

Problem

Actions cluster, enum ActionStruct, field State is printed as "Status" in chip-tool, see example below

Proposed Solution

Rename "Status" to "State" (at least in the printed output, consider to rename the variable name internally) to match the spec

Example of chip-tool output:

[1658473018.104129][16539:16544] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0025 Attribute 0x0000_0000 DataVersion: 3292516604
[1658473018.104215][16539:16544] CHIP:TOO:   action list: 1 entries
[1658473018.104263][16539:16544] CHIP:TOO:     [1]: {
[1658473018.104728][16539:16544] CHIP:TOO:       ActionID: 4097
[1658473018.104753][16539:16544] CHIP:TOO:       Name: Room 1 On
[1658473018.104770][16539:16544] CHIP:TOO:       Type: 3
[1658473018.104786][16539:16544] CHIP:TOO:       EndpointListID: 57345
[1658473018.104803][16539:16544] CHIP:TOO:       SupportedCommands: 1
[1658473018.104819][16539:16544] CHIP:TOO:       Status: 0
[1658473018.104834][16539:16544] CHIP:TOO:      }

image

@bzbarsky-apple
Copy link
Contributor

chip-tool just uses whatever is in the XML. The problem is that the XML does not match the spec.

I am actually in the middle of fixing that last for this cluster; it had a bunch of other issues too. Taking.

@leorozendaal
Copy link
Contributor Author

@bzbarsky-apple thanks!

@bzbarsky-apple
Copy link
Contributor

@leorozendaal No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants