Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings -Werror=memset-elt-size #2152

Closed
wants to merge 1 commit into from

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Aug 14, 2020

This warning happens if we try to compile CHIPMessageLayer with
CHIP_CONFIG_MAX_TUNNELS == 0 or CHIP_CONFIG_MAX_CONNECTIONS == 0.

These warnings seems incorrect for a zero sized array, but the warning might catch more
interesting cases so solve the problem with #ifdefs.

Change-Id: Ic038519707e3f38c11bc216835eb733631c4ad15

This warning happens if we try to compile CHIPMessageLayer with
CHIP_CONFIG_MAX_TUNNELS == 0 or CHIP_CONFIG_MAX_CONNECTIONS == 0.

These warnings seems incorrect, but the warning might catch more useful
cases so solve the problem with #ifdefs.

Change-Id: Ic038519707e3f38c11bc216835eb733631c4ad15
@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


memset(mConPool, 0, sizeof(mConPool));
#endif
#if CHIP_CONFIG_MAX_TUNNELS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think tunnels are part of CHIP , can we remove these and the #defines?
#2105

@mspang mspang closed this Aug 14, 2020
@mspang mspang deleted the for-chip/fix-elt-size branch August 14, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants