Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tunneling support from CHIP code base #2105

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Remove tunneling support from CHIP code base #2105

merged 2 commits into from
Aug 14, 2020

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Aug 13, 2020

Problem
Tunneling is a feature inherited from Weave and this feature will not be used in CHIP.

Proposed Solution
Cleanup all tunneling support from CHIP code base.

fixes #2080

@woody-apple
Copy link
Contributor

@yufengwangca sadly there's a conflict here now :(

* Cleanup all tunneling support from CHIP codebase since this feature will not be used in CHIP.
@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
chip-nrf52840-lock-example.out .text -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_abbrev,0,77
[Unmapped],0,9
.text,-4,-4
.debug_ranges,0,-32
.debug_macro,0,-600
.debug_line,0,-851
.debug_str,0,-4449
.debug_info,0,-4770


@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-nrf52840-lock-example.elf [LOAD #1 [RWX]] -4 -4
chip-nrf52840-lock-example.elf text -92 -92
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize
.debug_abbrev,0,49
[Unmapped],0,-2
[LOAD #1 [RWX]],-4,-4
.debug_aranges,0,-24
.debug_ranges,0,-24
text,-92,-92
.symtab,0,-96
.debug_frame,0,-116
.debug_line,0,-272
.strtab,0,-329
.debug_str,0,-1875
.debug_info,0,-3167


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
chip-standalone-demo.out .text -16 -16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_abbrev,0,56
.debug_loc,0,47
[Unmapped],0,17
.text,-16,-16
.debug_ranges,0,-64
.debug_macro,0,-525
.debug_line,0,-541
.debug_info,0,-2848
.debug_str,0,-4454


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.rodata -136 -136
chip-wifi-echo.elf .flash.text -316 -316
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
[Unmapped],0,138
.debug_abbrev,0,18
.symtab,0,-16
.debug_aranges,0,-72
.debug_ranges,0,-72
.strtab,0,-74
.flash.rodata,-136,-136
.debug_frame,0,-216
.flash.text,-316,-316
.debug_line,0,-890
.debug_str,0,-1644
.debug_info,0,-5824


@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@yufengwangca
Copy link
Contributor Author

@yufengwangca sadly there's a conflict here now :(

Resolved.

@BroderickCarlin BroderickCarlin merged commit 3462087 into project-chip:master Aug 14, 2020
@yufengwangca yufengwangca deleted the pr/message/tunnel branch August 14, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tunneling support for WML baseline
6 participants