-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tunneling support from CHIP code base #2105
Merged
BroderickCarlin
merged 2 commits into
project-chip:master
from
yufengwangca:pr/message/tunnel
Aug 14, 2020
Merged
Remove tunneling support from CHIP code base #2105
BroderickCarlin
merged 2 commits into
project-chip:master
from
yufengwangca:pr/message/tunnel
Aug 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufengwangca
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
August 13, 2020 22:18
woody-apple
approved these changes
Aug 13, 2020
mspang
approved these changes
Aug 14, 2020
andy31415
approved these changes
Aug 14, 2020
woody-apple
approved these changes
Aug 14, 2020
@yufengwangca sadly there's a conflict here now :( |
* Cleanup all tunneling support from CHIP codebase since this feature will not be used in CHIP.
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Resolved. |
BroderickCarlin
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tunneling is a feature inherited from Weave and this feature will not be used in CHIP.
Proposed Solution
Cleanup all tunneling support from CHIP code base.
fixes #2080