[mrp] Align MRP backoff time calculation with spec #21356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk and
saurabhst
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #21356: Size comparison from 1679342 to 035fc25 Increases above 0.2%:
Increases (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (7 builds for cc13x2_26x2, linux)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 28, 2022
Make variables and comments in the function more aligned with the current spec version so that it is easier to compare the code with the spec. Signed-off-by: Damian Krolik <[email protected]>
Base interval (active or idle) should be multiplied by MRP_BACKOFF_MARGIN = 1.1 before putting it in the MRP backoff formula. Signed-off-by: Damian Krolik <[email protected]>
When sender is sleepy, it may take more time until it receives an acknowledgment from a peer, so MRP backoff time should be extended by the sleepy active interval. Signed-off-by: Damian Krolik <[email protected]>
|
PR #21356: Size comparison from 21b1e5a to 5df092e Increases above 0.2%:
Increases (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (7 builds for cc13x2_26x2, linux)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 29, 2022
LuDuda
approved these changes
Aug 1, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
* [mrp] Align ReliableMessageMgr::GetBackoff() naming with spec Make variables and comments in the function more aligned with the current spec version so that it is easier to compare the code with the spec. Signed-off-by: Damian Krolik <[email protected]> * [mrp] Implement MRP_BACKOFF_MARGIN Base interval (active or idle) should be multiplied by MRP_BACKOFF_MARGIN = 1.1 before putting it in the MRP backoff formula. Signed-off-by: Damian Krolik <[email protected]> * [mrp] Increase MRP backoff time for SED sender When sender is sleepy, it may take more time until it receives an acknowledgment from a peer, so MRP backoff time should be extended by the sleepy active interval. Signed-off-by: Damian Krolik <[email protected]>
woody-apple
added a commit
that referenced
this pull request
Aug 1, 2022
* [mrp] Align ReliableMessageMgr::GetBackoff() naming with spec Make variables and comments in the function more aligned with the current spec version so that it is easier to compare the code with the spec. Signed-off-by: Damian Krolik <[email protected]> * [mrp] Implement MRP_BACKOFF_MARGIN Base interval (active or idle) should be multiplied by MRP_BACKOFF_MARGIN = 1.1 before putting it in the MRP backoff formula. Signed-off-by: Damian Krolik <[email protected]> * [mrp] Increase MRP backoff time for SED sender When sender is sleepy, it may take more time until it receives an acknowledgment from a peer, so MRP backoff time should be extended by the sleepy active interval. Signed-off-by: Damian Krolik <[email protected]> Co-authored-by: Damian Królik <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* [mrp] Align ReliableMessageMgr::GetBackoff() naming with spec Make variables and comments in the function more aligned with the current spec version so that it is easier to compare the code with the spec. Signed-off-by: Damian Krolik <[email protected]> * [mrp] Implement MRP_BACKOFF_MARGIN Base interval (active or idle) should be multiplied by MRP_BACKOFF_MARGIN = 1.1 before putting it in the MRP backoff formula. Signed-off-by: Damian Krolik <[email protected]> * [mrp] Increase MRP backoff time for SED sender When sender is sleepy, it may take more time until it receives an acknowledgment from a peer, so MRP backoff time should be extended by the sleepy active interval. Signed-off-by: Damian Krolik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
Extended unit tests.
Tested on a sleepy end device that the backoff time is increased by the sleepy active interval.