Move UseECM check for StartAdvertisement

[woody-apple]

Moved UseECM check above AppDelegate to ensure CommissioningWindowStatus is set before Commissioning Window is activated.

Problem

• OnCommissioningWindowOpened runs before a window status is set. This may cause confusion as to which chip command triggered the commissioning window.

Change overview

• Moved the UseECM check above OnCommissioningWindowOpened check.

Testing

• No tests were conducted. Only a minor change to functions that are not dependent of each other.

[github-actions]

PR #21291: Size comparison from 7069064 to 43cc0e2

Decreases (2 builds for cyw30739, telink)

platform	target	config	section	7069064	43cc0e2	change	% change
cyw30739	light	cyw930739m2evb_01	(read/write)	583006	582998	-8	-0.0
			.app_xip_area	460288	460280	-8	-0.0
telink	lighting-app	tlsr9518adk80d	text	583668	583666	-2	-0.0

Full report (10 builds for bl602, cyw30739, linux, mbed, telink)

platform	target	config	section	7069064	43cc0e2	change	% change
bl602	lighting-app	bl602	(read/write)	1381202	1381202	0	0.0
			.bss	117610	117610	0	0.0
			.data	4480	4480	0	0.0
			.text	1051196	1051196	0	0.0
		bl602+rpc	(read/write)	1426634	1426634	0	0.0
			.bss	125050	125050	0	0.0
			.data	4600	4600	0	0.0
			.text	1082892	1082892	0	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	583006	582998	-8	-0.0
			.app_xip_area	460288	460280	-8	-0.0
			.bss	65656	65656	0	0.0
			.data	716	716	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	lock	cyw930739m2evb_01	(read/write)	588926	588926	0	0.0
			.app_xip_area	461480	461480	0	0.0
			.bss	70384	70384	0	0.0
			.data	720	720	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	588738	588738	0	0.0
			.app_xip_area	466836	466836	0	0.0
			.bss	64896	64896	0	0.0
			.data	660	660	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
linux	chip-tool-ipv6only	arm64	(read only)	9835828	9835828	0	0.0
			(read/write)	678593	678593	0	0.0
			.bss	32897	32897	0	0.0
			.data	3272	3272	0	0.0
			.data.rel.ro	623936	623936	0	0.0
			.dynamic	560	560	0	0.0
			.got	13536	13536	0	0.0
			.init	24	24	0	0.0
			.init_array	192	192	0	0.0
			.rodata	467972	467972	0	0.0
			.text	7785556	7785556	0	0.0
	thermostat-no-ble	arm64	(read only)	2341452	2341452	0	0.0
			(read/write)	141393	141393	0	0.0
			.bss	55297	55297	0	0.0
			.data	1672	1672	0	0.0
			.data.rel.ro	75672	75672	0	0.0
			.dynamic	560	560	0	0.0
			.got	4984	4984	0	0.0
			.init	24	24	0	0.0
			.init_array	400	400	0	0.0
			.rodata	139588	139588	0	0.0
			.text	1964816	1964816	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2449256	2449256	0	0.0
			.bss	214508	214508	0	0.0
			.data	5872	5872	0	0.0
			.text	1411900	1411900	0	0.0
telink	light-switch-app	tlsr9518adk80d	(read/write)	799564	799564	0	0.0
			bss	70808	70808	0	0.0
			noinit	40416	40416	0	0.0
			text	567096	567096	0	0.0
	lighting-app	tlsr9518adk80d	(read/write)	819672	819672	0	0.0
			bss	71652	71652	0	0.0
			noinit	40416	40416	0	0.0
			text	583668	583666	-2	-0.0