Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move UseECM check for StartAdvertisement #21249

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Move UseECM check for StartAdvertisement #21249

merged 2 commits into from
Jul 27, 2022

Conversation

KrypticCliff
Copy link
Contributor

Moved UseECM check above AppDelegate to ensure CommissioningWindowStatus is set before Commissioning Window is activated.

Problem

  • OnCommissioningWindowOpened runs before a window status is set. This may cause confusion as to which chip command triggered the commissioning window.

Change overview

  • Moved the UseECM check above OnCommissioningWindowOpened check.

Testing

  • No tests were conducted. Only a minor change to functions that are not dependent of each other.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the app label Jul 26, 2022
@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

PR #21249: Size comparison from a7ad1d8 to 7384be1

Increases (3 builds for bl602, cc13x2_26x2)
platform target config section a7ad1d8 7384be1 change % change
bl602 lighting-app bl602 .text 1051520 1051524 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182932 182940 8 0.0
pump-controller-app LP_CC2652R7 (read only) 666751 666759 8 0.0
.text 581264 581272 8 0.0
Decreases (3 builds for cc13x2_26x2, esp32)
platform target config section a7ad1d8 7384be1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668427 668419 -8 -0.0
.text 579700 579692 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175768 175760 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1022114 1022112 -2 -0.0
.flash.text 1022114 1022112 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a7ad1d8 7384be1 change % change
bl602 lighting-app bl602 (read/write) 1381450 1381450 0 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051520 1051524 4 0.0
bl602+rpc (read/write) 1426866 1426866 0 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083188 1083188 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668427 668419 -8 -0.0
(read/write) 182932 182940 8 0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88411 88411 0 0.0
.text 579700 579692 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634019 0 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77635 77635 0 0.0
.text 556060 556060 0 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671567 0 0.0
(read/write) 169984 169984 0 0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76463 76463 0 0.0
.text 594624 594624 0 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653795 0 0.0
(read/write) 183444 183444 0 0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101163 101163 0 0.0
.text 552152 552152 0 0.0
pump-app LP_CC2652R7 (read only) 680999 680999 0 0.0
(read/write) 161384 161384 0 0.0
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89175 89175 0 0.0
.text 591340 591340 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666751 666759 8 0.0
(read/write) 175768 175760 -8 -0.0
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85007 85007 0 0.0
.text 581264 581272 8 0.0
shell LP_CC2652R7 (read only) 660894 660894 0 0.0
(read/write) 185984 185984 0 0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85174 85174 0 0.0
.text 575404 575404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583334 583334 0 0.0
.app_xip_area 460472 460472 0 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589254 589254 0 0.0
.app_xip_area 461664 461664 0 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589082 0 0.0
.app_xip_area 467036 467036 0 0.0
.bss 64896 64896 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088160 1088160 0 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 952816 952816 0 0.0
BRD4161A+rpc (read/write) 1142452 1142452 0 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990216 990216 0 0.0
BRD4161A+rs911x (read/write) 952704 952704 0 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 809644 809644 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128256 1128256 0 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 981820 981820 0 0.0
window-app BRD4161A (read/write) 1081636 1081636 0 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 944788 944788 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022114 1022112 -2 -0.0
(read/write) 1486586 1486586 0 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216264 216264 0 0.0
.flash.text 1022114 1022112 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075771 1075771 0 0.0
(read/write) 488608 488608 0 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246668 246668 0 0.0
.flash.text 1070387 1070387 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641776 641776 0 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567292 567292 0 0.0
lock k32w0+release (read/write) 699056 699056 0 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624124 624124 0 0.0
linux all-clusters-app debug (read only) 2986593 2986593 0 0.0
(read/write) 155480 155480 0 0.0
.bss 61856 61856 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85272 85272 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 268139 268139 0 0.0
.text 2540098 2540098 0 0.0
all-clusters-minimal-app debug (read only) 2829473 2829473 0 0.0
(read/write) 147184 147184 0 0.0
.bss 61056 61056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77864 77864 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268139 268139 0 0.0
.text 2385586 2385586 0 0.0
bridge-app debug+rpc (read only) 2344289 2344289 0 0.0
(read/write) 127056 127056 0 0.0
.bss 50144 50144 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67304 67304 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 200456 200456 0 0.0
.text 1981282 1981282 0 0.0
chip-tool debug (read only) 10385937 10385937 0 0.0
(read/write) 631088 631088 0 0.0
.bss 24824 24824 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596592 596592 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532693 532693 0 0.0
.text 8401668 8401668 0 0.0
chip-tool-ipv6only arm64 (read only) 9809588 9809588 0 0.0
(read/write) 678593 678593 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623936 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466436 466436 0 0.0
.text 7760852 7760852 0 0.0
lighting-app debug+rpc (read only) 2567361 2567361 0 0.0
(read/write) 129992 129992 0 0.0
.bss 49696 49696 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72344 72344 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 216144 216144 0 0.0
.text 2180578 2180578 0 0.0
lock-app debug (read only) 2532409 2532409 0 0.0
(read/write) 125040 125040 0 0.0
.bss 48096 48096 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69352 69352 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 231120 231120 0 0.0
.text 2135426 2135426 0 0.0
ota-provider-app debug (read only) 2336193 2336193 0 0.0
(read/write) 118840 118840 0 0.0
.bss 47744 47744 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 206136 206136 0 0.0
.text 1966610 1966610 0 0.0
ota-requestor-app debug (read only) 2461169 2461169 0 0.0
(read/write) 126200 126200 0 0.0
.bss 50112 50112 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67992 67992 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 210112 210112 0 0.0
.text 2078994 2078994 0 0.0
shell debug (read only) 2570009 2570009 0 0.0
(read/write) 141632 141632 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 230322 230322 0 0.0
.text 2181842 2181842 0 0.0
thermostat-no-ble arm64 (read only) 2342156 2342156 0 0.0
(read/write) 141393 141393 0 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75672 75672 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139588 139588 0 0.0
.text 1965520 1965520 0 0.0
tv-app debug (read only) 3117409 3117409 0 0.0
(read/write) 257224 257224 0 0.0
.bss 167160 167160 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78888 78888 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 252168 252168 0 0.0
.text 2676530 2676530 0 0.0
tv-casting-app debug (read only) 5372345 5372345 0 0.0
(read/write) 158464 158464 0 0.0
.bss 51320 51320 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98432 98432 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 337249 337249 0 0.0
.text 4768306 4768306 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449328 2449328 0 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1411972 1411972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1177131 0 0.0
bss 143132 143132 0 0.0
rodata 142660 142660 0 0.0
text 812408 812408 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1157183 0 0.0
bss 142368 142368 0 0.0
rodata 134192 134192 0 0.0
text 801716 801716 0 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687044 1687044 0 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1526880 1526880 0 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631148 1631148 0 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1471704 1471704 0 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551516 1551516 0 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400376 1400376 0 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589116 1589116 0 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433504 1433504 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799660 799660 0 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567186 567186 0 0.0
lighting-app tlsr9518adk80d (read/write) 819760 819760 0 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 583758 583758 0 0.0

@KrypticCliff KrypticCliff force-pushed the SwapCommissionStatus branch from 7384be1 to 44353fd Compare July 26, 2022 23:12
@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

PR #21249: Size comparison from 34a1b5c to 44353fd

Increases (3 builds for bl602, cc13x2_26x2, telink)
platform target config section 34a1b5c 44353fd change % change
bl602 lighting-app bl602+rpc (read/write) 1426866 1426874 8 0.0
.text 1083188 1083192 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668419 668427 8 0.0
.text 579692 579700 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799652 799660 8 0.0
text 567184 567186 2 0.0
Decreases (3 builds for cc13x2_26x2, k32w, nrfconnect)
platform target config section 34a1b5c 44353fd change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182940 182932 -8 -0.0
k32w light k32w0+release (read/write) 641776 641760 -16 -0.0
.text 567292 567276 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 812408 812404 -4 -0.0
Full report (25 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 34a1b5c 44353fd change % change
bl602 lighting-app bl602 (read/write) 1381450 1381450 0 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051524 1051524 0 0.0
bl602+rpc (read/write) 1426866 1426874 8 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083188 1083192 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668419 668427 8 0.0
(read/write) 182940 182932 -8 -0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88411 88411 0 0.0
.text 579692 579700 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634019 0 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77635 77635 0 0.0
.text 556060 556060 0 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671567 0 0.0
(read/write) 169984 169984 0 0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76463 76463 0 0.0
.text 594624 594624 0 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653795 0 0.0
(read/write) 183444 183444 0 0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101163 101163 0 0.0
.text 552152 552152 0 0.0
pump-app LP_CC2652R7 (read only) 680999 680999 0 0.0
(read/write) 161384 161384 0 0.0
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89175 89175 0 0.0
.text 591340 591340 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666759 666759 0 0.0
(read/write) 175760 175760 0 0.0
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85007 85007 0 0.0
.text 581272 581272 0 0.0
shell LP_CC2652R7 (read only) 660894 660894 0 0.0
(read/write) 185984 185984 0 0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85174 85174 0 0.0
.text 575404 575404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583334 583334 0 0.0
.app_xip_area 460472 460472 0 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589254 589254 0 0.0
.app_xip_area 461664 461664 0 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589082 0 0.0
.app_xip_area 467036 467036 0 0.0
.bss 64896 64896 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w0+release (read/write) 641776 641760 -16 -0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567292 567276 -16 -0.0
lock k32w0+release (read/write) 699056 699056 0 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624124 624124 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9835876 9835876 0 0.0
(read/write) 678593 678593 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623936 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467972 467972 0 0.0
.text 7785604 7785604 0 0.0
thermostat-no-ble arm64 (read only) 2342156 2342156 0 0.0
(read/write) 141393 141393 0 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75672 75672 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139588 139588 0 0.0
.text 1965520 1965520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449328 2449328 0 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1411972 1411972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1177131 0 0.0
bss 143132 143132 0 0.0
rodata 142660 142660 0 0.0
text 812408 812404 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1157183 0 0.0
bss 142368 142368 0 0.0
rodata 134192 134192 0 0.0
text 801716 801716 0 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687044 1687044 0 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1526880 1526880 0 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631148 1631148 0 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1471704 1471704 0 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551516 1551516 0 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400376 1400376 0 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589116 1589116 0 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433504 1433504 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799652 799660 8 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567184 567186 2 0.0
lighting-app tlsr9518adk80d (read/write) 819760 819760 0 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 583756 583756 0 0.0

@KrypticCliff
Move UseECM check for StartAdvertisement
2b7179d 
Moved UseECM check above AppDelegate to ensure status is set before
Commissioning Window is activated.
@KrypticCliff KrypticCliff force-pushed the SwapCommissionStatus branch from 44353fd to 2b7179d Compare July 26, 2022 23:53
@restyled-io restyled-io bot mentioned this pull request Jul 26, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 27, 2022 •
edited
Loading

PR #21249: Size comparison from 34a1b5c to 2b7179d

Increases (3 builds for cc13x2_26x2, esp32, telink)
platform target config section 34a1b5c 2b7179d change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668419 668427 8 0.0
.text 579692 579700 8 0.0
esp32 all-clusters-app c3devkit (read only) 1022112 1022114 2 0.0
.flash.text 1022112 1022114 2 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799652 799660 8 0.0
text 567184 567186 2 0.0
Decreases (3 builds for bl602, cc13x2_26x2, nrfconnect)
platform target config section 34a1b5c 2b7179d change % change
bl602 lighting-app bl602 .text 1051524 1051520 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182940 182932 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 812408 812404 -4 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 34a1b5c 2b7179d change % change
bl602 lighting-app bl602 (read/write) 1381450 1381450 0 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051524 1051520 -4 -0.0
bl602+rpc (read/write) 1426866 1426866 0 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083188 1083188 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668419 668427 8 0.0
(read/write) 182940 182932 -8 -0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88411 88411 0 0.0
.text 579692 579700 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634019 0 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77635 77635 0 0.0
.text 556060 556060 0 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671567 0 0.0
(read/write) 169984 169984 0 0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76463 76463 0 0.0
.text 594624 594624 0 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653795 0 0.0
(read/write) 183444 183444 0 0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101163 101163 0 0.0
.text 552152 552152 0 0.0
pump-app LP_CC2652R7 (read only) 680999 680999 0 0.0
(read/write) 161384 161384 0 0.0
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89175 89175 0 0.0
.text 591340 591340 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666759 666759 0 0.0
(read/write) 175760 175760 0 0.0
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85007 85007 0 0.0
.text 581272 581272 0 0.0
shell LP_CC2652R7 (read only) 660894 660894 0 0.0
(read/write) 185984 185984 0 0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85174 85174 0 0.0
.text 575404 575404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583334 583334 0 0.0
.app_xip_area 460472 460472 0 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589254 589254 0 0.0
.app_xip_area 461664 461664 0 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589082 0 0.0
.app_xip_area 467036 467036 0 0.0
.bss 64896 64896 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088160 1088160 0 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 952816 952816 0 0.0
BRD4161A+rpc (read/write) 1142452 1142452 0 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990216 990216 0 0.0
BRD4161A+rs911x (read/write) 952704 952704 0 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 809644 809644 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128256 1128256 0 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 981820 981820 0 0.0
window-app BRD4161A (read/write) 1081636 1081636 0 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 944788 944788 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022112 1022114 2 0.0
(read/write) 1486586 1486586 0 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216264 216264 0 0.0
.flash.text 1022112 1022114 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075771 1075771 0 0.0
(read/write) 488608 488608 0 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246668 246668 0 0.0
.flash.text 1070387 1070387 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641776 641776 0 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567292 567292 0 0.0
lock k32w0+release (read/write) 699056 699056 0 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624124 624124 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9835876 9835876 0 0.0
(read/write) 678593 678593 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623936 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467972 467972 0 0.0
.text 7785604 7785604 0 0.0
thermostat-no-ble arm64 (read only) 2342156 2342156 0 0.0
(read/write) 141393 141393 0 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75672 75672 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139588 139588 0 0.0
.text 1965520 1965520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449328 2449328 0 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1411972 1411972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1177131 0 0.0
bss 143132 143132 0 0.0
rodata 142660 142660 0 0.0
text 812408 812404 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1157183 0 0.0
bss 142368 142368 0 0.0
rodata 134192 134192 0 0.0
text 801716 801716 0 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687044 1687044 0 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1526880 1526880 0 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631148 1631148 0 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1471704 1471704 0 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551516 1551516 0 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400376 1400376 0 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589116 1589116 0 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433504 1433504 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799652 799660 8 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567184 567186 2 0.0
lighting-app tlsr9518adk80d (read/write) 819760 819760 0 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 583756 583756 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@github-actions
Copy link

github-actions bot commented Jul 27, 2022 •
edited
Loading

PR #21249: Size comparison from 34a1b5c to 8b08490

Increases (5 builds for cc13x2_26x2, esp32, telink)
platform target config section 34a1b5c 8b08490 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668419 668427 8 0.0
.text 579692 579700 8 0.0
pump-app LP_CC2652R7 (read/write) 161384 161392 8 0.0
esp32 all-clusters-app c3devkit (read only) 1022112 1022114 2 0.0
.flash.text 1022112 1022114 2 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799652 799660 8 0.0
text 567184 567186 2 0.0
lighting-app tlsr9518adk80d text 583756 583758 2 0.0
Decreases (3 builds for cc13x2_26x2, nrfconnect)
platform target config section 34a1b5c 8b08490 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182940 182932 -8 -0.0
pump-app LP_CC2652R7 (read only) 680999 680991 -8 -0.0
.text 591340 591332 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 812408 812404 -4 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 34a1b5c 8b08490 change % change
bl602 lighting-app bl602 (read/write) 1381450 1381450 0 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051524 1051524 0 0.0
bl602+rpc (read/write) 1426866 1426866 0 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083188 1083188 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668419 668427 8 0.0
(read/write) 182940 182932 -8 -0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88411 88411 0 0.0
.text 579692 579700 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634019 0 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77635 77635 0 0.0
.text 556060 556060 0 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671567 0 0.0
(read/write) 169984 169984 0 0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76463 76463 0 0.0
.text 594624 594624 0 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653795 0 0.0
(read/write) 183444 183444 0 0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101163 101163 0 0.0
.text 552152 552152 0 0.0
pump-app LP_CC2652R7 (read only) 680999 680991 -8 -0.0
(read/write) 161384 161392 8 0.0
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89175 89175 0 0.0
.text 591340 591332 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 666759 666759 0 0.0
(read/write) 175760 175760 0 0.0
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85007 85007 0 0.0
.text 581272 581272 0 0.0
shell LP_CC2652R7 (read only) 660894 660894 0 0.0
(read/write) 185984 185984 0 0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85174 85174 0 0.0
.text 575404 575404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583334 583334 0 0.0
.app_xip_area 460472 460472 0 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589254 589254 0 0.0
.app_xip_area 461664 461664 0 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589082 0 0.0
.app_xip_area 467036 467036 0 0.0
.bss 64896 64896 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088160 1088160 0 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 952816 952816 0 0.0
BRD4161A+rpc (read/write) 1142452 1142452 0 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990216 990216 0 0.0
BRD4161A+rs911x (read/write) 952704 952704 0 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 809644 809644 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128256 1128256 0 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 981820 981820 0 0.0
window-app BRD4161A (read/write) 1081636 1081636 0 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 944788 944788 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022112 1022114 2 0.0
(read/write) 1486586 1486586 0 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216264 216264 0 0.0
.flash.text 1022112 1022114 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075771 1075771 0 0.0
(read/write) 488608 488608 0 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246668 246668 0 0.0
.flash.text 1070387 1070387 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641776 641776 0 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567292 567292 0 0.0
lock k32w0+release (read/write) 699056 699056 0 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624124 624124 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9835876 9835876 0 0.0
(read/write) 678593 678593 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623936 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467972 467972 0 0.0
.text 7785604 7785604 0 0.0
thermostat-no-ble arm64 (read only) 2342156 2342156 0 0.0
(read/write) 141393 141393 0 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75672 75672 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139588 139588 0 0.0
.text 1965520 1965520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449328 2449328 0 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1411972 1411972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1177131 0 0.0
bss 143132 143132 0 0.0
rodata 142660 142660 0 0.0
text 812408 812404 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1157183 0 0.0
bss 142368 142368 0 0.0
rodata 134192 134192 0 0.0
text 801716 801716 0 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687044 1687044 0 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1526880 1526880 0 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631148 1631148 0 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1471704 1471704 0 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551516 1551516 0 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400376 1400376 0 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589116 1589116 0 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433504 1433504 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799652 799660 8 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567184 567186 2 0.0
lighting-app tlsr9518adk80d (read/write) 819760 819760 0 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 583756 583758 2 0.0

@woody-apple woody-apple merged commit a6a999d into project-chip:master Jul 27, 2022
github-actions bot pushed a commit that referenced this pull request Jul 27, 2022
@KrypticCliff @bzbarsky-apple @web-flow
Move UseECM check for StartAdvertisement (#21249)
43cc0e2 
* Move UseECM check for StartAdvertisement

Moved UseECM check above AppDelegate to ensure status is set before
Commissioning Window is activated.

* Fix restyle issue

Co-authored-by: Boris Zbarsky <[email protected]>
woody-apple added a commit that referenced this pull request Jul 27, 2022
@woody-apple @KrypticCliff @bzbarsky-apple
Move UseECM check for StartAdvertisement (#21249) (#21291)
c0c86ac 
* Move UseECM check for StartAdvertisement

Moved UseECM check above AppDelegate to ensure status is set before
Commissioning Window is activated.

* Fix restyle issue

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Clifton Rawlings <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@KrypticCliff @bzbarsky-apple @isiu-apple
Move UseECM check for StartAdvertisement (project-chip#21249)
39fe894 
* Move UseECM check for StartAdvertisement

Moved UseECM check above AppDelegate to ensure status is set before
Commissioning Window is activated.

* Fix restyle issue

Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved sve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KrypticCliff @CLAassistant @mrjerryjohns @bzbarsky-apple @woody-apple