Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the spec-required FabricIndex field to Leave event. #21247

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Add the spec-required FabricIndex field to Leave event. #21247

merged 1 commit into from
Jul 28, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes #21192

Problem

Missing required field.

Change overview

Add the field

Testing

Ran this in chip-tool interactive mode:

pairing code 17 749701123365521327694
basic subscribe-event leave 5 20 17 0
operationalcredentials remove-fabric 1 17 0

and made sure the event has a FabricIndex field with the right value.

@bzbarsky-apple bzbarsky-apple changed the title Add the spec-required FabricIndex field to LeaveEvent. Add the spec-required FabricIndex field to Leave event. Jul 26, 2022
@bzbarsky-apple
Add the spec-required FabricIndex field to Leave event.
68dc9be 
Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes project-chip#21192
@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

PR #21247: Size comparison from a7ad1d8 to 68dc9be

Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a7ad1d8 68dc9be change % change
bl602 lighting-app bl602 (read/write) 1381450 1381482 32 0.0
.text 1051520 1051556 36 0.0
bl602+rpc (read/write) 1426866 1426898 32 0.0
.text 1083188 1083220 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668427 668491 64 0.0
.text 579700 579764 64 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634091 72 0.0
.text 556060 556132 72 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671631 64 0.0
.text 594624 594688 64 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653851 56 0.0
.text 552152 552208 56 0.0
pump-app LP_CC2652R7 (read only) 680999 681063 64 0.0
.text 591340 591404 64 0.0
pump-controller-app LP_CC2652R7 (read only) 666751 666823 72 0.0
.text 581264 581336 72 0.0
shell LP_CC2652R7 (read only) 660894 660950 56 0.0
.text 575404 575460 56 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583334 583390 56 0.0
.app_xip_area 460472 460528 56 0.0
lock cyw930739m2evb_01 (read/write) 589254 589310 56 0.0
.app_xip_area 461664 461720 56 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589146 64 0.0
.app_xip_area 467036 467100 64 0.0
efr32 lighting-app BRD4161A (read/write) 1088160 1088192 32 0.0
.text 952816 952848 32 0.0
BRD4161A+rpc (read/write) 1142452 1142484 32 0.0
.text 990216 990248 32 0.0
BRD4161A+rs911x (read/write) 952704 952736 32 0.0
.text 809644 809676 32 0.0
lock-app BRD4161A+wf200 (read/write) 1128256 1128320 64 0.0
.text 981820 981884 64 0.0
window-app BRD4161A (read/write) 1081636 1081668 32 0.0
.text 944788 944820 32 0.0
esp32 all-clusters-app c3devkit (read only) 1022114 1022176 62 0.0
.flash.text 1022114 1022176 62 0.0
m5stack (read only) 1075771 1075803 32 0.0
.flash.text 1070387 1070419 32 0.0
k32w light k32w0+release (read/write) 641776 641840 64 0.0
.text 567292 567356 64 0.0
lock k32w0+release (read/write) 699056 699120 64 0.0
.text 624124 624188 64 0.0
linux all-clusters-app debug (read only) 2986593 2986737 144 0.0
.text 2540098 2540242 144 0.0
all-clusters-minimal-app debug (read only) 2829473 2829617 144 0.0
.text 2385586 2385730 144 0.0
bridge-app debug+rpc (read only) 2344289 2344433 144 0.0
.text 1981282 1981426 144 0.0
chip-tool debug (read only) 10385937 10386321 384 0.0
.text 8401668 8402052 384 0.0
chip-tool-ipv6only arm64 (read only) 9809588 9809860 272 0.0
.text 7760852 7761124 272 0.0
lighting-app debug+rpc (read only) 2567361 2567505 144 0.0
.text 2180578 2180722 144 0.0
lock-app debug (read only) 2532409 2532553 144 0.0
.text 2135426 2135570 144 0.0
ota-provider-app debug (read only) 2336193 2336353 160 0.0
.text 1966610 1966770 160 0.0
ota-requestor-app debug (read only) 2461169 2461313 144 0.0
.text 2078994 2079138 144 0.0
shell debug (read only) 2570009 2570153 144 0.0
.text 2181842 2181986 144 0.0
thermostat-no-ble arm64 (read only) 2342156 2342332 176 0.0
.text 1965520 1965696 176 0.0
tv-app debug (read only) 3117409 3117553 144 0.0
.text 2676530 2676674 144 0.0
tv-casting-app debug (read only) 5372345 5372873 528 0.0
.text 4768306 4768834 528 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2449328 2449392 64 0.0
.text 1411972 1412036 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1177195 64 0.0
text 812408 812468 60 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1157231 48 0.0
text 801716 801772 56 0.0
p6 all-clusters-app default (read/write) 1687044 1687076 32 0.0
.text 1526880 1526912 32 0.0
all-clusters-minimal-app default (read/write) 1631148 1631196 48 0.0
.text 1471704 1471752 48 0.0
light-app default (read/write) 1551516 1551532 16 0.0
.text 1400376 1400392 16 0.0
lock-app default (read/write) 1589116 1589148 32 0.0
.text 1433504 1433536 32 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799660 799724 64 0.0
text 567186 567250 64 0.0
lighting-app tlsr9518adk80d (read/write) 819760 819824 64 0.0
text 583758 583820 62 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section a7ad1d8 68dc9be change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182932 182868 -64 -0.0
lock-ftd LP_CC2652R7 (read/write) 169984 169920 -64 -0.0
lock-mtd LP_CC2652R7 (read/write) 183444 183388 -56 -0.0
pump-app LP_CC2652R7 (read/write) 161384 161320 -64 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175768 175696 -72 -0.0
shell LP_CC2652R7 (read/write) 185984 185928 -56 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a7ad1d8 68dc9be change % change
bl602 lighting-app bl602 (read/write) 1381450 1381482 32 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051520 1051556 36 0.0
bl602+rpc (read/write) 1426866 1426898 32 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083188 1083220 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668427 668491 64 0.0
(read/write) 182932 182868 -64 -0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88411 88411 0 0.0
.text 579700 579764 64 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634091 72 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77635 77635 0 0.0
.text 556060 556132 72 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671631 64 0.0
(read/write) 169984 169920 -64 -0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76463 76463 0 0.0
.text 594624 594688 64 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653851 56 0.0
(read/write) 183444 183388 -56 -0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101163 101163 0 0.0
.text 552152 552208 56 0.0
pump-app LP_CC2652R7 (read only) 680999 681063 64 0.0
(read/write) 161384 161320 -64 -0.0
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89175 89175 0 0.0
.text 591340 591404 64 0.0
pump-controller-app LP_CC2652R7 (read only) 666751 666823 72 0.0
(read/write) 175768 175696 -72 -0.0
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85007 85007 0 0.0
.text 581264 581336 72 0.0
shell LP_CC2652R7 (read only) 660894 660950 56 0.0
(read/write) 185984 185928 -56 -0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85174 85174 0 0.0
.text 575404 575460 56 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583334 583390 56 0.0
.app_xip_area 460472 460528 56 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589254 589310 56 0.0
.app_xip_area 461664 461720 56 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589146 64 0.0
.app_xip_area 467036 467100 64 0.0
.bss 64896 64896 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088160 1088192 32 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 952816 952848 32 0.0
BRD4161A+rpc (read/write) 1142452 1142484 32 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990216 990248 32 0.0
BRD4161A+rs911x (read/write) 952704 952736 32 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 809644 809676 32 0.0
lock-app BRD4161A+wf200 (read/write) 1128256 1128320 64 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 981820 981884 64 0.0
window-app BRD4161A (read/write) 1081636 1081668 32 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 944788 944820 32 0.0
esp32 all-clusters-app c3devkit (read only) 1022114 1022176 62 0.0
(read/write) 1486586 1486586 0 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216264 216264 0 0.0
.flash.text 1022114 1022176 62 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075771 1075803 32 0.0
(read/write) 488608 488608 0 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246668 246668 0 0.0
.flash.text 1070387 1070419 32 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641776 641840 64 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567292 567356 64 0.0
lock k32w0+release (read/write) 699056 699120 64 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624124 624188 64 0.0
linux all-clusters-app debug (read only) 2986593 2986737 144 0.0
(read/write) 155480 155480 0 0.0
.bss 61856 61856 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85272 85272 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 268139 268139 0 0.0
.text 2540098 2540242 144 0.0
all-clusters-minimal-app debug (read only) 2829473 2829617 144 0.0
(read/write) 147184 147184 0 0.0
.bss 61056 61056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77864 77864 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268139 268139 0 0.0
.text 2385586 2385730 144 0.0
bridge-app debug+rpc (read only) 2344289 2344433 144 0.0
(read/write) 127056 127056 0 0.0
.bss 50144 50144 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67304 67304 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 200456 200456 0 0.0
.text 1981282 1981426 144 0.0
chip-tool debug (read only) 10385937 10386321 384 0.0
(read/write) 631088 631088 0 0.0
.bss 24824 24824 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596592 596592 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532693 532693 0 0.0
.text 8401668 8402052 384 0.0
chip-tool-ipv6only arm64 (read only) 9809588 9809860 272 0.0
(read/write) 678593 678593 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623936 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466436 466436 0 0.0
.text 7760852 7761124 272 0.0
lighting-app debug+rpc (read only) 2567361 2567505 144 0.0
(read/write) 129992 129992 0 0.0
.bss 49696 49696 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72344 72344 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 216144 216144 0 0.0
.text 2180578 2180722 144 0.0
lock-app debug (read only) 2532409 2532553 144 0.0
(read/write) 125040 125040 0 0.0
.bss 48096 48096 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69352 69352 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 231120 231120 0 0.0
.text 2135426 2135570 144 0.0
ota-provider-app debug (read only) 2336193 2336353 160 0.0
(read/write) 118840 118840 0 0.0
.bss 47744 47744 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 206136 206136 0 0.0
.text 1966610 1966770 160 0.0
ota-requestor-app debug (read only) 2461169 2461313 144 0.0
(read/write) 126200 126200 0 0.0
.bss 50112 50112 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67992 67992 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 210112 210112 0 0.0
.text 2078994 2079138 144 0.0
shell debug (read only) 2570009 2570153 144 0.0
(read/write) 141632 141632 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 230322 230322 0 0.0
.text 2181842 2181986 144 0.0
thermostat-no-ble arm64 (read only) 2342156 2342332 176 0.0
(read/write) 141393 141393 0 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75672 75672 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139588 139588 0 0.0
.text 1965520 1965696 176 0.0
tv-app debug (read only) 3117409 3117553 144 0.0
(read/write) 257224 257224 0 0.0
.bss 167160 167160 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78888 78888 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 252168 252168 0 0.0
.text 2676530 2676674 144 0.0
tv-casting-app debug (read only) 5372345 5372873 528 0.0
(read/write) 158464 158464 0 0.0
.bss 51320 51320 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98432 98432 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 337249 337249 0 0.0
.text 4768306 4768834 528 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449328 2449392 64 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1411972 1412036 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1177195 64 0.0
bss 143132 143132 0 0.0
rodata 142660 142660 0 0.0
text 812408 812468 60 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1157231 48 0.0
bss 142368 142368 0 0.0
rodata 134192 134192 0 0.0
text 801716 801772 56 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687044 1687076 32 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1526880 1526912 32 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631148 1631196 48 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1471704 1471752 48 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551516 1551532 16 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400376 1400392 16 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589116 1589148 32 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433504 1433536 32 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799660 799724 64 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567186 567250 64 0.0
lighting-app tlsr9518adk80d (read/write) 819760 819824 64 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 583758 583820 62 0.0

@woody-apple woody-apple enabled auto-merge (squash) July 27, 2022 23:40
@woody-apple woody-apple merged commit 5022eb1 into project-chip:master Jul 28, 2022
github-actions bot pushed a commit that referenced this pull request Jul 28, 2022
@bzbarsky-apple @web-flow
Add the spec-required FabricIndex field to Leave event. (#21247)
f3470ed 
Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes #21192
@bzbarsky-apple bzbarsky-apple deleted the leave-event-spec branch July 28, 2022 15:36
woody-apple added a commit that referenced this pull request Jul 28, 2022
@woody-apple @bzbarsky-apple
Add the spec-required FabricIndex field to Leave event. (#21247) (#21355
77d5ee3 
)

Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes #21192

Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@bzbarsky-apple @isiu-apple
Add the spec-required FabricIndex field to Leave event. (project-chip…
67cce29 
…#21247)

Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes project-chip#21192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller darwin examples review - approved tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leave event missing mandatory FabricIndex field
3 participants
@bzbarsky-apple @tcarmelveilleux @woody-apple