Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leave event missing mandatory FabricIndex field #21192

Closed
bzbarsky-apple opened this issue Jul 25, 2022 · 0 comments · Fixed by #21210 or #21247
Closed

Leave event missing mandatory FabricIndex field #21192

bzbarsky-apple opened this issue Jul 25, 2022 · 0 comments · Fixed by #21210 or #21247
Assignees
@bzbarsky-apple
Labels
spec Mismatch between spec and implementation

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

Leave events don't say which fabric is being left.

Proposed Solution

Need to fix that. Need to get project-chip/zap#628 merged and then pulled into Matter first, because these events are not fabric-sensitive.
@bzbarsky-apple bzbarsky-apple added the spec Mismatch between spec and implementation label Jul 25, 2022
@bzbarsky-apple bzbarsky-apple self-assigned this Jul 25, 2022
@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 26, 2022
Merged
@woody-apple woody-apple mentioned this issue Jul 26, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 26, 2022
@bzbarsky-apple
Add the spec-required FabricIndex field to LeaveEvent.
7a10b6c 
Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes project-chip#21192
@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 26, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 26, 2022
@bzbarsky-apple
Add the spec-required FabricIndex field to Leave event.
68dc9be 
Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes project-chip#21192
woody-apple pushed a commit that referenced this issue Jul 28, 2022
@bzbarsky-apple
Add the spec-required FabricIndex field to Leave event. (#21247)
5022eb1 
Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes #21192
github-actions bot pushed a commit that referenced this issue Jul 28, 2022
@bzbarsky-apple @web-flow
Add the spec-required FabricIndex field to Leave event. (#21247)
f3470ed 
Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes #21192
@woody-apple woody-apple mentioned this issue Jul 28, 2022
Merged
woody-apple added a commit that referenced this issue Jul 28, 2022
@woody-apple @bzbarsky-apple
Add the spec-required FabricIndex field to Leave event. (#21247) (#21355
77d5ee3 
)

Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes #21192

Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Add the spec-required FabricIndex field to Leave event. (project-chip…
67cce29 
…#21247)

Also fixes up the chip-tool logging for events to not have confusing indents.

Fixes project-chip#21192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
spec Mismatch between spec and implementation
Projects
None yet
Milestone
No milestone
1 participant
@bzbarsky-apple