Stop calling the attribute change callback on the wrong thread in bridge-app. #21230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
mspang,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
…dge-app. A few changes here: 1. Stop trying to pass values to the attribute change callback, since those get ignored anyway. 2. Run the attribute change callback off a task on the Matter thread, instead of calling it directly from a different thread. 3. Change initial bridge setup to set state before setting change callbacks, so we won't try to notify changes at startup before the Matter stack is actually initialized. Fixes project-chip#21212
bzbarsky-apple
force-pushed
the
fix-bridge-threading
branch
from
1ed9040 to
892107a
Compare
|
PR #21230: Size comparison from d94cbdc to 892107a Increases (8 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, telink)
Decreases (3 builds for cc13x2_26x2, esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 27, 2022
|
Fast tracking platform changes. |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 27, 2022
…dge-app. (#21230) A few changes here: 1. Stop trying to pass values to the attribute change callback, since those get ignored anyway. 2. Run the attribute change callback off a task on the Matter thread, instead of calling it directly from a different thread. 3. Change initial bridge setup to set state before setting change callbacks, so we won't try to notify changes at startup before the Matter stack is actually initialized. Fixes #21212
woody-apple
added a commit
that referenced
this pull request
Jul 28, 2022
…dge-app. (#21230) (#21309) A few changes here: 1. Stop trying to pass values to the attribute change callback, since those get ignored anyway. 2. Run the attribute change callback off a task on the Matter thread, instead of calling it directly from a different thread. 3. Change initial bridge setup to set state before setting change callbacks, so we won't try to notify changes at startup before the Matter stack is actually initialized. Fixes #21212 Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…dge-app. (project-chip#21230) A few changes here: 1. Stop trying to pass values to the attribute change callback, since those get ignored anyway. 2. Run the attribute change callback off a task on the Matter thread, instead of calling it directly from a different thread. 3. Change initial bridge setup to set state before setting change callbacks, so we won't try to notify changes at startup before the Matter stack is actually initialized. Fixes project-chip#21212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes here:
ignored anyway.
calling it directly from a different thread.
we won't try to notify changes at startup before the Matter stack is actually
initialized.
Fixes #21212
Problem
See above.
Change overview
See above.
Testing
Ran bridge-app locally. Tried triggering things by typing
bandcfollowed by return in the bridge app, and with these changes no longer fail the threading asserts.