[Darwin] Make MTRControllerFactory the OTA Provider Delegate #21224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #21224: Size comparison from 925cff6 to 7e92471 Increases (2 builds for esp32, telink)
Decreases (1 build for telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
requested changes
Jul 26, 2022
vivien-apple
force-pushed
the
BDX_OTADelegateFromControllerToControllerFactory
branch
from
7e92471 to
bd5785f
Compare
|
PR #21224: Size comparison from 750eedf to bd5785f Increases (3 builds for cc13x2_26x2, cyw30739, telink)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Comment on lines
+467
to
+468
| auto systemState = _controllerFactory->GetSystemState(); | ||
| _otaProviderDelegateBridge->Init(systemState->SystemLayer(), systemState->ExchangeMgr()); |
There was a problem hiding this comment.
Unfortunately, at this point there might not be a usable system state on the controller factory. It gets created when the C++ controller is actually created, which has not happened here yet. :(
And yes, I know I said it's about where we do the event loop bits. I was wrong about this part here...
We really need to add some actual tests exercising this thing as controllers start up and shut down, to make sure it all works properly.
The right place to put this init is probably at the place where we start a controller successfully and the controller count is 1...
woody-apple
added a commit
that referenced
this pull request
Jul 28, 2022
…#21304) Co-authored-by: Vivien Nicolas <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR moves the OTA Provider delegate from
MTRDeviceControllertoMTRControllerFactory.It also internalise the conversion from an ota URL to a proper BDX URI since the BDX uri is supposed to use the nodeId used for the CASE session where the
QueryImageResponseis issued:This PR also change onto which dispatch queue the method of the
MTROTAProviderDelegateare processed. Everything happens onto the chip work dispatch queue. It should not change much of the behaviour since most of the delegates exposes a completion handler that can be called from a different queue, their internally ensure that the work is dispatched to the chip work dispatch queue.#fix #20948
Change overview
MTRControllerFactory.MTROTAProviderDelegatecallback methods.Testing
It has been tested using the same procedure than #21161