-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BDX][Darwin] Add basic BDX protocol supports for Matter.framework #21161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… passed as argument to the command otasoftwareupdateapp candidate-file-path contains errors
Closed
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel and
lazarkov
July 25, 2022 13:34
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
July 25, 2022 13:34
PR #21161: Size comparison from 2557f51 to 42ccf5e Increases (4 builds for cc13x2_26x2, esp32, telink)
Decreases (2 builds for cc13x2_26x2, nrfconnect)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you for adding it to darwin-framework-tool!
woody-apple
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking platform changes
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
…21161) * [darwin-framework-tool] Do not exit from interactive mode if the file passed as argument to the command otasoftwareupdateapp candidate-file-path contains errors * [documentation] Fix some typos in the documentation of the bdx protocol * [BDX][Darwin] Add basic BDX protocol supports for Matter.framework
woody-apple
added a commit
that referenced
this pull request
Jul 25, 2022
…21161) (#21178) * [darwin-framework-tool] Do not exit from interactive mode if the file passed as argument to the command otasoftwareupdateapp candidate-file-path contains errors * [documentation] Fix some typos in the documentation of the bdx protocol * [BDX][Darwin] Add basic BDX protocol supports for Matter.framework Co-authored-by: Vivien Nicolas <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…roject-chip#21161) * [darwin-framework-tool] Do not exit from interactive mode if the file passed as argument to the command otasoftwareupdateapp candidate-file-path contains errors * [documentation] Fix some typos in the documentation of the bdx protocol * [BDX][Darwin] Add basic BDX protocol supports for Matter.framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR add an early BDX protocol support to Matter.framework.
It can be validated, with the pre condition that
chip-ota-requestor-app
has been commissioned onto thedarwin-framework-tool
fabric:Most of the BDX work is handle internally into the framework while only some methods to let the application returns the OTA image file, and the OTA image block are exposed.
There is still more work to do, such as handling
MaxLength
, exposing some bdx configuration properties to the delegate, enhance the mechanism used to select if bdx protocol should be used or not, ...Change overview
Testing
See description.