Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device types per reported issues #21045

Merged
merged 10 commits into from
Aug 3, 2022
Merged

Update device types per reported issues #21045

Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fe89391
Update device types per reported issues
lazarkov Jul 21, 2022
a3611df
update device types
lazarkov Jul 21, 2022
9a7e9c8
Update xml per request
lazarkov Jul 23, 2022
49b9414
Update per comments
lazarkov Jul 27, 2022
8cd0c89
Added descriptor cluster to basic video player
lazarkov Jul 28, 2022
dfd1e43
Update src/app/zap-templates/zcl/data-model/chip/matter-devices.xml
lazarkov Jul 29, 2022
25126da
Add more updates per comments
lazarkov Jul 29, 2022
17755a1
Update per comment
lazarkov Jul 30, 2022
7964cd2
Update src/app/zap-templates/zcl/data-model/chip/matter-devices.xml
lazarkov Aug 2, 2022
09ca508
Apply suggestions from code review
bzbarsky-apple Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 66 additions & 27 deletions src/app/zap-templates/zcl/data-model/chip/matter-devices.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1957,72 +1957,111 @@ limitations under the License.
<profileId editable="false">0x0103</profileId>
<deviceId editable="false">0x0023</deviceId>
<clusters lockOthers="true">
<include cluster="Identify" client="false" server="true" clientLocked="true" serverLocked="true">
<requireAttribute>IDENTIFY_TIME</requireAttribute>
<requireAttribute>IDENTIFY_TYPE</requireAttribute>
<requireCommand>Identify</requireCommand>
<requireCommand>IdentifyQuery</requireCommand>
<requireCommand>TriggerEffect</requireCommand>
</include>
<include cluster="Descriptor" client="false" server="true" clientLocked="true" serverLocked="true">
<requireAttribute>DEVICE_TYPE_LIST</requireAttribute>
<requireAttribute>SERVER_LIST</requireAttribute>
<requireAttribute>CLIENT_LIST</requireAttribute>
<requireAttribute>PARTS_LIST</requireAttribute>
</include>
<include cluster="Binding" client="true" server="false" clientLocked="false" serverLocked="true">
lazarkov marked this conversation as resolved.
Show resolved Hide resolved
<requireAttribute>BINDING</requireAttribute>
</include>
<include cluster="Media Playback" client="false" server="true" clientLocked="false" serverLocked="true"></include>
lazarkov marked this conversation as resolved.
Show resolved Hide resolved
<include cluster="Keypad Input" client="false" server="true" clientLocked="false" serverLocked="true"></include>
<include cluster="Application Launcher" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Media Input" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="On/Off" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="On/Off" client="false" server="true" clientLocked="false" serverLocked="true"></include>
<include cluster="Channel" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Audio Output" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Low Power" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Wake on LAN" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Target Navigator" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Account Login" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Content Launcher" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Content Launcher" client="false" server="true" clientLocked="false" serverLocked="true"></include>
</clusters>
</deviceType>

<deviceType>
<name>MA-basic-videoplayer</name>
<domain>CHIP</domain>
<typeName>Matter Basic Video Player</typeName>
<profileId editable="false">0x0103</profileId>
<deviceId editable="false">0x0028</deviceId>
<clusters lockOthers="true">
<include cluster="Identify" client="false" server="true" clientLocked="true" serverLocked="true">
<requireAttribute>IDENTIFY_TIME</requireAttribute>
<requireAttribute>IDENTIFY_TYPE</requireAttribute>
<requireCommand>Identify</requireCommand>
<requireCommand>IdentifyQuery</requireCommand>
<requireCommand>TriggerEffect</requireCommand>
</include>
<include cluster="Descriptor" client="false" server="true" clientLocked="true" serverLocked="true">
lazarkov marked this conversation as resolved.
Show resolved Hide resolved
<requireAttribute>DEVICE_TYPE_LIST</requireAttribute>
<requireAttribute>SERVER_LIST</requireAttribute>
<requireAttribute>CLIENT_LIST</requireAttribute>
<requireAttribute>PARTS_LIST</requireAttribute>
</include>
<include cluster="Binding" client="true" server="false" clientLocked="false" serverLocked="true">
<requireAttribute>BINDING</requireAttribute>
</include>
<include cluster="Media Playback" client="false" server="true" clientLocked="false" serverLocked="true"></include>
<include cluster="Keypad Input" client="false" server="true" clientLocked="false" serverLocked="true"></include>
<include cluster="Application Launcher" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Media Input" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="On/Off" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="On/Off" client="false" server="true" clientLocked="false" serverLocked="true"></include>
<include cluster="Channel" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Audio Output" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Low Power" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Wake on LAN" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Target Navigator" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Account Login" client="false" server="true" clientLocked="false" serverLocked="false"></include>
<include cluster="Content Launcher" client="false" server="true" clientLocked="false" serverLocked="false"></include>
</clusters>
</deviceType>
<deviceType>
<name>MA-casting-videoclient</name>
<domain>CHIP</domain>
<typeName>Matter Casting Video Client</typeName>
lazarkov marked this conversation as resolved.
Show resolved Hide resolved
<profileId editable="false">0x0103</profileId>
<deviceId editable="false">0x0029</deviceId>
<clusters lockOthers="true">
<include cluster="Descriptor" client="true" server="false" clientLocked="true" serverLocked="true">
<requireAttribute>DEVICE_TYPE_LIST</requireAttribute>
<requireAttribute>SERVER_LIST</requireAttribute>
<requireAttribute>CLIENT_LIST</requireAttribute>
<requireAttribute>PARTS_LIST</requireAttribute>
</include>
<include cluster="Binding" client="true" server="false" clientLocked="false" serverLocked="true">
<requireAttribute>BINDING</requireAttribute>
</include>
bzbarsky-apple marked this conversation as resolved.
Show resolved Hide resolved
<include cluster="Media Playback" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Content Launcher" client="true" server="false" clientLocked="true" serverLocked="false"></include>
<include cluster="Keypad Input" client="true" server="false" clientLocked="true" serverLocked="false"></include>
<include cluster="Account Login" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="On/Off" client="true" server="false" clientLocked="true" serverLocked="false"></include>
<include cluster="Level Control" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Wake on LAN" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Channel" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Target Navigator" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Media Input" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Low Power" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Audio Output" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Application Launcher" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Application Basic" client="true" server="false" clientLocked="true" serverLocked="false"></include>
</clusters>
</deviceType>
<deviceType>
<name>MA-video-remotecontrol</name>
<domain>CHIP</domain>
<typeName>Matter Video Remote Control</typeName>
lazarkov marked this conversation as resolved.
Show resolved Hide resolved
<profileId editable="false">0x0103</profileId>
<deviceId editable="false">0x002A</deviceId>
<clusters lockOthers="true">
<include cluster="Descriptor" client="true" server="false" clientLocked="true" serverLocked="true">
<requireAttribute>DEVICE_TYPE_LIST</requireAttribute>
<requireAttribute>SERVER_LIST</requireAttribute>
<requireAttribute>CLIENT_LIST</requireAttribute>
<requireAttribute>PARTS_LIST</requireAttribute>
</include>
<include cluster="Binding" client="true" server="false" clientLocked="false" serverLocked="true">
<requireAttribute>BINDING</requireAttribute>
</include>
bzbarsky-apple marked this conversation as resolved.
Show resolved Hide resolved
<include cluster="Media Playback" client="true" server="false" clientLocked="true" serverLocked="false"></include>
<include cluster="Content Launcher" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Keypad Input" client="true" server="false" clientLocked="true" serverLocked="false"></include>
<include cluster="Account Login" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="On/Off" client="true" server="false" clientLocked="true" serverLocked="false"></include>
<include cluster="Level Control" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Wake on LAN" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Channel" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Target Navigator" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Media Input" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Low Power" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Audio Output" client="true" server="false" clientLocked="false" serverLocked="false"></include>
<include cluster="Application Launcher" client="true" server="false" clientLocked="false" serverLocked="false"></include>
</clusters>
</deviceType>
<deviceType>
Expand Down