-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update device types per reported issues #21045
Merged
woody-apple
merged 10 commits into
project-chip:master
from
lazarkov:feature/update-tv-device-types
Aug 3, 2022
Merged
Update device types per reported issues #21045
woody-apple
merged 10 commits into
project-chip:master
from
lazarkov:feature/update-tv-device-types
Aug 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
LuDuda
July 21, 2022 09:30
bzbarsky-apple
requested changes
Jul 29, 2022
lazarkov
force-pushed
the
feature/update-tv-device-types
branch
from
July 30, 2022 06:02
02e55b7
to
55e6dab
Compare
PR #21045: Size comparison from 78dd131 to 55e6dab Increases (3 builds for cc13x2_26x2, esp32, telink)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
lazarkov
force-pushed
the
feature/update-tv-device-types
branch
from
August 1, 2022 05:44
55e6dab
to
17755a1
Compare
PR #21045: Size comparison from 17c8da6 to 17755a1 Increases (1 build for telink)
Decreases (1 build for esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
requested changes
Aug 2, 2022
lazarkov
commented
Aug 2, 2022
bzbarsky-apple
approved these changes
Aug 3, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
* Update device types per reported issues * update device types
woody-apple
added a commit
that referenced
this pull request
Aug 3, 2022
* Update device types per reported issues * update device types Co-authored-by: Lazar Kovacic <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Update device types per reported issues * update device types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
see above
Issue(s) fixed:
19341
20978
Testing
Run
./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "