Fix invalid null delegate usage attempts in media clusters #20853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
LuDuda and
mlepage-google
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #20853: Size comparison from aa9457e to e791a35 Increases (5 builds for cc13x2_26x2, k32w, nrfconnect, p6, telink)
Decreases (1 build for telink)
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #20853: Size comparison from aa9457e to 817b335 Increases (4 builds for cc13x2_26x2, k32w, nrfconnect, p6)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
chrisdecenzo
approved these changes
Jul 18, 2022
andy31415
reviewed
Jul 18, 2022
It came as an additonal request from @chrisdecenzo. I believe it's per spec to have feature map of network commissioning set to 4. @chrisdecenzo can confirm. I understand the logic to move this change to new PR, in case we want to roll the change back. But per my understanding, this should be the default value. |
andy31415
approved these changes
Jul 18, 2022
|
PR #20853: Size comparison from aa9457e to e2499cb Increases (15 builds for cc13x2_26x2, cyw30739, k32w, linux, telink)
Decreases (12 builds for bl602, cc13x2_26x2, efr32, esp32, nrfconnect, p6, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
* Update cluster logic * Update tv.zap * Restyle fix applied * Fix audio output feature map * Update newtwork commissioning feature flag to 4 * Update failure logic
woody-apple
added a commit
that referenced
this pull request
Jul 19, 2022
…20901) * Update cluster logic * Update tv.zap * Restyle fix applied * Fix audio output feature map * Update newtwork commissioning feature flag to 4 * Update failure logic Co-authored-by: Lazar Kovacic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@andreilitvin pointed out that in media cluster code quote: "Delegate null check was not valid: even if null check failed, delegate use was still attempted."
Change overview
see above
Issue(s) fixed:
20683
Testing
Run
./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "