Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up null delegate use in goto exit pattern in TV clusters #20683

Closed
andy31415 opened this issue Jul 13, 2022 · 0 comments
Closed

Fix up null delegate use in goto exit pattern in TV clusters #20683

andy31415 opened this issue Jul 13, 2022 · 0 comments
Assignees
Labels
crash tv TV-related features V1.0

Comments

@andy31415
Copy link
Contributor

Problem

#20682 fixes some potential segfaults in the media input server. Looking at the original #13259 it looks like the same pattern exists in other files (notably I see audio-output-server.cpp being also broken).

Proposed Solution

After a verify that it is not null check, the null delegate should not be dereferenced. the code after exit should only do cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash tv TV-related features V1.0
Projects
None yet
Development

No branches or pull requests

3 participants