Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delegate API methods to media clusters #13259

Merged
merged 7 commits into from
Jan 4, 2022
Merged

Add delegate API methods to media clusters #13259

merged 7 commits into from
Jan 4, 2022

Conversation

lazarkov
Copy link
Contributor

Problem

Media clusters do not have delegate methods, which leads to duplicated logic for both tv android and linux apps.

  • Updated every media cluster and added delegate
  • Updated tv linux app
  • Updated tv android app
  • Updated the media cluster tests

Change overview

see above

Testing

Run ./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "

@restyled-io restyled-io bot mentioned this pull request Dec 28, 2021
Closed
@github-actions
Copy link

PR #13259: Size comparison from eab67b3 to 8a34c90

Full report (1 build for telink)
platform target config section eab67b3 8a34c90 change % change
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@lazarkov lazarkov force-pushed the feature/add-delegates-to-media-clusters branch from 8a34c90 to c96e5b8 Compare December 28, 2021 22:19
@restyled-io restyled-io bot mentioned this pull request Dec 28, 2021
Closed
@lazarkov lazarkov force-pushed the feature/add-delegates-to-media-clusters branch from 40b5604 to c2707ba Compare December 28, 2021 22:31
@lazarkov lazarkov self-assigned this Dec 28, 2021
@github-actions
Copy link

github-actions bot commented Dec 28, 2021 •
edited
Loading

PR #13259: Size comparison from eab67b3 to c2707ba

Increases (1 build for linux)
platform target config section eab67b3 c2707ba change % change
linux chip-tool-ipv6only arm64 (read only) 7010188 7010300 112 0.0
.rodata 383300 383316 16 0.0
.text 5934516 5934612 96 0.0
Full report (8 builds for k32w, linux, qpg, telink)
platform target config section eab67b3 c2707ba change % change
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 632264 0 0.0
.bss 75896 75896 0 0.0
.data 1860 1860 0 0.0
.text 548708 548708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7010188 7010300 112 0.0
(read/write) 324849 324849 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208960 208960 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383300 383316 16 0.0
.text 5934516 5934612 96 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 502876 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85792 85792 0 0.0
.data 952 952 0 0.0
.text 497556 497556 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@lazarkov lazarkov force-pushed the feature/add-delegates-to-media-clusters branch from c2707ba to 341f9a2 Compare December 28, 2021 23:01
@github-actions
Copy link

github-actions bot commented Dec 28, 2021 •
edited
Loading

PR #13259: Size comparison from eab67b3 to 341f9a2

Increases above 0.2%:

platform target config section eab67b3 341f9a2 change % change
p6 all-clusters-app default (read/write) 2391112 2399776 8664 0.4
.data 2552 2584 32 1.3
.text 1349376 1358040 8664 0.6
Increases (2 builds for linux, p6)
platform target config section eab67b3 341f9a2 change % change
linux chip-tool-ipv6only arm64 (read only) 7010188 7010300 112 0.0
.rodata 383300 383316 16 0.0
.text 5934516 5934612 96 0.0
p6 all-clusters-app default (read/write) 2391112 2399776 8664 0.4
.bss 116564 116732 168 0.1
.data 2552 2584 32 1.3
.text 1349376 1358040 8664 0.6
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section eab67b3 341f9a2 change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 632264 0 0.0
.bss 75896 75896 0 0.0
.data 1860 1860 0 0.0
.text 548708 548708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7010188 7010300 112 0.0
(read/write) 324849 324849 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208960 208960 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383300 383316 16 0.0
.text 5934516 5934612 96 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
p6 all-clusters-app default (read/write) 2391112 2399776 8664 0.4
.bss 116564 116732 168 0.1
.data 2552 2584 32 1.3
.text 1349376 1358040 8664 0.6
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2295880 0 0.0
.bss 104736 104736 0 0.0
.data 2336 2336 0 0.0
.text 1254144 1254144 0 0.0
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 502876 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85792 85792 0 0.0
.data 952 952 0 0.0
.text 497556 497556 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@lazarkov lazarkov force-pushed the feature/add-delegates-to-media-clusters branch from 341f9a2 to 01c7067 Compare December 29, 2021 00:12
@github-actions
Copy link

github-actions bot commented Dec 29, 2021 •
edited
Loading

PR #13259: Size comparison from eab67b3 to 01c7067

Increases above 0.2%:

platform target config section eab67b3 01c7067 change % change
esp32 all-clusters-app c3devkit (read only) 882900 888138 5238 0.6
.dram0.bss 69104 69264 160 0.2
.flash.rodata 176104 177112 1008 0.6
.flash.text 882900 888138 5238 0.6
m5stack (read only) 943439 948227 4788 0.5
(read/write) 441600 445252 3652 0.8
.dram0.bss 73600 73760 160 0.2
.flash.rodata 202936 206428 3492 1.7
.flash.text 938055 942843 4788 0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2338944 2345456 6512 0.3
.data 5272 5304 32 0.6
.text 1301520 1308032 6512 0.5
p6 all-clusters-app default (read/write) 2391112 2399776 8664 0.4
.data 2552 2584 32 1.3
.text 1349376 1358040 8664 0.6
Increases (5 builds for esp32, linux, mbed, p6)
platform target config section eab67b3 01c7067 change % change
esp32 all-clusters-app c3devkit (read only) 882900 888138 5238 0.6
(read/write) 1312498 1313666 1168 0.1
.dram0.bss 69104 69264 160 0.2
.flash.rodata 176104 177112 1008 0.6
.flash.text 882900 888138 5238 0.6
m5stack (read only) 943439 948227 4788 0.5
(read/write) 441600 445252 3652 0.8
.dram0.bss 73600 73760 160 0.2
.flash.rodata 202936 206428 3492 1.7
.flash.text 938055 942843 4788 0.5
linux chip-tool-ipv6only arm64 (read only) 7010188 7010300 112 0.0
.rodata 383300 383316 16 0.0
.text 5934516 5934612 96 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2338944 2345456 6512 0.3
.bss 188364 188524 160 0.1
.data 5272 5304 32 0.6
.text 1301520 1308032 6512 0.5
p6 all-clusters-app default (read/write) 2391112 2399776 8664 0.4
.bss 116564 116732 168 0.1
.data 2552 2584 32 1.3
.text 1349376 1358040 8664 0.6
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eab67b3 01c7067 change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
esp32 all-clusters-app c3devkit (read only) 882900 888138 5238 0.6
(read/write) 1312498 1313666 1168 0.1
.dram0.bss 69104 69264 160 0.2
.dram0.data 14228 14228 0 0.0
.flash.rodata 176104 177112 1008 0.6
.flash.text 882900 888138 5238 0.6
.iram0.text 62254 62254 0 0.0
m5stack (read only) 943439 948227 4788 0.5
(read/write) 441600 445252 3652 0.8
.dram0.bss 73600 73760 160 0.2
.dram0.data 34056 34056 0 0.0
.flash.rodata 202936 206428 3492 1.7
.flash.text 938055 942843 4788 0.5
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 632264 0 0.0
.bss 75896 75896 0 0.0
.data 1860 1860 0 0.0
.text 548708 548708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7010188 7010300 112 0.0
(read/write) 324849 324849 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208960 208960 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383300 383316 16 0.0
.text 5934516 5934612 96 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338944 2345456 6512 0.3
.bss 188364 188524 160 0.1
.data 5272 5304 32 0.6
.text 1301520 1308032 6512 0.5
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329040 2329040 0 0.0
.bss 180608 180608 0 0.0
.data 5552 5552 0 0.0
.text 1291640 1291640 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302200 2302200 0 0.0
.bss 179656 179656 0 0.0
.data 5544 5544 0 0.0
.text 1264800 1264800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053888 2053888 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016488 1016488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935247 935247 0 0.0
bss 118172 118172 0 0.0
rodata 107996 107996 0 0.0
text 631528 631528 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921651 921651 0 0.0
bss 115216 115216 0 0.0
rodata 101416 101416 0 0.0
text 626840 626840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859014 859014 0 0.0
bss 116456 116456 0 0.0
rodata 102924 102924 0 0.0
text 558964 558964 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907507 907507 0 0.0
bss 117360 117360 0 0.0
rodata 103304 103304 0 0.0
text 609460 609460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831422 831422 0 0.0
bss 115672 115672 0 0.0
rodata 98268 98268 0 0.0
text 536940 536940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 908739 908739 0 0.0
bss 117120 117120 0 0.0
rodata 103520 103520 0 0.0
text 610676 610676 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905587 905587 0 0.0
bss 117148 117148 0 0.0
rodata 102776 102776 0 0.0
text 608208 608208 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796871 796871 0 0.0
bss 109536 109536 0 0.0
rodata 78200 78200 0 0.0
text 532680 532680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709502 709502 0 0.0
bss 107424 107424 0 0.0
rodata 72500 72500 0 0.0
text 450172 450172 0 0.0
p6 all-clusters-app default (read/write) 2391112 2399776 8664 0.4
.bss 116564 116732 168 0.1
.data 2552 2584 32 1.3
.text 1349376 1358040 8664 0.6
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2295880 0 0.0
.bss 104736 104736 0 0.0
.data 2336 2336 0 0.0
.text 1254144 1254144 0 0.0
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 502876 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85792 85792 0 0.0
.data 952 952 0 0.0
.text 497556 497556 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@chrisdecenzo chrisdecenzo merged commit b0af6ba into project-chip:master Jan 4, 2022
@lazarkov lazarkov deleted the feature/add-delegates-to-media-clusters branch January 4, 2022 09:16
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jan 7, 2022
Closed
@andy31415 andy31415 mentioned this pull request Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@hawk248 hawk248 hawk248 approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@lazarkov lazarkov

Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazarkov @hawk248 @chrisdecenzo