-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix management of mRunScheduled state in reporting engine. #20694
Merged
isiu-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-run-management
Jul 15, 2022
Merged
Fix management of mRunScheduled state in reporting engine. #20694
isiu-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-run-management
Jul 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, we can schedule a reporting run, then do a sync Run (due to urgent events), then (unnecessarily) schedule another reporting run.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
rgoliver
July 13, 2022 19:30
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
July 13, 2022 19:30
PR #20694: Size comparison from aa2f050 to 97c5a96 Increases (7 builds for cc13x2_26x2, efr32, esp32, nrfconnect)
Decreases (6 builds for bl602, cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Jul 14, 2022
mrjerryjohns
approved these changes
Jul 15, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 15, 2022
Without this change, we can schedule a reporting run, then do a sync Run (due to urgent events), then (unnecessarily) schedule another reporting run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, we can schedule a reporting run, then do a sync
Run (due to urgent events), then (unnecessarily) schedule another
reporting run.
Problem
See above.
Change overview
Make sure to unset our "run scheduled" boolean only when we actually call the async callback.
Testing
Verified that this fixes the test from #20692 on the SHA where that test crashes.