-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test to remove fabric while fabrics attr is subscribed. #20692
Merged
jmartinez-silabs
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-removal-while-subscribed-test
Jul 14, 2022
Merged
Add a test to remove fabric while fabrics attr is subscribed. #20692
jmartinez-silabs
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-removal-while-subscribed-test
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7318cbb
to
945020d
Compare
PR #20692: Size comparison from aa2f050 to 945020d Increases (3 builds for cc13x2_26x2, linux)
Decreases (1 build for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Jul 14, 2022
tehampson
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No test that exercised the scenario encountered in #20678
Change overview
Add such a test.
Testing
Verified this test fails on the SHA #20678 was reported on, though it passes on tip because we changed exactly how we mark things dirty on fabric removal.