Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attributePath parameter to Door Lock Server's unhandledAttributeC… #20338

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Add attributePath parameter to Door Lock Server's unhandledAttributeC… #20338

merged 2 commits into from
Jul 6, 2022

Conversation

jrhees-cae
Copy link
Contributor

Addd attributePath parameter to Door Lock Server's emberAfPluginDoorLockOnUnhandledAttributeChanged API

Problem

API function needs attributePath parameter to allow application to determine which attribute is being changed.

Change overview

Add attributePath parameter API call

Testing

No existing code is affected (e.g., API is not currently used by any examples).

Fixes #18681

@boring-cyborg boring-cyborg bot added the app label Jul 6, 2022
@restyled-io restyled-io bot mentioned this pull request Jul 6, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 6, 2022 •
edited
Loading

PR #20338: Size comparison from 5398442 to de2e5de

Increases (13 builds for cc13x2_26x2, cyw30739, efr32, esp32, nrfconnect, p6, telink)
platform target config section 5398442 de2e5de change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665379 665395 16 0.0
.text 576996 577012 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631395 631411 16 0.0
.text 553764 553780 16 0.0
shell LP_CC2652R7 (read only) 657878 657894 16 0.0
.text 572716 572732 16 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 580550 580558 8 0.0
.app_xip_area 459120 459128 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1127016 1127032 16 0.0
.text 980748 980764 16 0.0
esp32 all-clusters-app c3devkit (read only) 1019282 1019290 8 0.0
.flash.text 1019282 1019290 8 0.0
m5stack (read only) 1073171 1073175 4 0.0
.flash.text 1067787 1067791 4 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 810212 810220 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 799908 799916 8 0.0
p6 all-clusters-app default (read/write) 2563008 2563024 16 0.0
.text 1521272 1521288 16 0.0
all-clusters-minimal-app default (read/write) 2508872 2508888 16 0.0
.text 1467136 1467152 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796628 796636 8 0.0
text 565128 565132 4 0.0
lighting-app tlsr9518adk80d text 581452 581454 2 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 5398442 de2e5de change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185844 185828 -16 -0.0
shell LP_CC2652R7 (read/write) 188848 188832 -16 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5398442 de2e5de change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665379 665395 16 0.0
(read/write) 185844 185828 -16 -0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 576996 577012 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631395 631411 16 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553764 553780 16 0.0
lock-ftd LP_CC2652R7 (read only) 668095 668095 0 0.0
(read/write) 173272 173272 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591424 591424 0 0.0
lock-mtd LP_CC2652R7 (read only) 617511 617511 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540952 540952 0 0.0
pump-app LP_CC2652R7 (read only) 677407 677407 0 0.0
(read/write) 164808 164808 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88415 88415 0 0.0
.text 588508 588508 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 179056 179056 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84279 84279 0 0.0
.text 578520 578520 0 0.0
shell LP_CC2652R7 (read only) 657878 657894 16 0.0
(read/write) 188848 188832 -16 -0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572716 572732 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578886 578886 0 0.0
.app_xip_area 457656 457656 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580550 580558 8 0.0
.app_xip_area 459120 459128 8 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581950 581950 0 0.0
.app_xip_area 461568 461568 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080332 1080332 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945268 945268 0 0.0
BRD4161A+rpc (read/write) 1134676 1134676 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982720 982720 0 0.0
BRD4161A+rs911x (read/write) 946436 946436 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803600 803600 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127016 1127032 16 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 980748 980764 16 0.0
window-app BRD4161A (read/write) 1074132 1074132 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937564 937564 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019282 1019290 8 0.0
(read/write) 1485050 1485050 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214936 214936 0 0.0
.flash.text 1019282 1019290 8 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073171 1073175 4 0.0
(read/write) 487136 487136 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245396 245396 0 0.0
.flash.text 1067787 1067791 4 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658192 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580884 0 0.0
lock k32w061+release (read/write) 684772 684772 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606988 606988 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9940468 9940468 0 0.0
(read/write) 675905 675905 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614888 614888 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473668 473668 0 0.0
.text 7926484 7926484 0 0.0
thermostat-no-ble arm64 (read only) 2592644 2592644 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2187520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447376 2447376 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410020 1410020 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173375 1173375 0 0.0
bss 142900 142900 0 0.0
rodata 141360 141360 0 0.0
text 810212 810220 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154227 1154227 0 0.0
bss 142136 142136 0 0.0
rodata 133292 133292 0 0.0
text 799908 799916 8 0.0
p6 all-clusters-app default (read/write) 2563008 2563024 16 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521272 1521288 16 0.0
all-clusters-minimal-app default (read/write) 2508872 2508888 16 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467136 1467152 16 0.0
light-app default (read/write) 2439240 2439240 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397504 0 0.0
lock-app default (read/write) 2465672 2465672 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423936 1423936 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796628 796636 8 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565128 565132 4 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816464 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581452 581454 2 0.0

@woody-apple woody-apple added the sve label Jul 6, 2022
@woody-apple woody-apple enabled auto-merge (squash) July 6, 2022 02:46
@github-actions
Copy link

github-actions bot commented Jul 6, 2022 •
edited
Loading

PR #20338: Size comparison from 5398442 to 0be30c2

Increases (12 builds for cc13x2_26x2, cyw30739, efr32, esp32, nrfconnect, p6, telink)
platform target config section 5398442 0be30c2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665379 665395 16 0.0
.text 576996 577012 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631395 631411 16 0.0
.text 553764 553780 16 0.0
shell LP_CC2652R7 (read only) 657878 657894 16 0.0
.text 572716 572732 16 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 580550 580558 8 0.0
.app_xip_area 459120 459128 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1127016 1127032 16 0.0
.text 980748 980764 16 0.0
esp32 all-clusters-app c3devkit (read only) 1019282 1019290 8 0.0
.flash.text 1019282 1019290 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 810212 810220 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 799908 799916 8 0.0
p6 all-clusters-app default (read/write) 2563008 2563024 16 0.0
.text 1521272 1521288 16 0.0
all-clusters-minimal-app default (read/write) 2508872 2508888 16 0.0
.text 1467136 1467152 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796628 796636 8 0.0
text 565128 565130 2 0.0
lighting-app tlsr9518adk80d text 581452 581454 2 0.0
Decreases (4 builds for cc13x2_26x2, k32w)
platform target config section 5398442 0be30c2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185844 185828 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 617511 617503 -8 -0.0
.text 540952 540944 -8 -0.0
shell LP_CC2652R7 (read/write) 188848 188832 -16 -0.0
k32w light k32w061+release (read/write) 658192 658176 -16 -0.0
.text 580884 580868 -16 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5398442 0be30c2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665379 665395 16 0.0
(read/write) 185844 185828 -16 -0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 576996 577012 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631395 631411 16 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553764 553780 16 0.0
lock-ftd LP_CC2652R7 (read only) 668095 668095 0 0.0
(read/write) 173272 173272 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591424 591424 0 0.0
lock-mtd LP_CC2652R7 (read only) 617511 617503 -8 -0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540952 540944 -8 -0.0
pump-app LP_CC2652R7 (read only) 677407 677407 0 0.0
(read/write) 164808 164808 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88415 88415 0 0.0
.text 588508 588508 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 179056 179056 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84279 84279 0 0.0
.text 578520 578520 0 0.0
shell LP_CC2652R7 (read only) 657878 657894 16 0.0
(read/write) 188848 188832 -16 -0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572716 572732 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578886 578886 0 0.0
.app_xip_area 457656 457656 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580550 580558 8 0.0
.app_xip_area 459120 459128 8 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581950 581950 0 0.0
.app_xip_area 461568 461568 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080332 1080332 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945268 945268 0 0.0
BRD4161A+rpc (read/write) 1134676 1134676 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982720 982720 0 0.0
BRD4161A+rs911x (read/write) 946436 946436 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803600 803600 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127016 1127032 16 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 980748 980764 16 0.0
window-app BRD4161A (read/write) 1074132 1074132 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937564 937564 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019282 1019290 8 0.0
(read/write) 1485050 1485050 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214936 214936 0 0.0
.flash.text 1019282 1019290 8 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073171 1073171 0 0.0
(read/write) 487136 487136 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245396 245396 0 0.0
.flash.text 1067787 1067787 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658176 -16 -0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580868 -16 -0.0
lock k32w061+release (read/write) 684772 684772 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606988 606988 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9940468 9940468 0 0.0
(read/write) 675905 675905 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614888 614888 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473668 473668 0 0.0
.text 7926484 7926484 0 0.0
thermostat-no-ble arm64 (read only) 2592644 2592644 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2187520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447376 2447376 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410020 1410020 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173375 1173375 0 0.0
bss 142900 142900 0 0.0
rodata 141360 141360 0 0.0
text 810212 810220 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154227 1154227 0 0.0
bss 142136 142136 0 0.0
rodata 133292 133292 0 0.0
text 799908 799916 8 0.0
p6 all-clusters-app default (read/write) 2563008 2563024 16 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521272 1521288 16 0.0
all-clusters-minimal-app default (read/write) 2508872 2508888 16 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467136 1467152 16 0.0
light-app default (read/write) 2439240 2439240 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397504 0 0.0
lock-app default (read/write) 2465672 2465672 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423936 1423936 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796628 796636 8 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565128 565130 2 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816464 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581452 581454 2 0.0

@woody-apple woody-apple merged commit 796f370 into project-chip:master Jul 6, 2022
bzbarsky-apple
bzbarsky-apple reviewed Jul 13, 2022
View reviewed changes
src/app/clusters/door-lock-server/door-lock-server.cpp
@@ -3576,7 +3576,7 @@ MatterDoorLockClusterServerPreAttributeChangedCallback(const chip::app::Concrete
break;

default:
res = emberAfPluginDoorLockOnUnhandledAttributeChange(attributePath.mEndpointId, attributeType, size, value);
res = emberAfPluginDoorLockOnUnhandledAttributeChange(attributePath.mEndpointId, attributePath, attributeType, size, value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrhees-cae @tcarmelveilleux @woody-apple Why are we still passing the endpoint id separately, as well as in the path?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app review - approved sve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Door-Lock-Server] Calls to emberAfPluginDoorLockOnUnhandledAttributeChange need added attributePath parameter
5 participants
@jrhees-cae @tcarmelveilleux @woody-apple @bzbarsky-apple @restyled-commits