Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Door-Lock-Server] Calls to emberAfPluginDoorLockOnUnhandledAttributeChange need added attributePath parameter #18681

Closed
jrhees-cae opened this issue May 20, 2022 · 6 comments · Fixed by #20338
Assignees
Labels
app-clusters Application cluster work sve V1.0

Comments

@jrhees-cae
Copy link
Contributor

Problem

The emberAfPluginDoorLockOnUnhandledAttributeChange function needs the attributePath parameter added to the parameter list.

Proposed Solution

change function declaration from:
emberAfPluginDoorLockOnUnhandledAttributeChange(chip::EndpointId EndpointId, EmberAfAttributeType attrType, uint16_t attrSize, uint8_t * attrValue)
to:
emberAfPluginDoorLockOnUnhandledAttributeChange(chip::EndpointId EndpointId, const chip::app::ConcreteAttributePath & attributePath, EmberAfAttributeType attrType, uint16_t attrSize, uint8_t * attrValue)

@mrjerryjohns
Copy link
Contributor

@Morozov-5F would you be able to help take this on?

@bzbarsky-apple
Copy link
Contributor

@jrhees-cae what are the observable consequences of this function having the wrong signature?

@jrhees-cae
Copy link
Contributor Author

jrhees-cae commented May 25, 2022 via email

@bzbarsky-apple bzbarsky-apple added V1.0 app-clusters Application cluster work labels May 25, 2022
@bzbarsky-apple
Copy link
Contributor

Sounds like lock apps will need this....

@woody-apple
Copy link
Contributor

SDK Review: Seems like this could help Lock's for SVE, not required, but given where we are right now, we can take this.

@woody-apple
Copy link
Contributor

SDK Review: @Morozov-5F are you able to take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-clusters Application cluster work sve V1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants