-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Door-Lock-Server] Calls to emberAfPluginDoorLockOnUnhandledAttributeChange need added attributePath parameter #18681
Labels
Comments
@Morozov-5F would you be able to help take this on? |
@jrhees-cae what are the observable consequences of this function having the wrong signature? |
Without the attribute path being included as a parameter, the function is
completely useless to an app which wishes to override the weak link. The
app gets the call, but had no way of knowing which attribute was being
changed.
Jon
…On Tue, May 24, 2022, 9:26 PM Boris Zbarsky ***@***.***> wrote:
@jrhees-cae <https://github.com/jrhees-cae> what are the observable
consequences of this function having the wrong signature?
—
Reply to this email directly, view it on GitHub
<#18681 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOU6QVUHPBQY3ZE5WGABMN3VLWMV3ANCNFSM5WQAJFDQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sounds like lock apps will need this.... |
SDK Review: Seems like this could help Lock's for SVE, not required, but given where we are right now, we can take this. |
SDK Review: @Morozov-5F are you able to take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
The
emberAfPluginDoorLockOnUnhandledAttributeChange
function needs the attributePath parameter added to the parameter list.Proposed Solution
change function declaration from:
emberAfPluginDoorLockOnUnhandledAttributeChange(chip::EndpointId EndpointId, EmberAfAttributeType attrType, uint16_t attrSize, uint8_t * attrValue)
to:
emberAfPluginDoorLockOnUnhandledAttributeChange(chip::EndpointId EndpointId, const chip::app::ConcreteAttributePath & attributePath, EmberAfAttributeType attrType, uint16_t attrSize, uint8_t * attrValue)
The text was updated successfully, but these errors were encountered: