Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool] Add read-all command to read all events and attributes from a given endpoint (could be wildcard) onto a single transaction #20270

Merged
merged 2 commits into from
Jul 5, 2022
Merged

[chip-tool] Add read-all command to read all events and attributes from a given endpoint (could be wildcard) onto a single transaction #20270

merged 2 commits into from
Jul 5, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

There is no chip-tool command to read both attributes and events at the same time.

Fix #20111

Change overview

  • Add read-all command
  • Update generated code

Testing

chip-tool any read-all 0x12344321 0xFFFF

@vivien-apple vivien-apple self-assigned this Jul 4, 2022
@pullapprove pullapprove bot requested review from selissia and tcarmelveilleux July 4, 2022 13:26
@vivien-apple vivien-apple changed the title Chip tool add read all @vivien-apple [chip-tool] Add read-all command to read all events and attributes from a given endpoint (could be wildcard) onto a single transaction Jul 4, 2022
@vivien-apple vivien-apple changed the title @vivien-apple [chip-tool] Add read-all command to read all events and attributes from a given endpoint (could be wildcard) onto a single transaction [chip-tool] Add read-all command to read all events and attributes from a given endpoint (could be wildcard) onto a single transaction Jul 4, 2022
@github-actions
Copy link

github-actions bot commented Jul 4, 2022 •
edited
Loading

PR #20270: Size comparison from 08cb351 to 1653c11

Increases above 0.2%:

platform target config section 08cb351 1653c11 change % change
linux tv-casting-app debug .data.rel.ro 102824 103048 224 0.2
Increases (6 builds for cc13x2_26x2, cyw30739, linux, telink)
platform target config section 08cb351 1653c11 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 631331 631339 8 0.0
.text 553668 553676 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578798 578806 8 0.0
.app_xip_area 457576 457584 8 0.0
linux chip-tool debug (read only) 10196725 10199197 2472 0.0
(read/write) 611816 612040 224 0.0
.data.rel.ro 580032 580272 240 0.0
.rodata 507493 507525 32 0.0
.text 8278197 8279989 1792 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9923396 9925604 2208 0.0
(read/write) 676609 676865 256 0.0
.data.rel.ro 615592 615840 248 0.0
.got 13448 13456 8 0.1
.text 7911236 7912772 1536 0.0
tv-casting-app debug (read only) 5560057 5562497 2440 0.0
(read/write) 161712 161936 224 0.1
.data.rel.ro 102824 103048 224 0.2
.text 4939698 4941490 1792 0.0
telink light-switch-app tlsr9518adk80d text 564980 564984 4 0.0
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 08cb351 1653c11 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665339 665339 0 0.0
(read/write) 185884 185884 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88099 88099 0 0.0
.text 576924 576924 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631331 631339 8 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77339 77339 0 0.0
.text 553668 553676 8 0.0
lock-ftd LP_CC2652R7 (read only) 667999 667999 0 0.0
(read/write) 173368 173368 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591328 591328 0 0.0
lock-mtd LP_CC2652R7 (read only) 617423 617423 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540864 540864 0 0.0
pump-app LP_CC2652R7 (read only) 677359 677359 0 0.0
(read/write) 164856 164856 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88439 88439 0 0.0
.text 588436 588436 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663183 663183 0 0.0
(read/write) 179152 179152 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84279 84279 0 0.0
.text 578424 578424 0 0.0
shell LP_CC2652R7 (read only) 657790 657790 0 0.0
(read/write) 188936 188936 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572628 572628 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578798 578806 8 0.0
.app_xip_area 457576 457584 8 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580454 580454 0 0.0
.app_xip_area 459040 459040 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581878 581878 0 0.0
.app_xip_area 461504 461504 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080252 1080252 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945188 945188 0 0.0
BRD4161A+rpc (read/write) 1134596 1134596 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982640 982640 0 0.0
BRD4161A+rs911x (read/write) 946340 946340 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803504 803504 0 0.0
lock-app BRD4161A+wf200 (read/write) 1126984 1126984 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 980716 980716 0 0.0
window-app BRD4161A (read/write) 1065500 1065500 0 0.0
.bss 133076 133076 0 0.0
.data 2076 2076 0 0.0
.text 930324 930324 0 0.0
k32w light k32w061+release (read/write) 658096 658096 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580788 580788 0 0.0
lock k32w061+release (read/write) 684676 684676 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606892 606892 0 0.0
linux all-clusters-app debug (read only) 2955281 2955281 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263229 263229 0 0.0
.text 2514866 2514866 0 0.0
all-clusters-minimal-app debug (read only) 2809409 2809409 0 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264925 264925 0 0.0
.text 2369474 2369474 0 0.0
bridge-app debug+rpc (read only) 2312329 2312329 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1952642 1952642 0 0.0
chip-tool debug (read only) 10196725 10199197 2472 0.0
(read/write) 611816 612040 224 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 580032 580272 240 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 507493 507525 32 0.0
.text 8278197 8279989 1792 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9923396 9925604 2208 0.0
(read/write) 676609 676865 256 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615592 615840 248 0.0
.dynamic 528 528 0 0.0
.got 13448 13456 8 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470260 470260 0 0.0
.text 7911236 7912772 1536 0.0
lighting-app debug+rpc (read only) 2548105 2548105 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2164498 2164498 0 0.0
lock-app debug (read only) 2510497 2510497 0 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228328 228328 0 0.0
.text 2117026 2117026 0 0.0
ota-provider-app debug (read only) 2319153 2319153 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1952962 1952962 0 0.0
ota-requestor-app debug (read only) 2436353 2436353 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207424 207424 0 0.0
.text 2057778 2057778 0 0.0
shell debug (read only) 2544897 2544897 0 0.0
(read/write) 141064 141064 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227346 227346 0 0.0
.text 2161186 2161186 0 0.0
thermostat-no-ble arm64 (read only) 2591892 2591892 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2186768 2186768 0 0.0
tv-app debug (read only) 3099249 3099249 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249216 249216 0 0.0
.text 2662130 2662130 0 0.0
tv-casting-app debug (read only) 5560057 5562497 2440 0.0
(read/write) 161712 161936 224 0.1
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102824 103048 224 0.2
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343433 343433 0 0.0
.text 4939698 4941490 1792 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447312 2447312 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409956 1409956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173243 1173243 0 0.0
bss 142900 142900 0 0.0
rodata 141356 141356 0 0.0
text 810088 810088 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154095 1154095 0 0.0
bss 142136 142136 0 0.0
rodata 133288 133288 0 0.0
text 799780 799780 0 0.0
p6 all-clusters-app default (read/write) 2562896 2562896 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521160 1521160 0 0.0
all-clusters-minimal-app default (read/write) 2508760 2508760 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467024 1467024 0 0.0
light-app default (read/write) 2439128 2439128 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397392 1397392 0 0.0
lock-app default (read/write) 2465560 2465560 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423824 1423824 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796480 796480 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 564980 564984 4 0.0
lighting-app tlsr9518adk80d (read/write) 816316 816316 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581306 581306 0 0.0

@vivien-apple vivien-apple force-pushed the ChipTool_AddReadAll branch from 1653c11 to 728bcc7 Compare July 4, 2022 14:52
@github-actions
Copy link

github-actions bot commented Jul 4, 2022 •
edited
Loading

PR #20270: Size comparison from a800dac to 728bcc7

Increases above 0.2%:

platform target config section a800dac 728bcc7 change % change
linux tv-casting-app debug .data.rel.ro 102824 103048 224 0.2
Increases (4 builds for cyw30739, linux)
platform target config section a800dac 728bcc7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578806 578814 8 0.0
.app_xip_area 457576 457584 8 0.0
linux chip-tool debug (read only) 10196725 10199197 2472 0.0
(read/write) 611816 612040 224 0.0
.data.rel.ro 580032 580272 240 0.0
.rodata 507493 507525 32 0.0
.text 8278197 8279989 1792 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9923428 9925636 2208 0.0
(read/write) 676609 676865 256 0.0
.data.rel.ro 615592 615840 248 0.0
.got 13448 13456 8 0.1
.text 7911268 7912804 1536 0.0
tv-casting-app debug (read only) 5560057 5562497 2440 0.0
(read/write) 161712 161936 224 0.1
.data.rel.ro 102824 103048 224 0.2
.text 4939698 4941490 1792 0.0
Decreases (3 builds for cc13x2_26x2, telink)
platform target config section a800dac 728bcc7 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 617439 617431 -8 -0.0
.text 540880 540872 -8 -0.0
telink light-switch-app tlsr9518adk80d text 564982 564980 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816316 816308 -8 -0.0
text 581308 581304 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a800dac 728bcc7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665355 665355 0 0.0
(read/write) 185868 185868 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88099 88099 0 0.0
.text 576940 576940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631355 631355 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77339 77339 0 0.0
.text 553692 553692 0 0.0
lock-ftd LP_CC2652R7 (read only) 668015 668015 0 0.0
(read/write) 173352 173352 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591344 591344 0 0.0
lock-mtd LP_CC2652R7 (read only) 617439 617431 -8 -0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540880 540872 -8 -0.0
pump-app LP_CC2652R7 (read only) 677375 677375 0 0.0
(read/write) 164840 164840 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88439 88439 0 0.0
.text 588452 588452 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663199 663199 0 0.0
(read/write) 179136 179136 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84279 84279 0 0.0
.text 578440 578440 0 0.0
shell LP_CC2652R7 (read only) 657806 657806 0 0.0
(read/write) 188920 188920 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572644 572644 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578806 578814 8 0.0
.app_xip_area 457576 457584 8 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580470 580470 0 0.0
.app_xip_area 459040 459040 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581886 581886 0 0.0
.app_xip_area 461504 461504 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080252 1080252 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945188 945188 0 0.0
BRD4161A+rpc (read/write) 1134596 1134596 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982640 982640 0 0.0
BRD4161A+rs911x (read/write) 946340 946340 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803504 803504 0 0.0
lock-app BRD4161A+wf200 (read/write) 1126984 1126984 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 980716 980716 0 0.0
window-app BRD4161A (read/write) 1074052 1074052 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937484 937484 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018712 1018712 0 0.0
(read/write) 1484906 1484906 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214792 214792 0 0.0
.flash.text 1018712 1018712 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072747 1072747 0 0.0
(read/write) 486984 486984 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067363 1067363 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658112 658112 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580804 580804 0 0.0
lock k32w061+release (read/write) 684692 684692 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606908 606908 0 0.0
linux all-clusters-app debug (read only) 2955281 2955281 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263229 263229 0 0.0
.text 2514866 2514866 0 0.0
all-clusters-minimal-app debug (read only) 2809409 2809409 0 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264925 264925 0 0.0
.text 2369474 2369474 0 0.0
bridge-app debug+rpc (read only) 2312329 2312329 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1952642 1952642 0 0.0
chip-tool debug (read only) 10196725 10199197 2472 0.0
(read/write) 611816 612040 224 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 580032 580272 240 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 507493 507525 32 0.0
.text 8278197 8279989 1792 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9923428 9925636 2208 0.0
(read/write) 676609 676865 256 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615592 615840 248 0.0
.dynamic 528 528 0 0.0
.got 13448 13456 8 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470260 470260 0 0.0
.text 7911268 7912804 1536 0.0
lighting-app debug+rpc (read only) 2548105 2548105 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2164498 2164498 0 0.0
lock-app debug (read only) 2510497 2510497 0 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228328 228328 0 0.0
.text 2117026 2117026 0 0.0
ota-provider-app debug (read only) 2319153 2319153 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1952962 1952962 0 0.0
ota-requestor-app debug (read only) 2436353 2436353 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207424 207424 0 0.0
.text 2057778 2057778 0 0.0
shell debug (read only) 2544897 2544897 0 0.0
(read/write) 141064 141064 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227346 227346 0 0.0
.text 2161186 2161186 0 0.0
thermostat-no-ble arm64 (read only) 2591924 2591924 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2186800 2186800 0 0.0
tv-app debug (read only) 3099249 3099249 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249216 249216 0 0.0
.text 2662130 2662130 0 0.0
tv-casting-app debug (read only) 5560057 5562497 2440 0.0
(read/write) 161712 161936 224 0.1
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102824 103048 224 0.2
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343433 343433 0 0.0
.text 4939698 4941490 1792 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447312 2447312 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409956 1409956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173243 1173243 0 0.0
bss 142900 142900 0 0.0
rodata 141356 141356 0 0.0
text 810088 810088 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154095 1154095 0 0.0
bss 142136 142136 0 0.0
rodata 133288 133288 0 0.0
text 799780 799780 0 0.0
p6 all-clusters-app default (read/write) 2562896 2562896 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521160 1521160 0 0.0
all-clusters-minimal-app default (read/write) 2508760 2508760 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467024 1467024 0 0.0
light-app default (read/write) 2439128 2439128 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397392 1397392 0 0.0
lock-app default (read/write) 2465560 2465560 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423824 1423824 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796480 796480 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 564982 564980 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816316 816308 -8 -0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581308 581304 -4 -0.0

@vivien-apple vivien-apple force-pushed the ChipTool_AddReadAll branch from 728bcc7 to 0adc6e7 Compare July 5, 2022 08:08
woody-apple
woody-apple approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking tooling updates

@vivien-apple
[chip-tool] Add read-all command to read all events and attributes fr…
9495084 
…om a given endpoint (could be wildcard) onto a single transaction
@vivien-apple
Update generated code
b818138
@vivien-apple vivien-apple force-pushed the ChipTool_AddReadAll branch from 0adc6e7 to b818138 Compare July 5, 2022 16:23
@github-actions
Copy link

github-actions bot commented Jul 5, 2022 •
edited
Loading

PR #20270: Size comparison from 770a2e2 to b818138

Increases above 0.2%:

platform target config section 770a2e2 b818138 change % change
linux tv-casting-app debug .data.rel.ro 102824 103048 224 0.2
Increases (4 builds for linux, telink)
platform target config section 770a2e2 b818138 change % change
linux chip-tool debug (read only) 10212421 10214957 2536 0.0
(read/write) 611816 612040 224 0.0
.data.rel.ro 580032 580272 240 0.0
.rodata 509605 509637 32 0.0
.text 8291781 8293637 1856 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9936308 9938628 2320 0.0
(read/write) 676609 676865 256 0.0
.data.rel.ro 615592 615840 248 0.0
.got 13448 13456 8 0.1
.rodata 472292 472308 16 0.0
.text 7922116 7923748 1632 0.0
tv-casting-app debug (read only) 5560809 5563313 2504 0.0
(read/write) 161744 161968 224 0.1
.data.rel.ro 102824 103048 224 0.2
.text 4940162 4942018 1856 0.0
telink light-switch-app tlsr9518adk80d text 565130 565132 2 0.0
Decreases (2 builds for esp32, nrfconnect)
platform target config section 770a2e2 b818138 change % change
esp32 all-clusters-app c3devkit (read only) 1019284 1019282 -2 -0.0
.flash.text 1019284 1019282 -2 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173375 1173359 -16 -0.0
text 810212 810208 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 770a2e2 b818138 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665379 665379 0 0.0
(read/write) 185844 185844 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 576996 576996 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631395 631395 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553764 553764 0 0.0
lock-ftd LP_CC2652R7 (read only) 668095 668095 0 0.0
(read/write) 173272 173272 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591424 591424 0 0.0
lock-mtd LP_CC2652R7 (read only) 617511 617511 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540952 540952 0 0.0
pump-app LP_CC2652R7 (read only) 677407 677407 0 0.0
(read/write) 164808 164808 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88415 88415 0 0.0
.text 588508 588508 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663279 663279 0 0.0
(read/write) 179056 179056 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84279 84279 0 0.0
.text 578520 578520 0 0.0
shell LP_CC2652R7 (read only) 657878 657878 0 0.0
(read/write) 188848 188848 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572716 572716 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578886 578886 0 0.0
.app_xip_area 457656 457656 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580550 580550 0 0.0
.app_xip_area 459120 459120 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581950 581950 0 0.0
.app_xip_area 461568 461568 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080332 1080332 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945268 945268 0 0.0
BRD4161A+rpc (read/write) 1134692 1134692 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982736 982736 0 0.0
BRD4161A+rs911x (read/write) 946436 946436 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803600 803600 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127016 1127016 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 980748 980748 0 0.0
window-app BRD4161A (read/write) 1074132 1074132 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937564 937564 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019284 1019282 -2 -0.0
(read/write) 1485050 1485050 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214936 214936 0 0.0
.flash.text 1019284 1019282 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073171 1073171 0 0.0
(read/write) 487136 487136 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245396 245396 0 0.0
.flash.text 1067787 1067787 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658192 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580884 0 0.0
lock k32w061+release (read/write) 684772 684772 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606988 606988 0 0.0
linux all-clusters-app debug (read only) 2955729 2955729 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263229 263229 0 0.0
.text 2515314 2515314 0 0.0
all-clusters-minimal-app debug (read only) 2809857 2809857 0 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264925 264925 0 0.0
.text 2369922 2369922 0 0.0
bridge-app debug+rpc (read only) 2312777 2312777 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1953090 1953090 0 0.0
chip-tool debug (read only) 10212421 10214957 2536 0.0
(read/write) 611816 612040 224 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 580032 580272 240 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509605 509637 32 0.0
.text 8291781 8293637 1856 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9936308 9938628 2320 0.0
(read/write) 676609 676865 256 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615592 615840 248 0.0
.dynamic 528 528 0 0.0
.got 13448 13456 8 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472292 472308 16 0.0
.text 7922116 7923748 1632 0.0
lighting-app debug+rpc (read only) 2548633 2548633 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213704 213704 0 0.0
.text 2164962 2164962 0 0.0
lock-app debug (read only) 2510945 2510945 0 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228328 228328 0 0.0
.text 2117474 2117474 0 0.0
ota-provider-app debug (read only) 2319601 2319601 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1953410 1953410 0 0.0
ota-requestor-app debug (read only) 2436801 2436801 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207424 207424 0 0.0
.text 2058226 2058226 0 0.0
shell debug (read only) 2546057 2546057 0 0.0
(read/write) 141096 141096 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227346 227346 0 0.0
.text 2161634 2161634 0 0.0
thermostat-no-ble arm64 (read only) 2592612 2592612 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187488 2187488 0 0.0
tv-app debug (read only) 3099697 3099697 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249216 249216 0 0.0
.text 2662578 2662578 0 0.0
tv-casting-app debug (read only) 5560809 5563313 2504 0.0
(read/write) 161744 161968 224 0.1
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102824 103048 224 0.2
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343433 343433 0 0.0
.text 4940162 4942018 1856 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447376 2447376 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410020 1410020 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173375 1173359 -16 -0.0
bss 142900 142900 0 0.0
rodata 141360 141360 0 0.0
text 810212 810208 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154227 1154227 0 0.0
bss 142136 142136 0 0.0
rodata 133292 133292 0 0.0
text 799908 799908 0 0.0
p6 all-clusters-app default (read/write) 2563008 2563008 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521272 1521272 0 0.0
all-clusters-minimal-app default (read/write) 2508872 2508872 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467136 1467136 0 0.0
light-app default (read/write) 2439240 2439240 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397504 0 0.0
lock-app default (read/write) 2465672 2465672 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423936 1423936 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796636 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565130 565132 2 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816464 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581454 581454 0 0.0

@woody-apple woody-apple merged commit a498673 into project-chip:master Jul 5, 2022
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@andy31415 andy31415 Awaiting requested review from andy31415

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees

@vivien-apple vivien-apple

Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
3 participants
@vivien-apple @andy31415 @woody-apple