Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EFR32] Lock-app working schedules with nvm storage, nvm credentials fix, add comments #20044

Merged
merged 6 commits into from
Jun 30, 2022
Merged

[EFR32] Lock-app working schedules with nvm storage, nvm credentials fix, add comments #20044

merged 6 commits into from
Jun 30, 2022

Conversation

mykrupp
Copy link
Contributor

@mykrupp mykrupp commented Jun 28, 2022 •
edited
Loading

Problem

No schedules implementation
mCredentials not stored in nvm properly.

Change overview

EFR32 weekDay, yearDay and holiday schedules implemented with nvm storage
get maxSchedule attributes in app code
nvm storage fix for mCredentials
changed structure of mCredentials so it can be used with one nvm key
add/move comments

Testing

This was tested on EFR32.
setSchedule, getSchedule and clearSchedule were test for weekDay, yearDay and holiday schedules

@restyled-io restyled-io bot mentioned this pull request Jun 28, 2022
Closed
@mykrupp mykrupp marked this pull request as ready for review June 28, 2022 15:16
@mykrupp mykrupp changed the title [EFR32] working schedules with nvm storage, nvm credentials fix, add comments [EFR32] Lock-app working schedules with nvm storage, nvm credentials fix, add comments Jun 28, 2022
@github-actions
Copy link

github-actions bot commented Jun 28, 2022 •
edited
Loading

PR #20044: Size comparison from 6e6892a to bc55a4b

Increases above 0.2%:

platform target config section 6e6892a8 bc55a4b change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1121040 1125672 4632 0.4
.bss 140920 143904 2984 2.1
Increases (3 builds for efr32, nrfconnect, telink)
platform target config section 6e6892a8 bc55a4b change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1121040 1125672 4632 0.4
.bss 140920 143904 2984 2.1
.text 978040 979688 1648 0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 809716 809720 4 0.0
telink lighting-app tlsr9518adk80d text 581092 581094 2 0.0
Decreases (1 build for telink)
platform target config section 6e6892a8 bc55a4b change % change
telink light-switch-app tlsr9518adk80d text 564548 564546 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6e6892a8 bc55a4b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 664907 664907 0 0.0
(read/write) 188076 188076 0 0.0
.bss 75876 75876 0 0.0
.data 3356 3356 0 0.0
.rodata 87891 87891 0 0.0
.text 576700 576700 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653639 653639 0 0.0
(read/write) 198640 198640 0 0.0
.bss 75172 75172 0 0.0
.data 3356 3356 0 0.0
.rodata 91359 91359 0 0.0
.text 561964 561964 0 0.0
lock-ftd LP_CC2652R7 (read only) 667447 667447 0 0.0
(read/write) 175680 175680 0 0.0
.bss 72908 72908 0 0.0
.data 3280 3280 0 0.0
.rodata 75983 75983 0 0.0
.text 590984 590984 0 0.0
lock-mtd LP_CC2652R7 (read only) 616855 616855 0 0.0
(read/write) 146024 146024 0 0.0
.bss 68628 68628 0 0.0
.data 3280 3280 0 0.0
.rodata 75863 75863 0 0.0
.text 540504 540504 0 0.0
pump-app LP_CC2652R7 (read only) 677007 677007 0 0.0
(read/write) 166976 166976 0 0.0
.bss 72996 72996 0 0.0
.data 3280 3280 0 0.0
.rodata 88367 88367 0 0.0
.text 588156 588156 0 0.0
pump-controller-app LP_CC2652R7 (read only) 662919 662919 0 0.0
(read/write) 181184 181184 0 0.0
.bss 73116 73116 0 0.0
.data 3276 3276 0 0.0
.rodata 84215 84215 0 0.0
.text 578224 578224 0 0.0
shell LP_CC2652R7 (read only) 657362 657362 0 0.0
(read/write) 191124 191124 0 0.0
.bss 78180 78180 0 0.0
.data 3360 3360 0 0.0
.rodata 84650 84650 0 0.0
.text 572396 572396 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580446 580446 0 0.0
.app_xip_area 457456 457456 0 0.0
.bss 65952 65952 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 582014 582014 0 0.0
.app_xip_area 458832 458832 0 0.0
.bss 66144 66144 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583494 583494 0 0.0
.app_xip_area 461352 461352 0 0.0
.bss 65160 65160 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081380 1081380 0 0.0
.bss 134756 134756 0 0.0
.data 2048 2048 0 0.0
.text 944556 944556 0 0.0
BRD4161A+rpc (read/write) 1135668 1135668 0 0.0
.bss 151444 151444 0 0.0
.data 2260 2260 0 0.0
.text 981944 981944 0 0.0
BRD4161A+rs911x (read/write) 943880 943880 0 0.0
.bss 140472 140472 0 0.0
.data 2048 2048 0 0.0
.text 801340 801340 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121040 1125672 4632 0.4
.bss 140920 143904 2984 2.1
.data 2060 2060 0 0.0
.text 978040 979688 1648 0.2
window-app BRD4161A (read/write) 1066660 1066660 0 0.0
.bss 134836 134836 0 0.0
.data 2076 2076 0 0.0
.text 929724 929724 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018292 1018292 0 0.0
(read/write) 1486610 1486610 0 0.0
.dram0.bss 71864 71864 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 214688 214688 0 0.0
.flash.text 1018292 1018292 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072459 1072459 0 0.0
(read/write) 488696 488696 0 0.0
.dram0.bss 77384 77384 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245172 245172 0 0.0
.flash.text 1067075 1067075 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659688 659688 0 0.0
.bss 71276 71276 0 0.0
.data 1992 1992 0 0.0
.text 580620 580620 0 0.0
lock k32w061+release (read/write) 685944 685944 0 0.0
.bss 71748 71748 0 0.0
.data 2004 2004 0 0.0
.text 606392 606392 0 0.0
linux all-clusters-app debug (read only) 2952905 2952905 0 0.0
(read/write) 178136 178136 0 0.0
.bss 84960 84960 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84936 84936 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263005 263005 0 0.0
.text 2512834 2512834 0 0.0
all-clusters-minimal-app debug (read only) 2807017 2807017 0 0.0
(read/write) 170072 170072 0 0.0
.bss 84288 84288 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77576 77576 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264669 264669 0 0.0
.text 2367458 2367458 0 0.0
bridge-app debug+rpc (read only) 2310481 2310481 0 0.0
(read/write) 148896 148896 0 0.0
.bss 72352 72352 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66952 66952 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197600 197600 0 0.0
.text 1951266 1951266 0 0.0
chip-tool debug (read only) 10169573 10169573 0 0.0
(read/write) 610824 610824 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579056 579056 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509029 509029 0 0.0
.text 8251813 8251813 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9902724 9902724 0 0.0
(read/write) 675665 675665 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614640 614640 0 0.0
.dynamic 528 528 0 0.0
.got 13440 13440 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472148 472148 0 0.0
.text 7890980 7890980 0 0.0
lighting-app debug+rpc (read only) 2547001 2547001 0 0.0
(read/write) 152952 152952 0 0.0
.bss 72896 72896 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213416 213416 0 0.0
.text 2163378 2163378 0 0.0
lock-app debug (read only) 2508233 2508233 0 0.0
(read/write) 147896 147896 0 0.0
.bss 71264 71264 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228104 228104 0 0.0
.text 2115106 2115106 0 0.0
ota-provider-app debug (read only) 2317401 2317401 0 0.0
(read/write) 141736 141736 0 0.0
.bss 70944 70944 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63064 63064 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203224 203224 0 0.0
.text 1951522 1951522 0 0.0
ota-requestor-app debug (read only) 2434521 2434521 0 0.0
(read/write) 148608 148608 0 0.0
.bss 73280 73280 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207232 207232 0 0.0
.text 2056258 2056258 0 0.0
shell debug (read only) 2542665 2542665 0 0.0
(read/write) 164488 164488 0 0.0
.bss 80904 80904 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227122 227122 0 0.0
.text 2159250 2159250 0 0.0
thermostat-no-ble arm64 (read only) 2590428 2590428 0 0.0
(read/write) 181761 181761 0 0.0
.bss 88705 88705 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83256 83256 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165004 165004 0 0.0
.text 2185696 2185696 0 0.0
tv-app debug (read only) 3096529 3096529 0 0.0
(read/write) 279240 279240 0 0.0
.bss 188648 188648 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79312 79312 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248768 248768 0 0.0
.text 2660002 2660002 0 0.0
tv-casting-app debug (read only) 5554449 5554449 0 0.0
(read/write) 185136 185136 0 0.0
.bss 73704 73704 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102776 102776 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343049 343049 0 0.0
.text 4934594 4934594 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2446672 2446672 0 0.0
.bss 215716 215716 0 0.0
.data 5872 5872 0 0.0
.text 1409316 1409316 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174595 1174595 0 0.0
bss 144650 144650 0 0.0
rodata 141284 141284 0 0.0
text 809716 809720 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155463 1155463 0 0.0
bss 143886 143886 0 0.0
rodata 133216 133216 0 0.0
text 799428 799428 0 0.0
p6 all-clusters-app default (read/write) 2562568 2562568 0 0.0
.bss 150896 150896 0 0.0
.data 2776 2776 0 0.0
.text 1520832 1520832 0 0.0
all-clusters-minimal-app default (read/write) 2508416 2508416 0 0.0
.bss 150176 150176 0 0.0
.data 2776 2776 0 0.0
.text 1466680 1466680 0 0.0
light-app default (read/write) 2438584 2438584 0 0.0
.bss 142232 142232 0 0.0
.data 2592 2592 0 0.0
.text 1396848 1396848 0 0.0
lock-app default (read/write) 2464856 2464856 0 0.0
.bss 142080 142080 0 0.0
.data 2600 2600 0 0.0
.text 1423120 1423120 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797712 797712 0 0.0
bss 72344 72344 0 0.0
noinit 40416 40416 0 0.0
text 564548 564546 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 817780 817780 0 0.0
bss 73164 73164 0 0.0
noinit 40416 40416 0 0.0
text 581092 581094 2 0.0

@restyled-io restyled-io bot mentioned this pull request Jun 28, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 28, 2022 •
edited
Loading

PR #20044: Size comparison from 6e6892a to 9f9e906

Increases above 0.2%:

platform target config section 6e6892a8 9f9e906 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1121040 1125648 4608 0.4
.bss 140920 143904 2984 2.1
Increases (4 builds for cc13x2_26x2, efr32, nrfconnect, telink)
platform target config section 6e6892a8 9f9e906 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 175680 175688 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1121040 1125648 4608 0.4
.bss 140920 143904 2984 2.1
.text 978040 979664 1624 0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 809716 809720 4 0.0
telink lighting-app tlsr9518adk80d text 581092 581094 2 0.0
Decreases (2 builds for cc13x2_26x2, esp32)
platform target config section 6e6892a8 9f9e906 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667447 667439 -8 -0.0
.text 590984 590976 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1018292 1018290 -2 -0.0
.flash.text 1018292 1018290 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6e6892a8 9f9e906 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 664907 664907 0 0.0
(read/write) 188076 188076 0 0.0
.bss 75876 75876 0 0.0
.data 3356 3356 0 0.0
.rodata 87891 87891 0 0.0
.text 576700 576700 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653639 653639 0 0.0
(read/write) 198640 198640 0 0.0
.bss 75172 75172 0 0.0
.data 3356 3356 0 0.0
.rodata 91359 91359 0 0.0
.text 561964 561964 0 0.0
lock-ftd LP_CC2652R7 (read only) 667447 667439 -8 -0.0
(read/write) 175680 175688 8 0.0
.bss 72908 72908 0 0.0
.data 3280 3280 0 0.0
.rodata 75983 75983 0 0.0
.text 590984 590976 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 616855 616855 0 0.0
(read/write) 146024 146024 0 0.0
.bss 68628 68628 0 0.0
.data 3280 3280 0 0.0
.rodata 75863 75863 0 0.0
.text 540504 540504 0 0.0
pump-app LP_CC2652R7 (read only) 677007 677007 0 0.0
(read/write) 166976 166976 0 0.0
.bss 72996 72996 0 0.0
.data 3280 3280 0 0.0
.rodata 88367 88367 0 0.0
.text 588156 588156 0 0.0
pump-controller-app LP_CC2652R7 (read only) 662919 662919 0 0.0
(read/write) 181184 181184 0 0.0
.bss 73116 73116 0 0.0
.data 3276 3276 0 0.0
.rodata 84215 84215 0 0.0
.text 578224 578224 0 0.0
shell LP_CC2652R7 (read only) 657362 657362 0 0.0
(read/write) 191124 191124 0 0.0
.bss 78180 78180 0 0.0
.data 3360 3360 0 0.0
.rodata 84650 84650 0 0.0
.text 572396 572396 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580446 580446 0 0.0
.app_xip_area 457456 457456 0 0.0
.bss 65952 65952 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 582014 582014 0 0.0
.app_xip_area 458832 458832 0 0.0
.bss 66144 66144 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583494 583494 0 0.0
.app_xip_area 461352 461352 0 0.0
.bss 65160 65160 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081380 1081380 0 0.0
.bss 134756 134756 0 0.0
.data 2048 2048 0 0.0
.text 944556 944556 0 0.0
BRD4161A+rpc (read/write) 1135668 1135668 0 0.0
.bss 151444 151444 0 0.0
.data 2260 2260 0 0.0
.text 981944 981944 0 0.0
BRD4161A+rs911x (read/write) 943880 943880 0 0.0
.bss 140472 140472 0 0.0
.data 2048 2048 0 0.0
.text 801340 801340 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121040 1125648 4608 0.4
.bss 140920 143904 2984 2.1
.data 2060 2060 0 0.0
.text 978040 979664 1624 0.2
window-app BRD4161A (read/write) 1066660 1066660 0 0.0
.bss 134836 134836 0 0.0
.data 2076 2076 0 0.0
.text 929724 929724 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018292 1018290 -2 -0.0
(read/write) 1486610 1486610 0 0.0
.dram0.bss 71864 71864 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 214688 214688 0 0.0
.flash.text 1018292 1018290 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072459 1072459 0 0.0
(read/write) 488696 488696 0 0.0
.dram0.bss 77384 77384 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245172 245172 0 0.0
.flash.text 1067075 1067075 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659688 659688 0 0.0
.bss 71276 71276 0 0.0
.data 1992 1992 0 0.0
.text 580620 580620 0 0.0
lock k32w061+release (read/write) 685944 685944 0 0.0
.bss 71748 71748 0 0.0
.data 2004 2004 0 0.0
.text 606392 606392 0 0.0
linux all-clusters-app debug (read only) 2952905 2952905 0 0.0
(read/write) 178136 178136 0 0.0
.bss 84960 84960 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84936 84936 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263005 263005 0 0.0
.text 2512834 2512834 0 0.0
all-clusters-minimal-app debug (read only) 2807017 2807017 0 0.0
(read/write) 170072 170072 0 0.0
.bss 84288 84288 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77576 77576 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264669 264669 0 0.0
.text 2367458 2367458 0 0.0
bridge-app debug+rpc (read only) 2310481 2310481 0 0.0
(read/write) 148896 148896 0 0.0
.bss 72352 72352 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66952 66952 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197600 197600 0 0.0
.text 1951266 1951266 0 0.0
chip-tool debug (read only) 10169573 10169573 0 0.0
(read/write) 610824 610824 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579056 579056 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509029 509029 0 0.0
.text 8251813 8251813 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9902724 9902724 0 0.0
(read/write) 675665 675665 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614640 614640 0 0.0
.dynamic 528 528 0 0.0
.got 13440 13440 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472148 472148 0 0.0
.text 7890980 7890980 0 0.0
lighting-app debug+rpc (read only) 2547001 2547001 0 0.0
(read/write) 152952 152952 0 0.0
.bss 72896 72896 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213416 213416 0 0.0
.text 2163378 2163378 0 0.0
lock-app debug (read only) 2508233 2508233 0 0.0
(read/write) 147896 147896 0 0.0
.bss 71264 71264 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228104 228104 0 0.0
.text 2115106 2115106 0 0.0
ota-provider-app debug (read only) 2317401 2317401 0 0.0
(read/write) 141736 141736 0 0.0
.bss 70944 70944 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63064 63064 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203224 203224 0 0.0
.text 1951522 1951522 0 0.0
ota-requestor-app debug (read only) 2434521 2434521 0 0.0
(read/write) 148608 148608 0 0.0
.bss 73280 73280 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207232 207232 0 0.0
.text 2056258 2056258 0 0.0
shell debug (read only) 2542665 2542665 0 0.0
(read/write) 164488 164488 0 0.0
.bss 80904 80904 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227122 227122 0 0.0
.text 2159250 2159250 0 0.0
thermostat-no-ble arm64 (read only) 2590428 2590428 0 0.0
(read/write) 181761 181761 0 0.0
.bss 88705 88705 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83256 83256 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165004 165004 0 0.0
.text 2185696 2185696 0 0.0
tv-app debug (read only) 3096529 3096529 0 0.0
(read/write) 279240 279240 0 0.0
.bss 188648 188648 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79312 79312 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248768 248768 0 0.0
.text 2660002 2660002 0 0.0
tv-casting-app debug (read only) 5554449 5554449 0 0.0
(read/write) 185136 185136 0 0.0
.bss 73704 73704 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102776 102776 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343049 343049 0 0.0
.text 4934594 4934594 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2446672 2446672 0 0.0
.bss 215716 215716 0 0.0
.data 5872 5872 0 0.0
.text 1409316 1409316 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174595 1174595 0 0.0
bss 144650 144650 0 0.0
rodata 141284 141284 0 0.0
text 809716 809720 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155463 1155463 0 0.0
bss 143886 143886 0 0.0
rodata 133216 133216 0 0.0
text 799428 799428 0 0.0
p6 all-clusters-app default (read/write) 2562568 2562568 0 0.0
.bss 150896 150896 0 0.0
.data 2776 2776 0 0.0
.text 1520832 1520832 0 0.0
all-clusters-minimal-app default (read/write) 2508416 2508416 0 0.0
.bss 150176 150176 0 0.0
.data 2776 2776 0 0.0
.text 1466680 1466680 0 0.0
light-app default (read/write) 2438584 2438584 0 0.0
.bss 142232 142232 0 0.0
.data 2592 2592 0 0.0
.text 1396848 1396848 0 0.0
lock-app default (read/write) 2464856 2464856 0 0.0
.bss 142080 142080 0 0.0
.data 2600 2600 0 0.0
.text 1423120 1423120 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797712 797712 0 0.0
bss 72344 72344 0 0.0
noinit 40416 40416 0 0.0
text 564548 564548 0 0.0
lighting-app tlsr9518adk80d (read/write) 817780 817780 0 0.0
bss 73164 73164 0 0.0
noinit 40416 40416 0 0.0
text 581092 581094 2 0.0

@github-actions
Copy link

github-actions bot commented Jun 28, 2022 •
edited
Loading

PR #20044: Size comparison from 02c0e3c to 6e7c275

Increases above 0.2%:

platform target config section 02c0e3c 6e7c275 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1120920 1125528 4608 0.4
.bss 140912 143896 2984 2.1
Increases (3 builds for efr32, telink)
platform target config section 02c0e3c 6e7c275 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1120920 1125528 4608 0.4
.bss 140912 143896 2984 2.1
.text 977928 979552 1624 0.2
telink light-switch-app tlsr9518adk80d (read/write) 797572 797580 8 0.0
text 564536 564538 2 0.0
lighting-app tlsr9518adk80d text 580898 580900 2 0.0
Decreases (1 build for nrfconnect)
platform target config section 02c0e3c 6e7c275 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 809564 809560 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 02c0e3c 6e7c275 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 664779 664779 0 0.0
(read/write) 188212 188212 0 0.0
.bss 75884 75884 0 0.0
.data 3356 3356 0 0.0
.rodata 87891 87891 0 0.0
.text 576572 576572 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653511 653511 0 0.0
(read/write) 198776 198776 0 0.0
.bss 75180 75180 0 0.0
.data 3356 3356 0 0.0
.rodata 91359 91359 0 0.0
.text 561836 561836 0 0.0
lock-ftd LP_CC2652R7 (read only) 667319 667319 0 0.0
(read/write) 175816 175816 0 0.0
.bss 72916 72916 0 0.0
.data 3280 3280 0 0.0
.rodata 75983 75983 0 0.0
.text 590856 590856 0 0.0
lock-mtd LP_CC2652R7 (read only) 616727 616727 0 0.0
(read/write) 146032 146032 0 0.0
.bss 68636 68636 0 0.0
.data 3280 3280 0 0.0
.rodata 75863 75863 0 0.0
.text 540376 540376 0 0.0
pump-app LP_CC2652R7 (read only) 676759 676759 0 0.0
(read/write) 167232 167232 0 0.0
.bss 73004 73004 0 0.0
.data 3280 3280 0 0.0
.rodata 88215 88215 0 0.0
.text 588060 588060 0 0.0
pump-controller-app LP_CC2652R7 (read only) 662611 662611 0 0.0
(read/write) 181500 181500 0 0.0
.bss 73124 73124 0 0.0
.data 3276 3276 0 0.0
.rodata 84067 84067 0 0.0
.text 578064 578064 0 0.0
shell LP_CC2652R7 (read only) 657250 657250 0 0.0
(read/write) 191244 191244 0 0.0
.bss 78188 78188 0 0.0
.data 3360 3360 0 0.0
.rodata 84650 84650 0 0.0
.text 572284 572284 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580398 580398 0 0.0
.app_xip_area 457400 457400 0 0.0
.bss 65960 65960 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 581974 581974 0 0.0
.app_xip_area 458784 458784 0 0.0
.bss 66152 66152 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583194 583194 0 0.0
.app_xip_area 461044 461044 0 0.0
.bss 65168 65168 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081132 1081132 0 0.0
.bss 134764 134764 0 0.0
.data 2048 2048 0 0.0
.text 944300 944300 0 0.0
BRD4161A+rpc (read/write) 1135428 1135428 0 0.0
.bss 151452 151452 0 0.0
.data 2260 2260 0 0.0
.text 981696 981696 0 0.0
BRD4161A+rs911x (read/write) 943664 943664 0 0.0
.bss 140480 140480 0 0.0
.data 2048 2048 0 0.0
.text 801116 801116 0 0.0
lock-app BRD4161A+wf200 (read/write) 1120920 1125528 4608 0.4
.bss 140912 143896 2984 2.1
.data 2060 2060 0 0.0
.text 977928 979552 1624 0.2
window-app BRD4161A (read/write) 1066396 1066396 0 0.0
.bss 134844 134844 0 0.0
.data 2076 2076 0 0.0
.text 929452 929452 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018282 1018282 0 0.0
(read/write) 1486482 1486482 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 214576 214576 0 0.0
.flash.text 1018282 1018282 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072455 1072455 0 0.0
(read/write) 488576 488576 0 0.0
.dram0.bss 77376 77376 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245060 245060 0 0.0
.flash.text 1067071 1067071 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659568 659568 0 0.0
.bss 71284 71284 0 0.0
.data 1992 1992 0 0.0
.text 580492 580492 0 0.0
lock k32w061+release (read/write) 685824 685824 0 0.0
.bss 71756 71756 0 0.0
.data 2004 2004 0 0.0
.text 606264 606264 0 0.0
linux all-clusters-app debug (read only) 2952761 2952761 0 0.0
(read/write) 178136 178136 0 0.0
.bss 84960 84960 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84936 84936 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 262909 262909 0 0.0
.text 2512786 2512786 0 0.0
all-clusters-minimal-app debug (read only) 2806857 2806857 0 0.0
(read/write) 170072 170072 0 0.0
.bss 84288 84288 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77576 77576 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264573 264573 0 0.0
.text 2367394 2367394 0 0.0
bridge-app debug+rpc (read only) 2310289 2310289 0 0.0
(read/write) 148896 148896 0 0.0
.bss 72352 72352 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66952 66952 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197472 197472 0 0.0
.text 1951202 1951202 0 0.0
chip-tool debug (read only) 10171717 10171717 0 0.0
(read/write) 610824 610824 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579056 579056 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508933 508933 0 0.0
.text 8254053 8254053 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9904404 9904404 0 0.0
(read/write) 675649 675649 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614640 614640 0 0.0
.dynamic 528 528 0 0.0
.got 13440 13440 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472196 472196 0 0.0
.text 7892612 7892612 0 0.0
lighting-app debug+rpc (read only) 2546153 2546153 0 0.0
(read/write) 152952 152952 0 0.0
.bss 72896 72896 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213256 213256 0 0.0
.text 2162690 2162690 0 0.0
lock-app debug (read only) 2508073 2508073 0 0.0
(read/write) 147896 147896 0 0.0
.bss 71264 71264 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228008 228008 0 0.0
.text 2115042 2115042 0 0.0
ota-provider-app debug (read only) 2317241 2317241 0 0.0
(read/write) 141704 141704 0 0.0
.bss 70912 70912 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63064 63064 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203128 203128 0 0.0
.text 1951458 1951458 0 0.0
ota-requestor-app debug (read only) 2434329 2434329 0 0.0
(read/write) 148608 148608 0 0.0
.bss 73280 73280 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207104 207104 0 0.0
.text 2056194 2056194 0 0.0
shell debug (read only) 2542489 2542489 0 0.0
(read/write) 164456 164456 0 0.0
.bss 80872 80872 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 226994 226994 0 0.0
.text 2159202 2159202 0 0.0
thermostat-no-ble arm64 (read only) 2590364 2590364 0 0.0
(read/write) 181745 181745 0 0.0
.bss 88689 88689 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83256 83256 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165004 165004 0 0.0
.text 2185632 2185632 0 0.0
tv-app debug (read only) 3095697 3095697 0 0.0
(read/write) 279240 279240 0 0.0
.bss 188648 188648 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79312 79312 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248608 248608 0 0.0
.text 2659330 2659330 0 0.0
tv-casting-app debug (read only) 5553617 5553617 0 0.0
(read/write) 185136 185136 0 0.0
.bss 73704 73704 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102776 102776 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 342889 342889 0 0.0
.text 4933922 4933922 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2446560 2446560 0 0.0
.bss 215708 215708 0 0.0
.data 5872 5872 0 0.0
.text 1409204 1409204 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174287 1174287 0 0.0
bss 144658 144658 0 0.0
rodata 141136 141136 0 0.0
text 809564 809560 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155155 1155155 0 0.0
bss 143894 143894 0 0.0
rodata 133068 133068 0 0.0
text 799268 799268 0 0.0
p6 all-clusters-app default (read/write) 2562440 2562440 0 0.0
.bss 150888 150888 0 0.0
.data 2776 2776 0 0.0
.text 1520704 1520704 0 0.0
all-clusters-minimal-app default (read/write) 2508288 2508288 0 0.0
.bss 150168 150168 0 0.0
.data 2776 2776 0 0.0
.text 1466552 1466552 0 0.0
light-app default (read/write) 2438440 2438440 0 0.0
.bss 142224 142224 0 0.0
.data 2592 2592 0 0.0
.text 1396704 1396704 0 0.0
lock-app default (read/write) 2464704 2464704 0 0.0
.bss 142072 142072 0 0.0
.data 2600 2600 0 0.0
.text 1422968 1422968 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797572 797580 8 0.0
bss 72336 72336 0 0.0
noinit 40416 40416 0 0.0
text 564536 564538 2 0.0
lighting-app tlsr9518adk80d (read/write) 817440 817440 0 0.0
bss 73172 73172 0 0.0
noinit 40416 40416 0 0.0
text 580898 580900 2 0.0

@mykrupp
add index-checking helper functions, add param builder, replace prepr…
7eb2da4 
…ocessor directive with constants, general clean up
@mykrupp mykrupp mentioned this pull request Jun 30, 2022
Closed
andy31415
andy31415 approved these changes Jun 30, 2022
View reviewed changes
examples/lock-app/efr32/include/LockManager.h Outdated Show resolved Hide resolved
examples/lock-app/efr32/src/LockManager.cpp Outdated Show resolved Hide resolved
examples/lock-app/efr32/src/LockManager.cpp Outdated Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request Jun 30, 2022
Closed
rcasallas-silabs
rcasallas-silabs approved these changes Jun 30, 2022
View reviewed changes
examples/lock-app/efr32/include/LockManager.h Outdated Show resolved Hide resolved
examples/lock-app/efr32/src/LockManager.cpp Outdated Show resolved Hide resolved
@andy31415 andy31415 merged commit b7677b1 into project-chip:master Jun 30, 2022
@AlvinHsiao AlvinHsiao mentioned this pull request Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@rcasallas-silabs rcasallas-silabs rcasallas-silabs approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
efr32 examples fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykrupp @andy31415 @rcasallas-silabs @restyled-commits