-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infineon] Lock-app updates, adding multiple users and credentials for CYW30739 #20034
Merged
woody-apple
merged 2 commits into
project-chip:master
from
AlvinHsiao:alvinhsiao-CYW30739-Lock
Jul 6, 2022
Merged
[Infineon] Lock-app updates, adding multiple users and credentials for CYW30739 #20034
woody-apple
merged 2 commits into
project-chip:master
from
AlvinHsiao:alvinhsiao-CYW30739-Lock
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mrjerryjohns
June 28, 2022 13:12
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 28, 2022 13:12
PR #20034: Size comparison from 6387049 to 274c3ae Increases above 0.2%:
Increases (2 builds for cyw30739, esp32)
Decreases (2 builds for nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 28, 2022
Fast tracking platform changes, pending comments. |
bzbarsky-apple
requested changes
Jun 28, 2022
AlvinHsiao
force-pushed
the
alvinhsiao-CYW30739-Lock
branch
from
June 29, 2022 05:18
274c3ae
to
f5cc591
Compare
PR #20034: Size comparison from 81c7f2a to f5cc591 Increases above 0.2%:
Increases (1 build for cyw30739)
Decreases (2 builds for cyw30739, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
AlvinHsiao
force-pushed
the
alvinhsiao-CYW30739-Lock
branch
from
June 30, 2022 03:29
f5cc591
to
463cf7c
Compare
PR #20034: Size comparison from a45d571 to 463cf7c Increases above 0.2%:
Increases (4 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
Decreases (2 builds for cc13x2_26x2, cyw30739)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
requested changes
Jun 30, 2022
* Fix mCredentials, fix NVM flash saving * restyle * cleanup * remove unused array * remove TotalCredentials key * Check mMaxUsers against DOOR_LOCK_MAX_USERS
AlvinHsiao
force-pushed
the
alvinhsiao-CYW30739-Lock
branch
from
July 4, 2022 03:16
463cf7c
to
8c31263
Compare
PR #20034: Size comparison from 08cb351 to 8c31263 Increases above 0.2%:
Increases (3 builds for cyw30739, telink)
Decreases (4 builds for cyw30739, nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Infineon] Lock-app updates, adding multiple users and credentials for CYW30739