-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chef] Zap files general commissioning feature map in examples #20012
[chef] Zap files general commissioning feature map in examples #20012
Conversation
PR #20012: Size comparison from e80724e to 035b6c6 Increases (1 build for telink)
Decreases (1 build for telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Change-Id: I90f96520553a28e28bc0b3550d9bb93eca2d12b6
Change-Id: Ic4362266d7ac653397f16096d8d748751cbfd6a6
PR #20012: Size comparison from e80724e to 33d9c44 Increases (3 builds for cc13x2_26x2)
Decreases (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Please rename the files using Please also add the |
Change-Id: I879eed1d3a510060148b87a48562c799815c59f9
Change-Id: I2473f8e0d9aaeb0a3402577c021af254fbf8376f
PR #20012: Size comparison from e80724e to 7c4a0b5 Increases (6 builds for cc13x2_26x2)
Decreases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for renaming in this update.
@aBozowski - can we undo this move? matter files are supposed to be human reviewable and everything in zzz_generated will be collapsed by github by default (because noise) so having these files in zzz_generated effectively hides away changes within other generated file noise. |
…ct-chip#20012) * fix: setting general commissioning cluster feature map's default value to 0 * chg: not making changes to dummy file used by sample app utils Change-Id: I90f96520553a28e28bc0b3550d9bb93eca2d12b6 * chg: commited zzz_generated artifacts Change-Id: Ic4362266d7ac653397f16096d8d748751cbfd6a6 * chg: renamed zap files in chef Change-Id: I879eed1d3a510060148b87a48562c799815c59f9 * fix: removed old generated files Change-Id: I2473f8e0d9aaeb0a3402577c021af254fbf8376f
… (#20048) * fix: setting general commissioning cluster feature map's default value to 0 * chg: not making changes to dummy file used by sample app utils Change-Id: I90f96520553a28e28bc0b3550d9bb93eca2d12b6 * chg: commited zzz_generated artifacts Change-Id: Ic4362266d7ac653397f16096d8d748751cbfd6a6 * chg: renamed zap files in chef Change-Id: I879eed1d3a510060148b87a48562c799815c59f9 * fix: removed old generated files Change-Id: I2473f8e0d9aaeb0a3402577c021af254fbf8376f Co-authored-by: Douglas Rocha Ferraz <[email protected]>
…#20012) (project-chip#20048) * fix: setting general commissioning cluster feature map's default value to 0 * chg: not making changes to dummy file used by sample app utils Change-Id: I90f96520553a28e28bc0b3550d9bb93eca2d12b6 * chg: commited zzz_generated artifacts Change-Id: Ic4362266d7ac653397f16096d8d748751cbfd6a6 * chg: renamed zap files in chef Change-Id: I879eed1d3a510060148b87a48562c799815c59f9 * fix: removed old generated files Change-Id: I2473f8e0d9aaeb0a3402577c021af254fbf8376f Co-authored-by: Douglas Rocha Ferraz <[email protected]>
The spec changed and this cluster no longer has a FeatureMap defined,
so the default value needs to be 0. See PR #20003
Problem
Wrong FeatureMap value reported.
Change overview
fix to .zap files. Chef doesn't have (yet) .matter files committed