Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix general commissioning feature map in examples. #20003

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Fix general commissioning feature map in examples. #20003

merged 1 commit into from
Jun 28, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

The spec changed and this cluster no longer has a FeatureMap defined,
so the default value needs to be 0.

Fixes #19218

Problem

Wrong FeatureMap value reported.

Change overview

Fix to match spec.

Testing

Examined the .matter files and the endpoint_config files to make sure the right things are changing.

@bzbarsky-apple
Fix general commissioning feature map in examples.
665fa57 
The spec changed and this cluster no longer has a FeatureMap defined,
so the default value needs to be 0.

Fixes project-chip#19218
@github-actions
Copy link

github-actions bot commented Jun 27, 2022 •
edited
Loading

PR #20003: Size comparison from 9b3668c to 665fa57

Increases (2 builds for cc13x2_26x2, cyw30739)
platform target config section 9b3668c 665fa57 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 187900 187908 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583886 583894 8 0.0
.app_xip_area 461728 461736 8 0.0
Decreases (3 builds for cc13x2_26x2, k32w, nrfconnect)
platform target config section 9b3668c 665fa57 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665099 665091 -8 -0.0
.text 576892 576884 -8 -0.0
k32w light k32w061+release (read/write) 659976 659960 -16 -0.0
.text 580892 580876 -16 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156019 1156003 -16 -0.0
text 799748 799744 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9b3668c 665fa57 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665099 665091 -8 -0.0
(read/write) 187900 187908 8 0.0
.bss 75892 75892 0 0.0
.data 3356 3356 0 0.0
.rodata 87891 87891 0 0.0
.text 576892 576884 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653895 653895 0 0.0
(read/write) 198400 198400 0 0.0
.bss 75188 75188 0 0.0
.data 3356 3356 0 0.0
.rodata 91399 91399 0 0.0
.text 562180 562180 0 0.0
lock-ftd LP_CC2652R7 (read only) 667639 667639 0 0.0
(read/write) 175504 175504 0 0.0
.bss 72924 72924 0 0.0
.data 3280 3280 0 0.0
.rodata 75983 75983 0 0.0
.text 591176 591176 0 0.0
lock-mtd LP_CC2652R7 (read only) 617055 617055 0 0.0
(read/write) 146040 146040 0 0.0
.bss 68644 68644 0 0.0
.data 3280 3280 0 0.0
.rodata 75863 75863 0 0.0
.text 540704 540704 0 0.0
pump-app LP_CC2652R7 (read only) 677439 677439 0 0.0
(read/write) 166560 166560 0 0.0
.bss 73012 73012 0 0.0
.data 3280 3280 0 0.0
.rodata 88543 88543 0 0.0
.text 588412 588412 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663327 663327 0 0.0
(read/write) 180792 180792 0 0.0
.bss 73132 73132 0 0.0
.data 3276 3276 0 0.0
.rodata 84391 84391 0 0.0
.text 578456 578456 0 0.0
shell LP_CC2652R7 (read only) 657554 657554 0 0.0
(read/write) 190948 190948 0 0.0
.bss 78196 78196 0 0.0
.data 3360 3360 0 0.0
.rodata 84650 84650 0 0.0
.text 572588 572588 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580622 580622 0 0.0
.app_xip_area 457616 457616 0 0.0
.bss 65968 65968 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 582198 582198 0 0.0
.app_xip_area 459000 459000 0 0.0
.bss 66160 66160 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583886 583894 8 0.0
.app_xip_area 461728 461736 8 0.0
.bss 65176 65176 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1082164 1082164 0 0.0
.bss 134772 134772 0 0.0
.data 2048 2048 0 0.0
.text 945324 945324 0 0.0
BRD4161A+rpc (read/write) 1136476 1136476 0 0.0
.bss 151460 151460 0 0.0
.data 2260 2260 0 0.0
.text 982736 982736 0 0.0
BRD4161A+rs911x (read/write) 947544 947544 0 0.0
.bss 140488 140488 0 0.0
.data 2048 2048 0 0.0
.text 804988 804988 0 0.0
lock-app BRD4161A+wf200 (read/write) 1122096 1122096 0 0.0
.bss 140936 140936 0 0.0
.data 2060 2060 0 0.0
.text 979080 979080 0 0.0
window-app BRD4161A (read/write) 1067444 1067444 0 0.0
.bss 134852 134852 0 0.0
.data 2076 2076 0 0.0
.text 930492 930492 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019302 1019302 0 0.0
(read/write) 1486850 1486850 0 0.0
.dram0.bss 71840 71840 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 214960 214960 0 0.0
.flash.text 1019302 1019302 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073495 1073495 0 0.0
(read/write) 488944 488944 0 0.0
.dram0.bss 77360 77360 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245444 245444 0 0.0
.flash.text 1068111 1068111 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659976 659960 -16 -0.0
.bss 71292 71292 0 0.0
.data 1992 1992 0 0.0
.text 580892 580876 -16 -0.0
lock k32w061+release (read/write) 686184 686184 0 0.0
.bss 71764 71764 0 0.0
.data 2004 2004 0 0.0
.text 606616 606616 0 0.0
linux all-clusters-app debug (read only) 2958697 2958697 0 0.0
(read/write) 178200 178200 0 0.0
.bss 85024 85024 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84936 84936 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263837 263837 0 0.0
.text 2517794 2517794 0 0.0
all-clusters-minimal-app debug (read only) 2812809 2812809 0 0.0
(read/write) 170136 170136 0 0.0
.bss 84352 84352 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77576 77576 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 265501 265501 0 0.0
.text 2372418 2372418 0 0.0
bridge-app debug+rpc (read only) 2315217 2315217 0 0.0
(read/write) 148928 148928 0 0.0
.bss 72384 72384 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66952 66952 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198432 198432 0 0.0
.text 1955170 1955170 0 0.0
chip-tool debug (read only) 10192165 10192165 0 0.0
(read/write) 610856 610856 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579064 579064 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509957 509957 0 0.0
.text 8273429 8273429 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9926388 9926388 0 0.0
(read/write) 675697 675697 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614632 614632 0 0.0
.dynamic 528 528 0 0.0
.got 13456 13456 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472980 472980 0 0.0
.text 7913732 7913732 0 0.0
lighting-app debug+rpc (read only) 2552137 2552137 0 0.0
(read/write) 152984 152984 0 0.0
.bss 72928 72928 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214216 214216 0 0.0
.text 2167714 2167714 0 0.0
lock-app debug (read only) 2513993 2513993 0 0.0
(read/write) 147928 147928 0 0.0
.bss 71296 71296 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228936 228936 0 0.0
.text 2120034 2120034 0 0.0
ota-provider-app debug (read only) 2323049 2323049 0 0.0
(read/write) 141768 141768 0 0.0
.bss 70976 70976 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63064 63064 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 204024 204024 0 0.0
.text 1956370 1956370 0 0.0
ota-requestor-app debug (read only) 2440281 2440281 0 0.0
(read/write) 148640 148640 0 0.0
.bss 73312 73312 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 208032 208032 0 0.0
.text 2061218 2061218 0 0.0
shell debug (read only) 2548793 2548793 0 0.0
(read/write) 164520 164520 0 0.0
.bss 80936 80936 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 228050 228050 0 0.0
.text 2164450 2164450 0 0.0
thermostat-no-ble arm64 (read only) 2595012 2595012 0 0.0
(read/write) 181793 181793 0 0.0
.bss 88721 88721 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83256 83256 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165748 165748 0 0.0
.text 2189488 2189488 0 0.0
tv-app debug (read only) 3106193 3106193 0 0.0
(read/write) 279304 279304 0 0.0
.bss 188648 188648 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79360 79360 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249920 249920 0 0.0
.text 2668466 2668466 0 0.0
tv-casting-app debug (read only) 5590865 5590865 0 0.0
(read/write) 185136 185136 0 0.0
.bss 73704 73704 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102792 102792 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 344201 344201 0 0.0
.text 4969810 4969810 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447696 2447696 0 0.0
.bss 215732 215732 0 0.0
.data 5872 5872 0 0.0
.text 1410340 1410340 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175151 1175151 0 0.0
bss 144666 144666 0 0.0
rodata 141520 141520 0 0.0
text 810044 810044 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156019 1156003 -16 -0.0
bss 143902 143902 0 0.0
rodata 133452 133452 0 0.0
text 799748 799744 -4 -0.0
p6 all-clusters-app default (read/write) 2566416 2566416 0 0.0
.bss 150912 150912 0 0.0
.data 2776 2776 0 0.0
.text 1524680 1524680 0 0.0
all-clusters-minimal-app default (read/write) 2512280 2512280 0 0.0
.bss 150192 150192 0 0.0
.data 2776 2776 0 0.0
.text 1470544 1470544 0 0.0
light-app default (read/write) 2442416 2442416 0 0.0
.bss 142248 142248 0 0.0
.data 2592 2592 0 0.0
.text 1400680 1400680 0 0.0
lock-app default (read/write) 2468680 2468680 0 0.0
.bss 142096 142096 0 0.0
.data 2600 2600 0 0.0
.text 1426944 1426944 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798348 798348 0 0.0
bss 72360 72360 0 0.0
noinit 40416 40416 0 0.0
text 564982 564982 0 0.0
lighting-app tlsr9518adk80d (read/write) 818304 818304 0 0.0
bss 73180 73180 0 0.0
noinit 40416 40416 0 0.0
text 581416 581416 0 0.0

@rochaferraz rochaferraz mentioned this pull request Jun 27, 2022
Merged
@andy31415 andy31415 merged commit 460e723 into project-chip:master Jun 28, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-general-commissioning-feature-map branch June 28, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@tehampson tehampson Awaiting requested review from tehampson

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pre-sve] [TC-GC-1.1]General commissioning cluster---Value mismatch for FeatureMap attribute
4 participants
@bzbarsky-apple @andy31415 @tehampson @Damian-Nordic