-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detection of negative integers when floating point is expected. #19821
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:detect-negative-int-floats
Jun 22, 2022
Merged
Fix detection of negative integers when floating point is expected. #19821
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:detect-negative-int-floats
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our "see if it's an integer and append .0" code for floating point only detected positive integers, so we were ending up with things like "-1f" in generated code, which does not compile. Fixes project-chip#19800
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
June 21, 2022 18:59
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 21, 2022 18:59
tcarmelveilleux
approved these changes
Jun 21, 2022
andy31415
approved these changes
Jun 21, 2022
PR #19821: Size comparison from 89c5d50 to 924bc23 Increases (5 builds for cc13x2_26x2, linux, nrfconnect, telink)
Decreases (2 builds for cc13x2_26x2, efr32)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our "see if it's an integer and append .0" code for floating point
only detected positive integers, so we were ending up with things like
"-1f" in generated code, which does not compile.
Fixes #19800
Problem
See above.
Change overview
Fixes the regexp and enable some tests that now compile.
Testing
The new code compiles, and we'll see how it does in CI.