Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML script build fails when validating PlaybackSpeed attribute against a negative value #19800

Closed
manjunath-grl opened this issue Jun 21, 2022 · 1 comment · Fixed by #19821
Closed

YAML script build fails when validating PlaybackSpeed attribute against a negative value #19800

manjunath-grl opened this issue Jun 21, 2022 · 1 comment · Fixed by #19821
Assignees
@bzbarsky-apple

Comments

@manjunath-grl
Copy link
Contributor

Summary:
The YAML script build process fails with the following error message when PlaybackSpeed [Media Play Back Cluster] attribute is validated to return a negative value

Diff link:
master...manjunath-grl:Invalid_Digit_Error

Execution logs:
invalid digit
Invalid_Digit.zip
@bzbarsky-apple bzbarsky-apple self-assigned this Jun 21, 2022
@bzbarsky-apple
Copy link
Contributor

Diff link:
master...manjunath-grl:Invalid_Digit_Error

Thank you, that is perfect. :)

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 21, 2022
@bzbarsky-apple
Fix detection of negative integers when floating point is expected.
924bc23 
Our "see if it's an integer and append .0" code for floating point
only detected positive integers, so we were ending up with things like
"-1f" in generated code, which does not compile.

Fixes project-chip#19800
@bzbarsky-apple bzbarsky-apple mentioned this issue Jun 21, 2022
Merged
bzbarsky-apple added a commit that referenced this issue Jun 22, 2022
@bzbarsky-apple
Fix detection of negative integers when floating point is expected. (#…
51d633a 
…19821)

Our "see if it's an integer and append .0" code for floating point
only detected positive integers, so we were ending up with things like
"-1f" in generated code, which does not compile.

Fixes #19800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix detection of negative integers when floating point is expected. bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @manjunath-grl