Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tv-casting-app] Update the TV casting app in order to share mor… #19575

Merged
merged 1 commit into from
Jun 15, 2022
Merged

[chip-tv-casting-app] Update the TV casting app in order to share mor… #19575

merged 1 commit into from
Jun 15, 2022

Conversation

vivien-apple
Copy link
Contributor

…e code with chip-tool when it comes to commands parsing

Problem

The tv-casting-app depends on zzz_generated/chip-tool/zap-generated/Commands.h. That is not bad by itself, but there is the code that understand this file has been duplicated in examples/tv-casting-app/tv-casting-common/commands/ which makes it painful trying to upgrade some of the "Commands.h" generated content in #19566 as it imply having to duplicate some code...

I really want to not have to duplicate "Command.h/cpp" and all the code that handles interactions.

Change overview

  • Get the tv-casting-app to reuse the code that handle arguments from chip-tool
  • Get the tv-casting-app to reuse the code that handle the interaction model interactions

Testing

I have tried by following the steps describe in examples/tv-casting-app/linux/README.md in order to ensure that commands handling still works.

@vivien-apple vivien-apple self-assigned this Jun 14, 2022
@vivien-apple vivien-apple mentioned this pull request Jun 14, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jun 14, 2022 •
edited
Loading

PR #19575: Size comparison from 4b6fc80 to 152d53f

Increases (2 builds for cc13x2_26x2, nrfconnect)
platform target config section 4b6fc80 152d53f change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 637939 637947 8 0.0
.text 538684 538692 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 792752 792756 4 0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4b6fc80 152d53f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659119 659119 0 0.0
(read/write) 191784 191784 0 0.0
.bss 73796 73796 0 0.0
.data 3416 3416 0 0.0
.rodata 87047 87047 0 0.0
.text 571760 571760 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645667 0 0.0
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90067 90067 0 0.0
.text 555280 555280 0 0.0
lock-ftd LP_CC2652R7 (read only) 688531 688531 0 0.0
(read/write) 153444 153444 0 0.0
.bss 71756 71756 0 0.0
.data 3280 3280 0 0.0
.rodata 98883 98883 0 0.0
.text 589164 589164 0 0.0
lock-mtd LP_CC2652R7 (read only) 637939 637947 8 0.0
(read/write) 144888 144888 0 0.0
.bss 67492 67492 0 0.0
.data 3280 3280 0 0.0
.rodata 98763 98763 0 0.0
.text 538684 538692 8 0.0
pump-app LP_CC2652R7 (read only) 669747 669747 0 0.0
(read/write) 173124 173124 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 582284 582284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660471 660471 0 0.0
(read/write) 182520 182520 0 0.0
.bss 72004 72004 0 0.0
.data 3276 3276 0 0.0
.rodata 84903 84903 0 0.0
.text 575084 575084 0 0.0
shell LP_CC2652R7 (read only) 689270 689270 0 0.0
(read/write) 157128 157128 0 0.0
.bss 76092 76092 0 0.0
.data 3420 3420 0 0.0
.rodata 110126 110126 0 0.0
.text 578832 578832 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612202 612202 0 0.0
.app_xip_area 467836 467836 0 0.0
.bss 87288 87288 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 609318 609318 0 0.0
.app_xip_area 464808 464808 0 0.0
.bss 87464 87464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 615382 615382 0 0.0
.app_xip_area 471928 471928 0 0.0
.bss 86464 86464 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920584 920584 0 0.0
(read/write) 133456 133456 0 0.0
.bss 131336 131336 0 0.0
.data 2116 2116 0 0.0
.text 920576 920576 0 0.0
BRD4161A+rpc (read only) 956240 956240 0 0.0
(read/write) 150328 150328 0 0.0
.bss 148008 148008 0 0.0
.data 2320 2320 0 0.0
.text 956232 956232 0 0.0
BRD4161A+rs911x (read only) 795700 795700 0 0.0
(read/write) 129736 129736 0 0.0
.bss 127612 127612 0 0.0
.data 2124 2124 0 0.0
.text 795692 795692 0 0.0
lock-app BRD4161A+wf200 (read only) 963596 963596 0 0.0
(read/write) 130076 130076 0 0.0
.bss 127988 127988 0 0.0
.data 2088 2088 0 0.0
.text 963588 963588 0 0.0
window-app BRD4161A (read only) 905472 905472 0 0.0
(read/write) 133528 133528 0 0.0
.bss 131416 131416 0 0.0
.data 2108 2108 0 0.0
.text 905464 905464 0 0.0
esp32 all-clusters-app c3devkit (read only) 1013900 1013900 0 0.0
(read/write) 1483522 1483522 0 0.0
.dram0.bss 69424 69424 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213968 213968 0 0.0
.flash.text 1013900 1013900 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068115 1068115 0 0.0
(read/write) 485616 485616 0 0.0
.dram0.bss 74952 74952 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 244444 244444 0 0.0
.flash.text 1062731 1062731 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658328 658328 0 0.0
.bss 69764 69764 0 0.0
.data 2028 2028 0 0.0
.text 580736 580736 0 0.0
lock k32w061+release (read/write) 719940 719940 0 0.0
.bss 70196 70196 0 0.0
.data 2000 2000 0 0.0
.text 641944 641944 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9580764 9580764 0 0.0
(read/write) 690049 690049 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626288 626288 0 0.0
.dynamic 528 528 0 0.0
.got 15104 15104 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470924 470924 0 0.0
.text 7533236 7533236 0 0.0
thermostat-no-ble arm64 (read only) 2560628 2560628 0 0.0
(read/write) 191489 191489 0 0.0
.bss 99393 99393 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82432 82432 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161356 161356 0 0.0
.text 2161472 2161472 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434816 2434816 0 0.0
.bss 209212 209212 0 0.0
.data 5864 5864 0 0.0
.text 1397460 1397460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199111 1199111 0 0.0
bss 141633 141633 0 0.0
rodata 156128 156128 0 0.0
text 822412 822412 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144347 1144347 0 0.0
bss 140824 140824 0 0.0
rodata 131860 131860 0 0.0
text 792752 792756 4 0.0
p6 all-clusters-app default (read/write) 2552984 2552984 0 0.0
.bss 143424 143424 0 0.0
.data 2832 2832 0 0.0
.text 1511248 1511248 0 0.0
all-clusters-minimal-app default (read/write) 2495472 2495472 0 0.0
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1453736 1453736 0 0.0
light-app default (read/write) 2426848 2426848 0 0.0
.bss 135752 135752 0 0.0
.data 2624 2624 0 0.0
.text 1385112 1385112 0 0.0
lock-app default (read/write) 2447256 2447256 0 0.0
.bss 135576 135576 0 0.0
.data 2600 2600 0 0.0
.text 1405520 1405520 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 787840 787840 0 0.0
bss 70892 70892 0 0.0
noinit 40416 40416 0 0.0
text 557712 557712 0 0.0
lighting-app tlsr9518adk80d (read/write) 807828 807828 0 0.0
bss 71144 71144 0 0.0
noinit 40416 40416 0 0.0
text 574404 574404 0 0.0

@vivien-apple vivien-apple force-pushed the TV_CASTING_APP_ShareMoreCode branch from 152d53f to aeeb87b Compare June 14, 2022 18:55
@github-actions
Copy link

github-actions bot commented Jun 14, 2022 •
edited
Loading

PR #19575: Size comparison from 4b6fc80 to aeeb87b

Increases (2 builds for cc13x2_26x2, nrfconnect)
platform target config section 4b6fc80 aeeb87b change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 637939 637947 8 0.0
.text 538684 538692 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 792752 792756 4 0.0
Decreases (2 builds for nrfconnect, telink)
platform target config section 4b6fc80 aeeb87b change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 822412 822408 -4 -0.0
telink light-switch-app tlsr9518adk80d text 557712 557710 -2 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4b6fc80 aeeb87b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659119 659119 0 0.0
(read/write) 191784 191784 0 0.0
.bss 73796 73796 0 0.0
.data 3416 3416 0 0.0
.rodata 87047 87047 0 0.0
.text 571760 571760 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645667 0 0.0
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90067 90067 0 0.0
.text 555280 555280 0 0.0
lock-ftd LP_CC2652R7 (read only) 688531 688531 0 0.0
(read/write) 153444 153444 0 0.0
.bss 71756 71756 0 0.0
.data 3280 3280 0 0.0
.rodata 98883 98883 0 0.0
.text 589164 589164 0 0.0
lock-mtd LP_CC2652R7 (read only) 637939 637947 8 0.0
(read/write) 144888 144888 0 0.0
.bss 67492 67492 0 0.0
.data 3280 3280 0 0.0
.rodata 98763 98763 0 0.0
.text 538684 538692 8 0.0
pump-app LP_CC2652R7 (read only) 669747 669747 0 0.0
(read/write) 173124 173124 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 582284 582284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660471 660471 0 0.0
(read/write) 182520 182520 0 0.0
.bss 72004 72004 0 0.0
.data 3276 3276 0 0.0
.rodata 84903 84903 0 0.0
.text 575084 575084 0 0.0
shell LP_CC2652R7 (read only) 689270 689270 0 0.0
(read/write) 157128 157128 0 0.0
.bss 76092 76092 0 0.0
.data 3420 3420 0 0.0
.rodata 110126 110126 0 0.0
.text 578832 578832 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612202 612202 0 0.0
.app_xip_area 467836 467836 0 0.0
.bss 87288 87288 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 609318 609318 0 0.0
.app_xip_area 464808 464808 0 0.0
.bss 87464 87464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 615382 615382 0 0.0
.app_xip_area 471928 471928 0 0.0
.bss 86464 86464 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920584 920584 0 0.0
(read/write) 133456 133456 0 0.0
.bss 131336 131336 0 0.0
.data 2116 2116 0 0.0
.text 920576 920576 0 0.0
BRD4161A+rpc (read only) 956240 956240 0 0.0
(read/write) 150328 150328 0 0.0
.bss 148008 148008 0 0.0
.data 2320 2320 0 0.0
.text 956232 956232 0 0.0
BRD4161A+rs911x (read only) 795700 795700 0 0.0
(read/write) 129736 129736 0 0.0
.bss 127612 127612 0 0.0
.data 2124 2124 0 0.0
.text 795692 795692 0 0.0
lock-app BRD4161A+wf200 (read only) 963596 963596 0 0.0
(read/write) 130076 130076 0 0.0
.bss 127988 127988 0 0.0
.data 2088 2088 0 0.0
.text 963588 963588 0 0.0
window-app BRD4161A (read only) 905472 905472 0 0.0
(read/write) 133528 133528 0 0.0
.bss 131416 131416 0 0.0
.data 2108 2108 0 0.0
.text 905464 905464 0 0.0
esp32 all-clusters-app c3devkit (read only) 1013900 1013900 0 0.0
(read/write) 1483522 1483522 0 0.0
.dram0.bss 69424 69424 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213968 213968 0 0.0
.flash.text 1013900 1013900 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068115 1068115 0 0.0
(read/write) 485616 485616 0 0.0
.dram0.bss 74952 74952 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 244444 244444 0 0.0
.flash.text 1062731 1062731 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658328 658328 0 0.0
.bss 69764 69764 0 0.0
.data 2028 2028 0 0.0
.text 580736 580736 0 0.0
lock k32w061+release (read/write) 719940 719940 0 0.0
.bss 70196 70196 0 0.0
.data 2000 2000 0 0.0
.text 641944 641944 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9580764 9580764 0 0.0
(read/write) 690049 690049 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626288 626288 0 0.0
.dynamic 528 528 0 0.0
.got 15104 15104 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470924 470924 0 0.0
.text 7533236 7533236 0 0.0
thermostat-no-ble arm64 (read only) 2560628 2560628 0 0.0
(read/write) 191489 191489 0 0.0
.bss 99393 99393 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82432 82432 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161356 161356 0 0.0
.text 2161472 2161472 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434816 2434816 0 0.0
.bss 209212 209212 0 0.0
.data 5864 5864 0 0.0
.text 1397460 1397460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199111 1199111 0 0.0
bss 141633 141633 0 0.0
rodata 156128 156128 0 0.0
text 822412 822408 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144347 1144347 0 0.0
bss 140824 140824 0 0.0
rodata 131860 131860 0 0.0
text 792752 792756 4 0.0
p6 all-clusters-app default (read/write) 2552984 2552984 0 0.0
.bss 143424 143424 0 0.0
.data 2832 2832 0 0.0
.text 1511248 1511248 0 0.0
all-clusters-minimal-app default (read/write) 2495472 2495472 0 0.0
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1453736 1453736 0 0.0
light-app default (read/write) 2426848 2426848 0 0.0
.bss 135752 135752 0 0.0
.data 2624 2624 0 0.0
.text 1385112 1385112 0 0.0
lock-app default (read/write) 2447256 2447256 0 0.0
.bss 135576 135576 0 0.0
.data 2600 2600 0 0.0
.text 1405520 1405520 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 787840 787840 0 0.0
bss 70892 70892 0 0.0
noinit 40416 40416 0 0.0
text 557712 557710 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 807828 807828 0 0.0
bss 71144 71144 0 0.0
noinit 40416 40416 0 0.0
text 574404 574404 0 0.0

@vivien-apple vivien-apple force-pushed the TV_CASTING_APP_ShareMoreCode branch from aeeb87b to 98b2706 Compare June 15, 2022 07:33
@github-actions
Copy link

github-actions bot commented Jun 15, 2022 •
edited
Loading

PR #19575: Size comparison from 663ecf4 to 98b2706

Increases (1 build for telink)
platform target config section 663ecf4 98b2706 change % change
telink lighting-app tlsr9518adk80d text 574338 574340 2 0.0
Full report (8 builds for cyw30739, mbed, nrfconnect, telink)
platform target config section 663ecf4 98b2706 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 611098 611098 0 0.0
.app_xip_area 467788 467788 0 0.0
.bss 86232 86232 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608182 608182 0 0.0
.app_xip_area 464728 464728 0 0.0
.bss 86408 86408 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614246 614246 0 0.0
.app_xip_area 471856 471856 0 0.0
.bss 85400 85400 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434752 2434752 0 0.0
.bss 208148 208148 0 0.0
.data 5864 5864 0 0.0
.text 1397396 1397396 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196539 1196539 0 0.0
bss 141554 141554 0 0.0
rodata 155428 155428 0 0.0
text 820704 820704 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144587 1144587 0 0.0
bss 140794 140794 0 0.0
rodata 131956 131956 0 0.0
text 793024 793024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786720 786720 0 0.0
bss 69836 69836 0 0.0
noinit 40416 40416 0 0.0
text 557646 557646 0 0.0
lighting-app tlsr9518adk80d (read/write) 806708 806708 0 0.0
bss 70088 70088 0 0.0
noinit 40416 40416 0 0.0
text 574338 574340 2 0.0

@vivien-apple vivien-apple force-pushed the TV_CASTING_APP_ShareMoreCode branch from 98b2706 to d7265b8 Compare June 15, 2022 07:57
@restyled-io restyled-io bot mentioned this pull request Jun 15, 2022
Closed
@vivien-apple vivien-apple force-pushed the TV_CASTING_APP_ShareMoreCode branch from d7265b8 to 4b72350 Compare June 15, 2022 07:58
@github-actions
Copy link

PR #19575: Size comparison from 663ecf4 to 4b72350

Decreases (1 build for telink)
platform target config section 663ecf4 4b72350 change % change
telink lighting-app tlsr9518adk80d (read/write) 806708 806700 -8 -0.0
text 574338 574336 -2 -0.0
Full report (10 builds for cyw30739, linux, mbed, nrfconnect, telink)
platform target config section 663ecf4 4b72350 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 611098 611098 0 0.0
.app_xip_area 467788 467788 0 0.0
.bss 86232 86232 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608182 608182 0 0.0
.app_xip_area 464728 464728 0 0.0
.bss 86408 86408 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614246 614246 0 0.0
.app_xip_area 471856 471856 0 0.0
.bss 85400 85400 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9514172 9514172 0 0.0
(read/write) 685617 685617 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623120 623120 0 0.0
.dynamic 528 528 0 0.0
.got 14904 14904 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468028 468028 0 0.0
.text 7477908 7477908 0 0.0
thermostat-no-ble arm64 (read only) 2564628 2564628 0 0.0
(read/write) 191521 191521 0 0.0
.bss 99361 99361 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 82432 82432 0 0.0
.dynamic 528 528 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 162668 162668 0 0.0
.text 2164112 2164112 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434752 2434752 0 0.0
.bss 208148 208148 0 0.0
.data 5864 5864 0 0.0
.text 1397396 1397396 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196539 1196539 0 0.0
bss 141554 141554 0 0.0
rodata 155428 155428 0 0.0
text 820704 820704 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144587 1144587 0 0.0
bss 140794 140794 0 0.0
rodata 131956 131956 0 0.0
text 793024 793024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786720 786720 0 0.0
bss 69836 69836 0 0.0
noinit 40416 40416 0 0.0
text 557646 557646 0 0.0
lighting-app tlsr9518adk80d (read/write) 806708 806700 -8 -0.0
bss 70088 70088 0 0.0
noinit 40416 40416 0 0.0
text 574338 574336 -2 -0.0

@vivien-apple vivien-apple force-pushed the TV_CASTING_APP_ShareMoreCode branch from 4b72350 to a7444df Compare June 15, 2022 08:33
@github-actions
Copy link

github-actions bot commented Jun 15, 2022 •
edited
Loading

PR #19575: Size comparison from 09f3e4a to a7444df

Increases (4 builds for cc13x2_26x2, cyw30739, telink)
platform target config section 09f3e4a a7444df change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 152424 152432 8 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 608174 608182 8 0.0
.app_xip_area 464720 464728 8 0.0
telink light-switch-app tlsr9518adk80d text 557630 557632 2 0.0
lighting-app tlsr9518adk80d text 574322 574324 2 0.0
Decreases (2 builds for cc13x2_26x2, cyw30739)
platform target config section 09f3e4a a7444df change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 688495 688487 -8 -0.0
.text 589100 589092 -8 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614274 614266 -8 -0.0
.app_xip_area 471884 471876 -8 -0.0
Full report (23 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 09f3e4a a7444df change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657531 657531 0 0.0
(read/write) 193284 193284 0 0.0
.bss 73708 73708 0 0.0
.data 3380 3380 0 0.0
.rodata 86883 86883 0 0.0
.text 570336 570336 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646063 646063 0 0.0
(read/write) 157260 157260 0 0.0
.bss 72988 72988 0 0.0
.data 3356 3356 0 0.0
.rodata 90191 90191 0 0.0
.text 555552 555552 0 0.0
lock-ftd LP_CC2652R7 (read only) 688495 688487 -8 -0.0
(read/write) 152424 152432 8 0.0
.bss 70700 70700 0 0.0
.data 3280 3280 0 0.0
.rodata 98911 98911 0 0.0
.text 589100 589092 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 637903 637903 0 0.0
(read/write) 143832 143832 0 0.0
.bss 66436 66436 0 0.0
.data 3280 3280 0 0.0
.rodata 98791 98791 0 0.0
.text 538620 538620 0 0.0
pump-app LP_CC2652R7 (read only) 669719 669719 0 0.0
(read/write) 172088 172088 0 0.0
.bss 70820 70820 0 0.0
.data 3316 3316 0 0.0
.rodata 87007 87007 0 0.0
.text 582228 582228 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660443 660443 0 0.0
(read/write) 181492 181492 0 0.0
.bss 70948 70948 0 0.0
.data 3276 3276 0 0.0
.rodata 84931 84931 0 0.0
.text 575028 575028 0 0.0
shell LP_CC2652R7 (read only) 686890 686890 0 0.0
(read/write) 159420 159420 0 0.0
.bss 76004 76004 0 0.0
.data 3384 3384 0 0.0
.rodata 109442 109442 0 0.0
.text 577136 577136 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 611090 611090 0 0.0
.app_xip_area 467780 467780 0 0.0
.bss 86232 86232 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608174 608182 8 0.0
.app_xip_area 464720 464728 8 0.0
.bss 86408 86408 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614274 614266 -8 -0.0
.app_xip_area 471884 471876 -8 -0.0
.bss 85400 85400 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 657192 657192 0 0.0
.bss 68708 68708 0 0.0
.data 2028 2028 0 0.0
.text 580656 580656 0 0.0
lock k32w061+release (read/write) 718848 718848 0 0.0
.bss 69140 69140 0 0.0
.data 2000 2000 0 0.0
.text 641908 641908 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9513132 9513132 0 0.0
(read/write) 685601 685601 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623104 623104 0 0.0
.dynamic 528 528 0 0.0
.got 14904 14904 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468156 468156 0 0.0
.text 7476692 7476692 0 0.0
thermostat-no-ble arm64 (read only) 2563180 2563180 0 0.0
(read/write) 191505 191505 0 0.0
.bss 99361 99361 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 82416 82416 0 0.0
.dynamic 528 528 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 162828 162828 0 0.0
.text 2162592 2162592 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434912 2434912 0 0.0
.bss 208148 208148 0 0.0
.data 5864 5864 0 0.0
.text 1397556 1397556 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196567 1196567 0 0.0
bss 141554 141554 0 0.0
rodata 155456 155456 0 0.0
text 820700 820700 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144615 1144615 0 0.0
bss 140794 140794 0 0.0
rodata 131984 131984 0 0.0
text 793020 793020 0 0.0
p6 all-clusters-app default (read/write) 2549968 2549968 0 0.0
.bss 143344 143344 0 0.0
.data 2800 2800 0 0.0
.text 1508232 1508232 0 0.0
all-clusters-minimal-app default (read/write) 2495912 2495912 0 0.0
.bss 142608 142608 0 0.0
.data 2776 2776 0 0.0
.text 1454176 1454176 0 0.0
light-app default (read/write) 2426776 2426776 0 0.0
.bss 134688 134688 0 0.0
.data 2624 2624 0 0.0
.text 1385040 1385040 0 0.0
lock-app default (read/write) 2447192 2447192 0 0.0
.bss 134512 134512 0 0.0
.data 2600 2600 0 0.0
.text 1405456 1405456 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786732 786732 0 0.0
bss 69836 69836 0 0.0
noinit 40416 40416 0 0.0
text 557630 557632 2 0.0
lighting-app tlsr9518adk80d (read/write) 806720 806720 0 0.0
bss 70088 70088 0 0.0
noinit 40416 40416 0 0.0
text 574322 574324 2 0.0

@vivien-apple vivien-apple force-pushed the TV_CASTING_APP_ShareMoreCode branch from a7444df to 7be94f1 Compare June 15, 2022 09:16
@vivien-apple
[chip-tv-casting-app] Update the TV casting app in order to share mor…
dea9d93 
…e code with chip-tool when it comes to commands parsing
@vivien-apple vivien-apple force-pushed the TV_CASTING_APP_ShareMoreCode branch from 7be94f1 to dea9d93 Compare June 15, 2022 09:43
@github-actions
Copy link

github-actions bot commented Jun 15, 2022 •
edited
Loading

PR #19575: Size comparison from 09f3e4a to dea9d93

Increases (1 build for cc13x2_26x2)
platform target config section 09f3e4a dea9d93 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 193284 193292 8 0.0
Decreases (2 builds for cc13x2_26x2, telink)
platform target config section 09f3e4a dea9d93 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657531 657523 -8 -0.0
.text 570336 570328 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 806720 806712 -8 -0.0
text 574322 574320 -2 -0.0
Full report (28 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 09f3e4a dea9d93 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657531 657523 -8 -0.0
(read/write) 193284 193292 8 0.0
.bss 73708 73708 0 0.0
.data 3380 3380 0 0.0
.rodata 86883 86883 0 0.0
.text 570336 570328 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646063 646063 0 0.0
(read/write) 157260 157260 0 0.0
.bss 72988 72988 0 0.0
.data 3356 3356 0 0.0
.rodata 90191 90191 0 0.0
.text 555552 555552 0 0.0
lock-ftd LP_CC2652R7 (read only) 688495 688495 0 0.0
(read/write) 152424 152424 0 0.0
.bss 70700 70700 0 0.0
.data 3280 3280 0 0.0
.rodata 98911 98911 0 0.0
.text 589100 589100 0 0.0
lock-mtd LP_CC2652R7 (read only) 637903 637903 0 0.0
(read/write) 143832 143832 0 0.0
.bss 66436 66436 0 0.0
.data 3280 3280 0 0.0
.rodata 98791 98791 0 0.0
.text 538620 538620 0 0.0
pump-app LP_CC2652R7 (read only) 669719 669719 0 0.0
(read/write) 172088 172088 0 0.0
.bss 70820 70820 0 0.0
.data 3316 3316 0 0.0
.rodata 87007 87007 0 0.0
.text 582228 582228 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660443 660443 0 0.0
(read/write) 181492 181492 0 0.0
.bss 70948 70948 0 0.0
.data 3276 3276 0 0.0
.rodata 84931 84931 0 0.0
.text 575028 575028 0 0.0
shell LP_CC2652R7 (read only) 686890 686890 0 0.0
(read/write) 159420 159420 0 0.0
.bss 76004 76004 0 0.0
.data 3384 3384 0 0.0
.rodata 109442 109442 0 0.0
.text 577136 577136 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 611090 611090 0 0.0
.app_xip_area 467780 467780 0 0.0
.bss 86232 86232 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608174 608174 0 0.0
.app_xip_area 464720 464720 0 0.0
.bss 86408 86408 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614274 614274 0 0.0
.app_xip_area 471884 471884 0 0.0
.bss 85400 85400 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920548 920548 0 0.0
(read/write) 132396 132396 0 0.0
.bss 130280 130280 0 0.0
.data 2116 2116 0 0.0
.text 920540 920540 0 0.0
BRD4161A+rpc (read only) 956188 956188 0 0.0
(read/write) 149272 149272 0 0.0
.bss 146952 146952 0 0.0
.data 2320 2320 0 0.0
.text 956180 956180 0 0.0
BRD4161A+rs911x (read only) 795648 795648 0 0.0
(read/write) 128676 128676 0 0.0
.bss 126548 126548 0 0.0
.data 2124 2124 0 0.0
.text 795640 795640 0 0.0
lock-app BRD4161A+wf200 (read only) 963576 963576 0 0.0
(read/write) 129012 129012 0 0.0
.bss 126924 126924 0 0.0
.data 2088 2088 0 0.0
.text 963568 963568 0 0.0
window-app BRD4161A (read only) 905420 905420 0 0.0
(read/write) 132468 132468 0 0.0
.bss 130360 130360 0 0.0
.data 2108 2108 0 0.0
.text 905412 905412 0 0.0
k32w light k32w061+release (read/write) 657192 657192 0 0.0
.bss 68708 68708 0 0.0
.data 2028 2028 0 0.0
.text 580656 580656 0 0.0
lock k32w061+release (read/write) 718848 718848 0 0.0
.bss 69140 69140 0 0.0
.data 2000 2000 0 0.0
.text 641908 641908 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9513132 9513132 0 0.0
(read/write) 685601 685601 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623104 623104 0 0.0
.dynamic 528 528 0 0.0
.got 14904 14904 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468156 468156 0 0.0
.text 7476692 7476692 0 0.0
thermostat-no-ble arm64 (read only) 2563180 2563180 0 0.0
(read/write) 191505 191505 0 0.0
.bss 99361 99361 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 82416 82416 0 0.0
.dynamic 528 528 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 162828 162828 0 0.0
.text 2162592 2162592 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434912 2434912 0 0.0
.bss 208148 208148 0 0.0
.data 5864 5864 0 0.0
.text 1397556 1397556 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196567 1196567 0 0.0
bss 141554 141554 0 0.0
rodata 155456 155456 0 0.0
text 820700 820700 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144615 1144615 0 0.0
bss 140794 140794 0 0.0
rodata 131984 131984 0 0.0
text 793020 793020 0 0.0
p6 all-clusters-app default (read/write) 2549968 2549968 0 0.0
.bss 143344 143344 0 0.0
.data 2800 2800 0 0.0
.text 1508232 1508232 0 0.0
all-clusters-minimal-app default (read/write) 2495912 2495912 0 0.0
.bss 142608 142608 0 0.0
.data 2776 2776 0 0.0
.text 1454176 1454176 0 0.0
light-app default (read/write) 2426776 2426776 0 0.0
.bss 134688 134688 0 0.0
.data 2624 2624 0 0.0
.text 1385040 1385040 0 0.0
lock-app default (read/write) 2447192 2447192 0 0.0
.bss 134512 134512 0 0.0
.data 2600 2600 0 0.0
.text 1405456 1405456 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786732 786732 0 0.0
bss 69836 69836 0 0.0
noinit 40416 40416 0 0.0
text 557630 557630 0 0.0
lighting-app tlsr9518adk80d (read/write) 806720 806712 -8 -0.0
bss 70088 70088 0 0.0
noinit 40416 40416 0 0.0
text 574322 574320 -2 -0.0

@andy31415 andy31415 merged commit c47353f into project-chip:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@andy31415 andy31415 Awaiting requested review from andy31415

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees

@vivien-apple vivien-apple

Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @andy31415 @woody-apple @bzbarsky-apple