-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add multiple writes in a single transaction support #19566
Merged
andy31415
merged 4 commits into
project-chip:master
from
vivien-apple:ChipTool_SupportMultipleWrites
Jun 15, 2022
Merged
[chip-tool] Add multiple writes in a single transaction support #19566
andy31415
merged 4 commits into
project-chip:master
from
vivien-apple:ChipTool_SupportMultipleWrites
Jun 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
mspang and
rgoliver
June 14, 2022 14:11
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
June 14, 2022 14:11
vivien-apple
changed the title
Chip tool support multiple writes
[chip-tool] Add multiple writes in a single transaction support
Jun 14, 2022
PR #19566: Size comparison from 3ffd066 to fc234e8 Increases (1 build for telink)
Decreases (2 builds for esp32, telink)
Full report (28 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
|
This PR depends on #19575 since the |
woody-apple
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking tooling updates
vivien-apple
force-pushed
the
ChipTool_SupportMultipleWrites
branch
2 times, most recently
from
June 15, 2022 09:15
48caaa9
to
62dfa8f
Compare
…e code with chip-tool when it comes to commands parsing
vivien-apple
force-pushed
the
ChipTool_SupportMultipleWrites
branch
from
June 15, 2022 09:43
62dfa8f
to
dc5012a
Compare
I have included #19575 in this PR. This is not in order to land it with it, but just to get the code to compile and see if CI is happy. |
andy31415
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip-tool
does not supports multiple writes in a single interaction.Change overview
./out/debug/standalone/chip-tool onoff write on-time 13 0x12344321 1,2,3
./out/debug/standalone/chip-tool onoff write-by-id 0x4001, 0x4001 '19',17' 0x12344321 1
./out/debug/standalone/chip-tool any write-by-id 0x6,0x7 0x4001,0x0 '5','false' 0x12344321 1,1
fixes #19139