-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Add a command line option to generate the CSR with an existing keypair instead of a new one #19528
Merged
woody-apple
merged 3 commits into
project-chip:master
from
vivien-apple:ExamplesLinux_ModifyCSRKeyPair
Jun 15, 2022
Merged
[Testing] Add a command line option to generate the CSR with an existing keypair instead of a new one #19528
woody-apple
merged 3 commits into
project-chip:master
from
vivien-apple:ExamplesLinux_ModifyCSRKeyPair
Jun 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
June 13, 2022 13:55
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 13, 2022 13:55
2 tasks
PR #19528: Size comparison from 8443529 to 16e4478 Increases above 0.2%:
Increases (13 builds for linux, telink)
Full report (29 builds for cc13x2_26x2, esp32, k32w, linux, mbed, nrfconnect, telink)
|
tcarmelveilleux
approved these changes
Jun 13, 2022
emargolis
approved these changes
Jun 14, 2022
vivien-apple
force-pushed
the
ExamplesLinux_ModifyCSRKeyPair
branch
from
June 14, 2022 14:50
16e4478
to
b1bf6c1
Compare
PR #19528: Size comparison from b9e1102 to b1bf6c1 Increases above 0.2%:
Increases (13 builds for cc13x2_26x2, linux)
Decreases (3 builds for cc13x2_26x2, nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…instead of a new one
…ux by a custom one for testing purposes
vivien-apple
force-pushed
the
ExamplesLinux_ModifyCSRKeyPair
branch
from
June 14, 2022 19:17
b1bf6c1
to
ac76019
Compare
PR #19528: Size comparison from b006bab to ac76019 Increases above 0.2%:
Increases (12 builds for linux, nrfconnect, telink)
Decreases (1 build for telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
approved these changes
Jun 15, 2022
woody-apple
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The last part of #14404 requires to use a CSR that contains an already existing public key.
This PR add the ability to test this last step by reusing the keypair of the previous commissioned fabric. It means that the test needs to have commissioned one fabric first.
Change overview
Warning: The first 2 commits of this PR are #19461 which contains all the other steps required by 14404. Please ignore those while reviewing or do that in #19461 ;)