Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all-clusters-app] Add some command line options to modify what is returned by the CSRResponse #19461

Merged
merged 2 commits into from
Jun 14, 2022
Merged

[all-clusters-app] Add some command line options to modify what is returned by the CSRResponse #19461

merged 2 commits into from
Jun 14, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

#14404 requires to customise the CSRResponse. There are different ways to do that but a non-invasive approach is to just specialise the template that fills in the specific command data and get it to be modified on the fly.
The reason to choose this approach is that it let us change the content of the TLV such that it does not match what the generated struct expects.
For example in the case of CSRResponse, the generated struct expects 2 byte spans, but depending on the configuration this PR changes it to one byte span and one boolean.

Change overview

  • Add some mechanism to the all-clusters-app to customise the CSRResponse
  • Add some additional checks into the default device attestation verifier such that it enforces that the length of attestationElements and nocsrElements are not bigger than RESP_MAX (900 bytes) since this is defined in the spec.

@vivien-apple vivien-apple self-assigned this Jun 10, 2022
@vivien-apple vivien-apple mentioned this pull request Jun 10, 2022
Closed
2 tasks
@vivien-apple vivien-apple force-pushed the ChipAllClustersApp_ModifyCSRResponse branch from ae7542a to 7f8ee3b Compare June 10, 2022 14:56
@vivien-apple vivien-apple force-pushed the ChipAllClustersApp_ModifyCSRResponse branch from 7f8ee3b to 43d7103 Compare June 10, 2022 15:40
@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19461: Size comparison from 54da3fd to 43d7103

Increases above 0.2%:

platform target config section 54da3fd 43d7103 change % change
linux all-clusters-app debug .data 2048 2144 96 4.7
.init_array 1032 1040 8 0.8
.rodata 257341 258365 1024 0.4
Increases (7 builds for linux, telink)
platform target config section 54da3fd 43d7103 change % change
linux all-clusters-app debug (read only) 2907737 2912713 4976 0.2
(read/write) 188240 188344 104 0.1
.data 2048 2144 96 4.7
.init_array 1032 1040 8 0.8
.rodata 257341 258365 1024 0.4
.text 2475346 2479106 3760 0.2
chip-tool debug (read only) 9816405 9816581 176 0.0
.text 7868917 7869093 176 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564036 9564212 176 0.0
.text 7519188 7519364 176 0.0
tv-app debug (read only) 3051185 3051361 176 0.0
.text 2622690 2622866 176 0.0
tv-casting-app debug (read only) 5350353 5350513 160 0.0
.text 4656722 4656882 160 0.0
telink light-switch-app tlsr9518adk80d text 556602 556604 2 0.0
lighting-app tlsr9518adk80d text 573318 573320 2 0.0
Decreases (2 builds for esp32, nrfconnect)
platform target config section 54da3fd 43d7103 change % change
esp32 all-clusters-app c3devkit (read only) 1010926 1010924 -2 -0.0
.flash.text 1010926 1010924 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143351 1143335 -16 -0.0
text 791928 791924 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 54da3fd 43d7103 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656295 656295 0 0.0
(read/write) 194584 194584 0 0.0
.bss 73772 73772 0 0.0
.data 3416 3416 0 0.0
.rodata 86511 86511 0 0.0
.text 569472 569472 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644779 644779 0 0.0
(read/write) 157268 157268 0 0.0
.bss 72996 72996 0 0.0
.data 3356 3356 0 0.0
.rodata 90019 90019 0 0.0
.text 554440 554440 0 0.0
lock-ftd LP_CC2652R7 (read only) 687659 687659 0 0.0
(read/write) 154292 154292 0 0.0
.bss 71732 71732 0 0.0
.data 3280 3280 0 0.0
.rodata 98843 98843 0 0.0
.text 588332 588332 0 0.0
lock-mtd LP_CC2652R7 (read only) 637059 637059 0 0.0
(read/write) 144864 144864 0 0.0
.bss 67468 67468 0 0.0
.data 3280 3280 0 0.0
.rodata 98723 98723 0 0.0
.text 537844 537844 0 0.0
pump-app LP_CC2652R7 (read only) 669011 669011 0 0.0
(read/write) 173852 173852 0 0.0
.bss 71876 71876 0 0.0
.data 3316 3316 0 0.0
.rodata 86955 86955 0 0.0
.text 581572 581572 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659575 659575 0 0.0
(read/write) 183392 183392 0 0.0
.bss 71980 71980 0 0.0
.data 3276 3276 0 0.0
.rodata 84855 84855 0 0.0
.text 574236 574236 0 0.0
shell LP_CC2652R7 (read only) 686422 686422 0 0.0
(read/write) 159952 159952 0 0.0
.bss 76068 76068 0 0.0
.data 3420 3420 0 0.0
.rodata 109582 109582 0 0.0
.text 576528 576528 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606450 606450 0 0.0
.app_xip_area 464964 464964 0 0.0
.bss 84416 84416 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603550 603550 0 0.0
.app_xip_area 461920 461920 0 0.0
.bss 84592 84592 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611270 611270 0 0.0
.app_xip_area 470712 470712 0 0.0
.bss 83600 83600 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919200 919200 0 0.0
(read/write) 133424 133424 0 0.0
.bss 131312 131312 0 0.0
.data 2112 2112 0 0.0
.text 919192 919192 0 0.0
BRD4161A+rpc (read only) 953380 953380 0 0.0
(read/write) 150116 150116 0 0.0
.bss 147800 147800 0 0.0
.data 2316 2316 0 0.0
.text 953372 953372 0 0.0
BRD4161A+rs911x (read only) 794276 794276 0 0.0
(read/write) 129708 129708 0 0.0
.bss 127588 127588 0 0.0
.data 2120 2120 0 0.0
.text 794268 794268 0 0.0
lock-app BRD4161A+wf200 (read only) 962636 962636 0 0.0
(read/write) 130052 130052 0 0.0
.bss 127964 127964 0 0.0
.data 2088 2088 0 0.0
.text 962628 962628 0 0.0
window-app BRD4161A (read only) 904256 904256 0 0.0
(read/write) 133504 133504 0 0.0
.bss 131392 131392 0 0.0
.data 2108 2108 0 0.0
.text 904248 904248 0 0.0
esp32 all-clusters-app c3devkit (read only) 1010926 1010924 -2 -0.0
(read/write) 1482754 1482754 0 0.0
.dram0.bss 69400 69400 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213216 213216 0 0.0
.flash.text 1010926 1010924 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065355 1065355 0 0.0
(read/write) 484864 484864 0 0.0
.dram0.bss 74920 74920 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243724 243724 0 0.0
.flash.text 1059971 1059971 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657248 657248 0 0.0
.bss 69732 69732 0 0.0
.data 2028 2028 0 0.0
.text 579688 579688 0 0.0
lock k32w061+release (read/write) 718820 718820 0 0.0
.bss 70164 70164 0 0.0
.data 2000 2000 0 0.0
.text 640856 640856 0 0.0
linux all-clusters-app debug (read only) 2907737 2912713 4976 0.2
(read/write) 188240 188344 104 0.1
.bss 95776 95776 0 0.0
.data 2048 2144 96 4.7
.data.rel.ro 84200 84200 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1040 8 0.8
.rodata 257341 258365 1024 0.4
.text 2475346 2479106 3760 0.2
all-clusters-minimal-app debug (read only) 2769281 2769281 0 0.0
(read/write) 179856 179856 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76824 76824 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258685 258685 0 0.0
.text 2337554 2337554 0 0.0
bridge-app debug+rpc (read only) 2247641 2247641 0 0.0
(read/write) 158688 158688 0 0.0
.bss 82944 82944 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66200 66200 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191104 191104 0 0.0
.text 1896626 1896626 0 0.0
chip-tool debug (read only) 9816405 9816581 176 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506869 506869 0 0.0
.text 7868917 7869093 176 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564036 9564212 176 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468756 468756 0 0.0
.text 7519188 7519364 176 0.0
lighting-app debug+rpc (read only) 2497553 2497553 0 0.0
(read/write) 163384 163384 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71128 71128 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207176 207176 0 0.0
.text 2122258 2122258 0 0.0
lock-app debug (read only) 2443553 2443553 0 0.0
(read/write) 158456 158456 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68088 68088 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221256 221256 0 0.0
.text 2059170 2059170 0 0.0
ota-provider-app debug (read only) 2281817 2281817 0 0.0
(read/write) 152656 152656 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62424 62424 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197400 197400 0 0.0
.text 1923298 1923298 0 0.0
ota-requestor-app debug (read only) 2329345 2329345 0 0.0
(read/write) 155440 155440 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64344 64344 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199552 199552 0 0.0
.text 1964834 1964834 0 0.0
shell debug (read only) 2599753 2599753 0 0.0
(read/write) 219384 219384 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77664 77664 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229842 229842 0 0.0
.text 2210690 2210690 0 0.0
thermostat-no-ble arm64 (read only) 2557708 2557708 0 0.0
(read/write) 191329 191329 0 0.0
.bss 99361 99361 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82336 82336 0 0.0
.dynamic 528 528 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161316 161316 0 0.0
.text 2158880 2158880 0 0.0
tv-app debug (read only) 3051185 3051361 176 0.0
(read/write) 289800 289800 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78472 78472 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242784 242784 0 0.0
.text 2622690 2622866 176 0.0
tv-casting-app debug (read only) 5350353 5350513 160 0.0
(read/write) 232248 232248 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135472 135472 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342432 342432 0 0.0
.text 4656722 4656882 160 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2433320 2433320 0 0.0
.bss 208980 208980 0 0.0
.data 5896 5896 0 0.0
.text 1395964 1395964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195719 1195719 0 0.0
bss 141583 141583 0 0.0
rodata 155296 155296 0 0.0
text 819852 819852 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143351 1143335 -16 -0.0
bss 140800 140800 0 0.0
rodata 131808 131808 0 0.0
text 791928 791924 -4 -0.0
p6 all-clusters-app default (read/write) 2549208 2549208 0 0.0
.bss 143408 143408 0 0.0
.data 2832 2832 0 0.0
.text 1507472 1507472 0 0.0
all-clusters-minimal-app default (read/write) 2494008 2494008 0 0.0
.bss 142616 142616 0 0.0
.data 2776 2776 0 0.0
.text 1452272 1452272 0 0.0
light-app default (read/write) 2425440 2425440 0 0.0
.bss 135728 135728 0 0.0
.data 2624 2624 0 0.0
.text 1383704 1383704 0 0.0
lock-app default (read/write) 2445848 2445848 0 0.0
.bss 135552 135552 0 0.0
.data 2600 2600 0 0.0
.text 1404112 1404112 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786656 786656 0 0.0
bss 70860 70860 0 0.0
noinit 40416 40416 0 0.0
text 556602 556604 2 0.0
lighting-app tlsr9518adk80d (read/write) 806668 806668 0 0.0
bss 71120 71120 0 0.0
noinit 40416 40416 0 0.0
text 573318 573320 2 0.0

@vivien-apple vivien-apple force-pushed the ChipAllClustersApp_ModifyCSRResponse branch from 43d7103 to 8b9f6ac Compare June 13, 2022 08:12
@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

PR #19461: Size comparison from c1e1d01 to 8b9f6ac

Increases above 0.2%:

platform target config section c1e1d01 8b9f6ac change % change
linux thermostat-no-ble arm64 .data 1560 1672 112 7.2
.rodata 161332 162644 1312 0.8
Increases (5 builds for efr32, esp32, linux, telink)
platform target config section c1e1d01 8b9f6ac change % change
efr32 lock-app BRD4161A+wf200 (read only) 962652 962668 16 0.0
.text 962644 962660 16 0.0
esp32 all-clusters-app c3devkit (read only) 1010982 1010984 2 0.0
.flash.text 1010982 1010984 2 0.0
linux thermostat-no-ble arm64 (read only) 2557916 2562156 4240 0.2
(read/write) 191409 191521 112 0.1
.data 1560 1672 112 7.2
.rodata 161332 162644 1312 0.8
.text 2158912 2161664 2752 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786716 786724 8 0.0
text 556632 556634 2 0.0
lighting-app tlsr9518adk80d text 573346 573348 2 0.0
Decreases (1 build for cyw30739)
platform target config section c1e1d01 8b9f6ac change % change
cyw30739 lock cyw930739m2evb_01 (read/write) 603678 603670 -8 -0.0
.app_xip_area 462032 462024 -8 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c1e1d01 8b9f6ac change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656343 656343 0 0.0
(read/write) 194544 194544 0 0.0
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 86527 86527 0 0.0
.text 569504 569504 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 644835 0 0.0
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554480 554480 0 0.0
lock-ftd LP_CC2652R7 (read only) 687707 687707 0 0.0
(read/write) 154252 154252 0 0.0
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588364 588364 0 0.0
lock-mtd LP_CC2652R7 (read only) 637115 637115 0 0.0
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 537884 0 0.0
pump-app LP_CC2652R7 (read only) 669083 669083 0 0.0
(read/write) 173788 173788 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581620 581620 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659655 659655 0 0.0
(read/write) 183320 183320 0 0.0
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574292 0 0.0
shell LP_CC2652R7 (read only) 686470 686470 0 0.0
(read/write) 159912 159912 0 0.0
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 109598 109598 0 0.0
.text 576560 576560 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606578 606578 0 0.0
.app_xip_area 465076 465076 0 0.0
.bss 84432 84432 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603678 603670 -8 -0.0
.app_xip_area 462032 462024 -8 -0.0
.bss 84608 84608 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 611382 0 0.0
.app_xip_area 470808 470808 0 0.0
.bss 83616 83616 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919248 919248 0 0.0
(read/write) 133432 133432 0 0.0
.bss 131320 131320 0 0.0
.data 2112 2112 0 0.0
.text 919240 919240 0 0.0
BRD4161A+rpc (read only) 953412 953412 0 0.0
(read/write) 150124 150124 0 0.0
.bss 147808 147808 0 0.0
.data 2316 2316 0 0.0
.text 953404 953404 0 0.0
BRD4161A+rs911x (read only) 794364 794364 0 0.0
(read/write) 129716 129716 0 0.0
.bss 127596 127596 0 0.0
.data 2120 2120 0 0.0
.text 794356 794356 0 0.0
lock-app BRD4161A+wf200 (read only) 962652 962668 16 0.0
(read/write) 130060 130060 0 0.0
.bss 127972 127972 0 0.0
.data 2088 2088 0 0.0
.text 962644 962660 16 0.0
window-app BRD4161A (read only) 904304 904304 0 0.0
(read/write) 133512 133512 0 0.0
.bss 131400 131400 0 0.0
.data 2108 2108 0 0.0
.text 904296 904296 0 0.0
esp32 all-clusters-app c3devkit (read only) 1010982 1010984 2 0.0
(read/write) 1482794 1482794 0 0.0
.dram0.bss 69416 69416 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213240 213240 0 0.0
.flash.text 1010982 1010984 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065439 1065439 0 0.0
(read/write) 484896 484896 0 0.0
.dram0.bss 74936 74936 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243740 243740 0 0.0
.flash.text 1060055 1060055 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657264 657264 0 0.0
.bss 69748 69748 0 0.0
.data 2028 2028 0 0.0
.text 579688 579688 0 0.0
lock k32w061+release (read/write) 718860 718860 0 0.0
.bss 70180 70180 0 0.0
.data 2000 2000 0 0.0
.text 640880 640880 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9563860 0 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468788 468788 0 0.0
.text 7518980 7518980 0 0.0
thermostat-no-ble arm64 (read only) 2557916 2562156 4240 0.2
(read/write) 191409 191521 112 0.1
.bss 99377 99377 0 0.0
.data 1560 1672 112 7.2
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161332 162644 1312 0.8
.text 2158912 2161664 2752 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2432808 0 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1395452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195771 1195771 0 0.0
bss 141591 141591 0 0.0
rodata 155316 155316 0 0.0
text 819892 819892 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1143531 0 0.0
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 791972 791972 0 0.0
p6 all-clusters-app default (read/write) 2549328 2549328 0 0.0
.bss 143416 143416 0 0.0
.data 2832 2832 0 0.0
.text 1507592 1507592 0 0.0
all-clusters-minimal-app default (read/write) 2494128 2494128 0 0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452392 1452392 0 0.0
light-app default (read/write) 2425576 2425576 0 0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383840 1383840 0 0.0
lock-app default (read/write) 2445968 2445968 0 0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404232 1404232 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786716 786724 8 0.0
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556632 556634 2 0.0
lighting-app tlsr9518adk80d (read/write) 806728 806728 0 0.0
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573346 573348 2 0.0

@vivien-apple vivien-apple force-pushed the ChipAllClustersApp_ModifyCSRResponse branch from 8b9f6ac to 11eca51 Compare June 13, 2022 13:49
@vivien-apple vivien-apple mentioned this pull request Jun 13, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

PR #19461: Size comparison from 8443529 to 11eca51

Increases above 0.2%:

platform target config section 8443529 11eca51 change % change
linux all-clusters-app debug .data 2048 2144 96 4.7
.rodata 258205 259325 1120 0.4
all-clusters-minimal-app debug .data 1920 2016 96 5.0
.rodata 258621 259741 1120 0.4
bridge-app debug+rpc (read only) 2247553 2253097 5544 0.2
.data 3760 3856 96 2.6
.rodata 191040 192576 1536 0.8
.text 1896530 1900370 3840 0.2
lighting-app debug+rpc (read only) 2497465 2502977 5512 0.2
.data 2064 2160 96 4.7
.rodata 207144 208680 1536 0.7
lock-app debug (read only) 2443465 2448897 5432 0.2
.data 1552 1648 96 6.2
.rodata 221192 222728 1536 0.7
ota-provider-app debug (read only) 2281729 2287273 5544 0.2
.data 1784 1880 96 5.4
.rodata 197336 198872 1536 0.8
ota-requestor-app debug (read only) 2329289 2334833 5544 0.2
.data 1976 2072 96 4.9
.rodata 199520 201056 1536 0.8
thermostat-no-ble arm64 .data 1560 1672 112 7.2
.rodata 161332 162644 1312 0.8
tv-app debug .data 4688 4784 96 2.0
.rodata 242720 244224 1504 0.6
tv-casting-app debug .data 2480 2576 96 3.9
.rodata 342368 343904 1536 0.4
Increases (13 builds for cyw30739, linux)
platform target config section 8443529 11eca51 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606554 606562 8 0.0
.app_xip_area 465052 465060 8 0.0
linux all-clusters-app debug (read only) 2923761 2928777 5016 0.2
(read/write) 188496 188592 96 0.1
.data 2048 2144 96 4.7
.rodata 258205 259325 1120 0.4
.text 2489906 2493634 3728 0.1
all-clusters-minimal-app debug (read only) 2769193 2774193 5000 0.2
(read/write) 179888 179984 96 0.1
.data 1920 2016 96 5.0
.rodata 258621 259741 1120 0.4
.text 2337458 2341170 3712 0.2
bridge-app debug+rpc (read only) 2247553 2253097 5544 0.2
(read/write) 158752 158848 96 0.1
.data 3760 3856 96 2.6
.rodata 191040 192576 1536 0.8
.text 1896530 1900370 3840 0.2
chip-tool debug (read only) 9815973 9816149 176 0.0
.text 7868549 7868725 176 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9564052 192 0.0
.text 7518980 7519172 192 0.0
lighting-app debug+rpc (read only) 2497465 2502977 5512 0.2
(read/write) 163416 163544 128 0.1
.bss 84288 84320 32 0.0
.data 2064 2160 96 4.7
.rodata 207144 208680 1536 0.7
.text 2122130 2125938 3808 0.2
lock-app debug (read only) 2443465 2448897 5432 0.2
(read/write) 158488 158584 96 0.1
.data 1552 1648 96 6.2
.rodata 221192 222728 1536 0.7
.text 2059074 2062802 3728 0.2
ota-provider-app debug (read only) 2281729 2287273 5544 0.2
(read/write) 152688 152784 96 0.1
.data 1784 1880 96 5.4
.rodata 197336 198872 1536 0.8
.text 1923202 1927042 3840 0.2
ota-requestor-app debug (read only) 2329289 2334833 5544 0.2
(read/write) 155504 155600 96 0.1
.data 1976 2072 96 4.9
.rodata 199520 201056 1536 0.8
.text 1964738 1968578 3840 0.2
thermostat-no-ble arm64 (read only) 2557916 2562156 4240 0.2
(read/write) 191409 191521 112 0.1
.data 1560 1672 112 7.2
.rodata 161332 162644 1312 0.8
.text 2158912 2161664 2752 0.1
tv-app debug (read only) 3050873 3056561 5688 0.2
(read/write) 289864 289960 96 0.0
.data 4688 4784 96 2.0
.rodata 242720 244224 1504 0.6
.text 2622370 2626386 4016 0.2
tv-casting-app debug (read only) 5349977 5355681 5704 0.1
(read/write) 232312 232408 96 0.0
.data 2480 2576 96 3.9
.rodata 342368 343904 1536 0.4
.text 4656338 4660338 4000 0.1
Decreases (3 builds for esp32, k32w, nrfconnect)
platform target config section 8443529 11eca51 change % change
esp32 all-clusters-app c3devkit (read only) 1012670 1012666 -4 -0.0
.flash.text 1012670 1012666 -4 -0.0
k32w light k32w061+release (read/write) 657248 657232 -16 -0.0
.text 579672 579656 -16 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 791972 791968 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8443529 11eca51 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658279 658279 0 0.0
(read/write) 192608 192608 0 0.0
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 87007 87007 0 0.0
.text 570960 570960 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 644835 0 0.0
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554480 554480 0 0.0
lock-ftd LP_CC2652R7 (read only) 687707 687707 0 0.0
(read/write) 154252 154252 0 0.0
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588364 588364 0 0.0
lock-mtd LP_CC2652R7 (read only) 637115 637115 0 0.0
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 537884 0 0.0
pump-app LP_CC2652R7 (read only) 669083 669083 0 0.0
(read/write) 173788 173788 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581620 581620 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659655 659655 0 0.0
(read/write) 183320 183320 0 0.0
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574292 0 0.0
shell LP_CC2652R7 (read only) 688430 688430 0 0.0
(read/write) 157952 157952 0 0.0
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 110078 110078 0 0.0
.text 578040 578040 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606554 606562 8 0.0
.app_xip_area 465052 465060 8 0.0
.bss 84432 84432 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603678 603678 0 0.0
.app_xip_area 462032 462032 0 0.0
.bss 84608 84608 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 611382 0 0.0
.app_xip_area 470808 470808 0 0.0
.bss 83616 83616 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919400 919400 0 0.0
(read/write) 133440 133440 0 0.0
.bss 131320 131320 0 0.0
.data 2116 2116 0 0.0
.text 919392 919392 0 0.0
BRD4161A+rpc (read only) 953572 953572 0 0.0
(read/write) 150128 150128 0 0.0
.bss 147808 147808 0 0.0
.data 2320 2320 0 0.0
.text 953564 953564 0 0.0
BRD4161A+rs911x (read only) 794524 794524 0 0.0
(read/write) 129720 129720 0 0.0
.bss 127596 127596 0 0.0
.data 2124 2124 0 0.0
.text 794516 794516 0 0.0
lock-app BRD4161A+wf200 (read only) 962668 962668 0 0.0
(read/write) 130060 130060 0 0.0
.bss 127972 127972 0 0.0
.data 2088 2088 0 0.0
.text 962660 962660 0 0.0
window-app BRD4161A (read only) 904304 904304 0 0.0
(read/write) 133512 133512 0 0.0
.bss 131400 131400 0 0.0
.data 2108 2108 0 0.0
.text 904296 904296 0 0.0
esp32 all-clusters-app c3devkit (read only) 1012670 1012666 -4 -0.0
(read/write) 1483266 1483266 0 0.0
.dram0.bss 69408 69408 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213728 213728 0 0.0
.flash.text 1012670 1012666 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1066979 1066979 0 0.0
(read/write) 485376 485376 0 0.0
.dram0.bss 74936 74936 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 244220 244220 0 0.0
.flash.text 1061595 1061595 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657248 657232 -16 -0.0
.bss 69748 69748 0 0.0
.data 2028 2028 0 0.0
.text 579672 579656 -16 -0.0
lock k32w061+release (read/write) 718860 718860 0 0.0
.bss 70180 70180 0 0.0
.data 2000 2000 0 0.0
.text 640880 640880 0 0.0
linux all-clusters-app debug (read only) 2923761 2928777 5016 0.2
(read/write) 188496 188592 96 0.1
.bss 95776 95776 0 0.0
.data 2048 2144 96 4.7
.data.rel.ro 84456 84456 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258205 259325 1120 0.4
.text 2489906 2493634 3728 0.1
all-clusters-minimal-app debug (read only) 2769193 2774193 5000 0.2
(read/write) 179888 179984 96 0.1
.bss 94944 94944 0 0.0
.data 1920 2016 96 5.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258621 259741 1120 0.4
.text 2337458 2341170 3712 0.2
bridge-app debug+rpc (read only) 2247553 2253097 5544 0.2
(read/write) 158752 158848 96 0.1
.bss 82976 82976 0 0.0
.data 3760 3856 96 2.6
.data.rel.ro 66232 66232 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191040 192576 1536 0.8
.text 1896530 1900370 3840 0.2
chip-tool debug (read only) 9815973 9816149 176 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506805 506805 0 0.0
.text 7868549 7868725 176 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9564052 192 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468788 468788 0 0.0
.text 7518980 7519172 192 0.0
lighting-app debug+rpc (read only) 2497465 2502977 5512 0.2
(read/write) 163416 163544 128 0.1
.bss 84288 84320 32 0.0
.data 2064 2160 96 4.7
.data.rel.ro 71176 71176 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207144 208680 1536 0.7
.text 2122130 2125938 3808 0.2
lock-app debug (read only) 2443465 2448897 5432 0.2
(read/write) 158488 158584 96 0.1
.bss 82944 82944 0 0.0
.data 1552 1648 96 6.2
.data.rel.ro 68120 68120 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221192 222728 1536 0.7
.text 2059074 2062802 3728 0.2
ota-provider-app debug (read only) 2281729 2287273 5544 0.2
(read/write) 152688 152784 96 0.1
.bss 82624 82624 0 0.0
.data 1784 1880 96 5.4
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197336 198872 1536 0.8
.text 1923202 1927042 3840 0.2
ota-requestor-app debug (read only) 2329289 2334833 5544 0.2
(read/write) 155504 155600 96 0.1
.bss 83328 83328 0 0.0
.data 1976 2072 96 4.9
.data.rel.ro 64392 64392 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199520 201056 1536 0.8
.text 1964738 1968578 3840 0.2
shell debug (read only) 2604841 2604841 0 0.0
(read/write) 219352 219352 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77640 77640 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229778 229778 0 0.0
.text 2215746 2215746 0 0.0
thermostat-no-ble arm64 (read only) 2557916 2562156 4240 0.2
(read/write) 191409 191521 112 0.1
.bss 99377 99377 0 0.0
.data 1560 1672 112 7.2
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161332 162644 1312 0.8
.text 2158912 2161664 2752 0.1
tv-app debug (read only) 3050873 3056561 5688 0.2
(read/write) 289864 289960 96 0.0
.bss 200200 200200 0 0.0
.data 4688 4784 96 2.0
.data.rel.ro 78528 78528 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242720 244224 1504 0.6
.text 2622370 2626386 4016 0.2
tv-casting-app debug (read only) 5349977 5355681 5704 0.1
(read/write) 232312 232408 96 0.0
.bss 88072 88072 0 0.0
.data 2480 2576 96 3.9
.data.rel.ro 135528 135528 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342368 343904 1536 0.4
.text 4656338 4660338 4000 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2432808 0 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1395452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1197743 1197743 0 0.0
bss 141588 141588 0 0.0
rodata 155784 155784 0 0.0
text 821388 821388 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1143531 0 0.0
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 791972 791968 -4 -0.0
p6 all-clusters-app default (read/write) 2551656 2551656 0 0.0
.bss 143408 143408 0 0.0
.data 2832 2832 0 0.0
.text 1509920 1509920 0 0.0
all-clusters-minimal-app default (read/write) 2494128 2494128 0 0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452392 1452392 0 0.0
light-app default (read/write) 2425560 2425560 0 0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383824 1383824 0 0.0
lock-app default (read/write) 2445968 2445968 0 0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404232 1404232 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786716 786716 0 0.0
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556632 556632 0 0.0
lighting-app tlsr9518adk80d (read/write) 806704 806704 0 0.0
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573324 573324 0 0.0

@vivien-apple vivien-apple merged commit b006bab into project-chip:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
darwin examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @tcarmelveilleux @bzbarsky-apple