Move GetVendorId and GetProductId to DeviceInstanceInfoProvider #19514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
The difference is that for serial number or other values tested in unit tests we also have "store" methods, so we can test store and then get value. In the product/vendor parameters case we have only getters, so there is not much to test. Nevertheless I added some basic tests checking the returned error code and making validation whether values fit the allowed limits. |
bzbarsky-apple
approved these changes
Jun 14, 2022
LuDuda
approved these changes
Jun 14, 2022
nicelyjust
reviewed
Jun 30, 2022
| return err; | ||
| } | ||
|
|
||
| CHIP_ERROR DeviceInstanceInfoProviderImpl::GetProductId(uint16_t & productId) |
There was a problem hiding this comment.
@kkasperczyk-no HI Kamil ,in Android Platform, when you try to get the product ID, it cannot reached here, can you check that?
There was a problem hiding this comment.
@nicelyjust yes it looks like I did mistake when moving some methods to other modules. I pushed PR that I hope should fix this: #20208
kkasperczyk-no
added a commit
to kkasperczyk-no/connectedhomeip
that referenced
this pull request
Jul 1, 2022
In the project-chip#19514 there was a mistake done, as Android methods were meant to only be moved to other module not change their implementation. Restored the previous implementation/
kkasperczyk-no
added a commit
to kkasperczyk-no/connectedhomeip
that referenced
this pull request
Jul 1, 2022
In the project-chip#19514 there was a mistake done, as Android methods were meant to only be moved to other module not change their implementation. Restored the previous implementation/
andy31415
pushed a commit
that referenced
this pull request
Jul 3, 2022
In the #19514 there was a mistake done, as Android methods were meant to only be moved to other module not change their implementation. Restored the previous implementation/
ArekBalysNordic
added a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Jul 13, 2022
In the project-chip#19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
ArekBalysNordic
added a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Jul 14, 2022
In the project-chip#19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
ArekBalysNordic
added a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Jul 14, 2022
In the project-chip#19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
ArekBalysNordic
added a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Jul 14, 2022
In the project-chip#19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
ArekBalysNordic
added a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Jul 14, 2022
In the project-chip#19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
ArekBalysNordic
added a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Jul 15, 2022
In the project-chip#19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
ArekBalysNordic
added a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Jul 15, 2022
In the project-chip#19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
ArekBalysNordic
added a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Jul 15, 2022
In the project-chip#19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
ArekBalysNordic
added a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Jul 15, 2022
In the project-chip#19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
ArekBalysNordic
added a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Jul 15, 2022
In the project-chip#19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
woody-apple
pushed a commit
that referenced
this pull request
Jul 19, 2022
In the #19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
In the #19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS.
woody-apple
added a commit
that referenced
this pull request
Jul 19, 2022
… (#20925) In the #19514 there was a mistake made. Within some platforms, the DeviceInstanceInfoProvider was set to a generic one instead of the platform implementation. To resolve this issue, the DeviceInstanceInfoProvider has been set to the proper one in PlatformManager implementation for Android, Darwin, Linux, Tizen, and WebOS. Co-authored-by: Arkadiusz Bałys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GetVendorIdandGetProductIdare part ofConfigurationManager, while it can be useful to put those data into the factory data.Change overview
GetVendorIdandGetProductIdtoDeviceInstanceInfoProviderto be able to easily override it for the factory data providers.DeviceInstanceInfoProviderImplfor the platforms (Darwin, Linux, Android, Tizen, Webos) that has different methods implementation thanLegacyDeviceInstanceInfoProvider.