Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android]can not get PID &ProductName from Java #20590

Closed
nicelyjust opened this issue Jul 12, 2022 · 2 comments · Fixed by #20801
Closed

[Android]can not get PID &ProductName from Java #20590

nicelyjust opened this issue Jul 12, 2022 · 2 comments · Fixed by #20801

Comments

@nicelyjust
Copy link
Contributor

Problem

after this #19514 commited, then unenable to get PID &ProductName from AndroidConfig

Proposed Solution

support to get PID &ProductName from AndroidConfig

@andy31415
Copy link
Contributor

#20208 was supposed to fix this.

Is the error still happening?

@kkasperczyk-no

@kkasperczyk-no
Copy link
Contributor

kkasperczyk-no commented Jul 12, 2022

Unfortunately I didn't fix that, the first fix was also required, but the actual cause is different. The reason is that every platform or application that wants to use the different DeviceInstanceInfoProvider implementation than default GenericDeviceInstanceInfoProvider needs to call SetDeviceInstanceInfoProvider(). As far as I know currently the ESP32 and nRFConnect do it and it works, but it should be also done for Android, Darwin, Linux, Tizen and Webos, as those one have platform implementation provided.

I wanted to fix that for those platforms on a platform layer to not call SetDeviceInstanceInfoProvider() for every particular example/app, but I had some problems with solving dependency errors and then had bunch of other work that didn't allow me to get back to it. I still remember this issue and I already discussed it with other Nordic folks (@ArekBalysNordic specifically) to delegate fixing this to someone else due to my lack of time. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants