Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build_overrides/pigweed_environment.gni #19430

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Add build_overrides/pigweed_environment.gni #19430

merged 1 commit into from
Jun 13, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Jun 10, 2022

Problem

A fresh build complains missing build_overrides/pigweed_environment.gni file.

Change overview

Add an empty file to satisfy it.

Testing

Not needed.

@kghost kghost closed this Jun 10, 2022
@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19430: Size comparison from 668938e to 7377580

Increases (1 build for telink)
platform target config section 668938e 7377580 change % change
telink light-switch-app tlsr9518adk80d (read/write) 781664 781672 8 0.0
text 552544 552546 2 0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 668938e 7377580 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690039 690039 0 0.0
(read/write) 161728 161728 0 0.0
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112391 112391 0 0.0
.text 577336 577336 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640687 640687 0 0.0
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89439 89439 0 0.0
.text 550928 550928 0 0.0
lock-ftd LP_CC2652R7 (read only) 683567 683567 0 0.0
(read/write) 159264 159264 0 0.0
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98255 98255 0 0.0
.text 584828 584828 0 0.0
lock-mtd LP_CC2652R7 (read only) 632983 632983 0 0.0
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98143 98143 0 0.0
.text 534348 534348 0 0.0
pump-app LP_CC2652R7 (read only) 664923 664923 0 0.0
(read/write) 178820 178820 0 0.0
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86363 86363 0 0.0
.text 578076 578076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655491 655491 0 0.0
(read/write) 188356 188356 0 0.0
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84251 84251 0 0.0
.text 570756 570756 0 0.0
shell LP_CC2652R7 (read only) 682326 682326 0 0.0
(read/write) 164936 164936 0 0.0
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108990 108990 0 0.0
.text 573024 573024 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602562 602562 0 0.0
.app_xip_area 461508 461508 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599670 599670 0 0.0
.app_xip_area 458480 458480 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599446 599446 0 0.0
.app_xip_area 459372 459372 0 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915032 915032 0 0.0
(read/write) 133176 133176 0 0.0
.bss 131088 131088 0 0.0
.data 2088 2088 0 0.0
.text 915024 915024 0 0.0
BRD4161A+rpc (read only) 949236 949236 0 0.0
(read/write) 149868 149868 0 0.0
.bss 147576 147576 0 0.0
.data 2292 2292 0 0.0
.text 949228 949228 0 0.0
BRD4161A+rs911x (read only) 790228 790228 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127364 127364 0 0.0
.data 2096 2096 0 0.0
.text 790220 790220 0 0.0
lock-app BRD4161A+wf200 (read only) 959324 959324 0 0.0
(read/write) 129804 129804 0 0.0
.bss 127740 127740 0 0.0
.data 2064 2064 0 0.0
.text 959316 959316 0 0.0
window-app BRD4161A (read only) 900104 900104 0 0.0
(read/write) 133264 133264 0 0.0
.bss 131176 131176 0 0.0
.data 2084 2084 0 0.0
.text 900096 900096 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007766 1007766 0 0.0
(read/write) 1481906 1481906 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212656 212656 0 0.0
.flash.text 1007766 1007766 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062555 1062555 0 0.0
(read/write) 484040 484040 0 0.0
.dram0.bss 74688 74688 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243156 243156 0 0.0
.flash.text 1057171 1057171 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653816 653816 0 0.0
.bss 70044 70044 0 0.0
.data 2004 2004 0 0.0
.text 575968 575968 0 0.0
lock k32w061+release (read/write) 715012 715012 0 0.0
.bss 70484 70484 0 0.0
.data 1976 1976 0 0.0
.text 636752 636752 0 0.0
linux all-clusters-app debug (read only) 2892577 2892577 0 0.0
(read/write) 180024 180024 0 0.0
.bss 87840 87840 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83944 83944 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255549 255549 0 0.0
.text 2462578 2462578 0 0.0
all-clusters-minimal-app debug (read only) 2754073 2754073 0 0.0
(read/write) 171640 171640 0 0.0
.bss 87008 87008 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76568 76568 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256861 256861 0 0.0
.text 2324770 2324770 0 0.0
bridge-app debug+rpc (read only) 2197993 2197993 0 0.0
(read/write) 149528 149528 0 0.0
.bss 74496 74496 0 0.0
.data 3888 3888 0 0.0
.data.rel.ro 65384 65384 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 187840 187840 0 0.0
.text 1851314 1851314 0 0.0
chip-tool debug (read only) 9810253 9810253 0 0.0
(read/write) 623232 623232 0 0.0
.bss 25408 25408 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590432 590432 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 506109 506109 0 0.0
.text 7864053 7864053 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9557468 9557468 0 0.0
(read/write) 689553 689553 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 625888 625888 0 0.0
.dynamic 528 528 0 0.0
.got 15032 15032 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468428 468428 0 0.0
.text 7513636 7513636 0 0.0
lighting-app debug+rpc (read only) 2482409 2482409 0 0.0
(read/write) 155136 155136 0 0.0
.bss 76320 76320 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70872 70872 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205416 205416 0 0.0
.text 2109474 2109474 0 0.0
lock-app debug (read only) 2428457 2428457 0 0.0
(read/write) 150272 150272 0 0.0
.bss 75040 75040 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67832 67832 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219528 219528 0 0.0
.text 2046402 2046402 0 0.0
ota-provider-app debug (read only) 2203809 2203809 0 0.0
(read/write) 143232 143232 0 0.0
.bss 74496 74496 0 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61192 61192 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 191992 191992 0 0.0
.text 1852210 1852210 0 0.0
ota-requestor-app debug (read only) 2265441 2265441 0 0.0
(read/write) 146280 146280 0 0.0
.bss 75264 75264 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63288 63288 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195328 195328 0 0.0
.text 1906450 1906450 0 0.0
shell debug (read only) 2584201 2584201 0 0.0
(read/write) 203200 203200 0 0.0
.bss 118728 118728 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77368 77368 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228114 228114 0 0.0
.text 2197538 2197538 0 0.0
thermostat-no-ble arm64 (read only) 2544060 2544060 0 0.0
(read/write) 183057 183057 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82120 82120 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160164 160164 0 0.0
.text 2147040 2147040 0 0.0
tv-app debug (read only) 3035961 3035961 0 0.0
(read/write) 281616 281616 0 0.0
.bss 192296 192296 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78216 78216 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 241056 241056 0 0.0
.text 2609794 2609794 0 0.0
tv-casting-app debug (read only) 5335161 5335161 0 0.0
(read/write) 224000 224000 0 0.0
.bss 80136 80136 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135216 135216 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340576 340576 0 0.0
.text 4643986 4643986 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429752 2429752 0 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392396 1392396 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192139 1192139 0 0.0
bss 141362 141362 0 0.0
rodata 154732 154732 0 0.0
text 817116 817116 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139879 1139879 0 0.0
bss 140579 140579 0 0.0
rodata 131224 131224 0 0.0
text 789192 789192 0 0.0
p6 all-clusters-app default (read/write) 2545168 2545168 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503432 1503432 0 0.0
all-clusters-minimal-app default (read/write) 2489976 2489976 0 0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1448240 1448240 0 0.0
light-app default (read/write) 2421360 2421360 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379624 1379624 0 0.0
lock-app default (read/write) 2441752 2441752 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1400016 1400016 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781664 781672 8 0.0
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552544 552546 2 0.0
lighting-app tlsr9518adk80d (read/write) 801676 801676 0 0.0
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569264 569264 0 0.0

@woody-apple
Copy link
Contributor

Re-opening this. Looks like a good fix, why not take this?

@woody-apple woody-apple reopened this Jun 11, 2022
@woody-apple woody-apple added build issue hotfix urgent fix needed, can bypass review labels Jun 11, 2022
@woody-apple woody-apple merged commit c1e1d01 into project-chip:master Jun 13, 2022
@kghost kghost deleted the misc-1 branch June 13, 2022 02:33
@mspang
Copy link
Contributor

mspang commented Jun 14, 2022

Why was this generated file checked in?

andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Jun 14, 2022
@andy31415
Revert "Add build_overrides/pigweed_environment.gni (project-chip#19430…
a60267f 
…)"

This reverts commit c1e1d01.

build_overrides.gni is automatically created by bootstrea.sh
(specifically
third_party/pigweed/repo/pw_env_setup/py/pw_env_setup/env_setup.py)
andy31415 added a commit that referenced this pull request Jun 14, 2022
@andy31415
Revert "Add build_overrides/pigweed_environment.gni (#19430)" (#19559)
1d3623b 
This reverts commit c1e1d01.

build_overrides.gni is automatically created by bootstrea.sh
(specifically
third_party/pigweed/repo/pw_env_setup/py/pw_env_setup/env_setup.py)
msandstedt pushed a commit to msandstedt/connectedhomeip that referenced this pull request Nov 1, 2022
@samadDotDev
Patch Pigweed for arduino build exclusion
a3625c8 
Also, adding build_overrides/pigweed_environment.gni due to
project-chip#19430
which was reverted in
project-chip#19559
in favor of running the bootstrap script which
we don't want to run in the first place due to CI concerns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
build issue hotfix urgent fix needed, can bypass review review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kghost @woody-apple @mspang