Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pump] PostEvents now called from ScheduleWork #19379

Merged
merged 2 commits into from
Jun 9, 2022
Merged

[pump] PostEvents now called from ScheduleWork #19379

merged 2 commits into from
Jun 9, 2022

Conversation

ReneJosefsen
Copy link
Contributor

Problem

What is being fixed?

Change overview

PostEvents is not called from ScheduleWork

Testing

How was this tested? (at least one bullet point required)
manually tested on cc2652r7 launchpad

@ReneJosefsen ReneJosefsen changed the title PostEvents now called from ScheduleWork [pump] PostEvents now called from ScheduleWork Jun 9, 2022
@restyled-io restyled-io bot mentioned this pull request Jun 9, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 9, 2022 •
edited
Loading

PR #19379: Size comparison from 47a51ce to 507201a

Increases (1 build for telink)
platform target config section 47a51ce 507201a change % change
telink light-switch-app tlsr9518adk80d text 552570 552574 4 0.0
Full report (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
platform target config section 47a51ce 507201a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602562 602562 0 0.0
.app_xip_area 461508 461508 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599646 599646 0 0.0
.app_xip_area 458456 458456 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599438 599438 0 0.0
.app_xip_area 459364 459364 0 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 653768 653768 0 0.0
.bss 70044 70044 0 0.0
.data 2004 2004 0 0.0
.text 575920 575920 0 0.0
lock k32w061+release (read/write) 714876 714876 0 0.0
.bss 70484 70484 0 0.0
.data 1976 1976 0 0.0
.text 636616 636616 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9499468 9499468 0 0.0
(read/write) 678033 678033 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614464 614464 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467916 467916 0 0.0
.text 7483220 7483220 0 0.0
thermostat-no-ble arm64 (read only) 2544060 2544060 0 0.0
(read/write) 183057 183057 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82120 82120 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160164 160164 0 0.0
.text 2147040 2147040 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429656 2429656 0 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392300 1392300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192051 1192051 0 0.0
bss 141362 141362 0 0.0
rodata 154644 154644 0 0.0
text 817112 817112 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139759 1139759 0 0.0
bss 140579 140579 0 0.0
rodata 131136 131136 0 0.0
text 789160 789160 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781696 781696 0 0.0
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552570 552574 4 0.0
lighting-app tlsr9518adk80d (read/write) 801708 801708 0 0.0
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569292 569292 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 9, 2022 •
edited
Loading

PR #19379: Size comparison from 47a51ce to bb4293d

Increases (2 builds for cc13x2_26x2)
platform target config section 47a51ce bb4293d change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 664899 664915 16 0.0
.text 578052 578068 16 0.0
pump-controller-app LP_CC2652R7 (read/write) 188364 188372 8 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 47a51ce bb4293d change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 178844 178828 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 655483 655475 -8 -0.0
.text 570748 570740 -8 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 47a51ce bb4293d change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689951 689951 0 0.0
(read/write) 161816 161816 0 0.0
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112327 112327 0 0.0
.text 577312 577312 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640567 640567 0 0.0
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89367 89367 0 0.0
.text 550880 550880 0 0.0
lock-ftd LP_CC2652R7 (read only) 683455 683455 0 0.0
(read/write) 159376 159376 0 0.0
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98183 98183 0 0.0
.text 584788 584788 0 0.0
lock-mtd LP_CC2652R7 (read only) 632871 632871 0 0.0
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98071 98071 0 0.0
.text 534308 534308 0 0.0
pump-app LP_CC2652R7 (read only) 664899 664915 16 0.0
(read/write) 178844 178828 -16 -0.0
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86363 86363 0 0.0
.text 578052 578068 16 0.0
pump-controller-app LP_CC2652R7 (read only) 655483 655475 -8 -0.0
(read/write) 188364 188372 8 0.0
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84251 84251 0 0.0
.text 570748 570740 -8 -0.0
shell LP_CC2652R7 (read only) 682230 682230 0 0.0
(read/write) 165032 165032 0 0.0
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108926 108926 0 0.0
.text 572992 572992 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602562 602562 0 0.0
.app_xip_area 461508 461508 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599646 599646 0 0.0
.app_xip_area 458456 458456 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599438 599438 0 0.0
.app_xip_area 459364 459364 0 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915032 915032 0 0.0
(read/write) 133176 133176 0 0.0
.bss 131088 131088 0 0.0
.data 2088 2088 0 0.0
.text 915024 915024 0 0.0
BRD4161A+rpc (read only) 949236 949236 0 0.0
(read/write) 149868 149868 0 0.0
.bss 147576 147576 0 0.0
.data 2292 2292 0 0.0
.text 949228 949228 0 0.0
BRD4161A+rs911x (read only) 790228 790228 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127364 127364 0 0.0
.data 2096 2096 0 0.0
.text 790220 790220 0 0.0
lock-app BRD4161A+wf200 (read only) 958468 958468 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126188 126188 0 0.0
.data 2064 2064 0 0.0
.text 958460 958460 0 0.0
window-app BRD4161A (read only) 900088 900088 0 0.0
(read/write) 133264 133264 0 0.0
.bss 131176 131176 0 0.0
.data 2084 2084 0 0.0
.text 900080 900080 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007720 1007720 0 0.0
(read/write) 1481834 1481834 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212584 212584 0 0.0
.flash.text 1007720 1007720 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062495 1062495 0 0.0
(read/write) 483968 483968 0 0.0
.dram0.bss 74688 74688 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243084 243084 0 0.0
.flash.text 1057111 1057111 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653768 653768 0 0.0
.bss 70044 70044 0 0.0
.data 2004 2004 0 0.0
.text 575920 575920 0 0.0
lock k32w061+release (read/write) 714876 714876 0 0.0
.bss 70484 70484 0 0.0
.data 1976 1976 0 0.0
.text 636616 636616 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9499468 9499468 0 0.0
(read/write) 678033 678033 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614464 614464 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467916 467916 0 0.0
.text 7483220 7483220 0 0.0
thermostat-no-ble arm64 (read only) 2544060 2544060 0 0.0
(read/write) 183057 183057 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82120 82120 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160164 160164 0 0.0
.text 2147040 2147040 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429656 2429656 0 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392300 1392300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192051 1192051 0 0.0
bss 141362 141362 0 0.0
rodata 154644 154644 0 0.0
text 817112 817112 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139759 1139759 0 0.0
bss 140579 140579 0 0.0
rodata 131136 131136 0 0.0
text 789160 789160 0 0.0
p6 all-clusters-app default (read/write) 2544520 2544520 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502784 1502784 0 0.0
all-clusters-minimal-app default (read/write) 2489392 2489392 0 0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1447656 1447656 0 0.0
light-app default (read/write) 2421312 2421312 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379576 1379576 0 0.0
lock-app default (read/write) 2441648 2441648 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1399912 1399912 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781696 781696 0 0.0
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552570 552570 0 0.0
lighting-app tlsr9518adk80d (read/write) 801708 801708 0 0.0
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569292 569292 0 0.0

@andy31415 andy31415 merged commit d2e5909 into project-chip:master Jun 9, 2022
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jun 10, 2022
@ReneJosefsen @mkardous-silabs
[pump] PostEvents now called from ScheduleWork (project-chip#19379)
75831d5 
* PostEvents now called from ScheduleWork

* Fixed whitespace from restyle
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Jun 15, 2022
@ReneJosefsen @rochaferraz
[pump] PostEvents now called from ScheduleWork (project-chip#19379)
31914d5 
* PostEvents now called from ScheduleWork

* Fixed whitespace from restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ReneJosefsen @andy31415 @woody-apple @bzbarsky-apple @Damian-Nordic