Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In cc13x2x7_26x2x7, LogEvent seems to emanate from a thread other than the CHIP task. #19304

Closed
yunhanw-google opened this issue Jun 8, 2022 · 10 comments

Comments

@yunhanw-google
Copy link
Contributor

I think cc13x2x7_26x2x7's main.cpp contains a call to LogEvent that seems to emanate from a thread other than the CHIP task.

Might want to file an issue on that.

Originally posted by @mrjerryjohns in #19285 (review)

@yunhanw-google
Copy link
Contributor Author

@andreilitvin who is taking care of cc13x2x7_26x2x7?

@andy31415
Copy link
Contributor

@andreilitvin who is taking care of cc13x2x7_26x2x7?

@srickardti maybe based on commit logs?

@srickardti
Copy link
Contributor

@yunhanw-google can you point me to the offending code? The only reference to logging in our main.cpp files is a commented out platform log because the UART driver isn't up until the kernel is started.

In our examples we usually use a macro to call our platform logging function. Is there a better way to consolidate logging?

@bzbarsky-apple
Copy link
Contributor

connectedhomeip % git grep -n LogEvent | grep cc13
examples/pump-app/cc13x2x7_26x2x7/main/AppTask.cpp:621:        if (CHIP_NO_ERROR != LogEvent(event, endpoint, eventNumber))

@bzbarsky-apple
Copy link
Contributor

This is not about "logging". This is about Matter events.

@ReneJosefsen
Copy link
Contributor

This is an old section of code used for demonstration purposes. Since events are not going to make it for 1.0 I would think the easiest solution is to just remove the code that triggers the LogEvent.

If that is acceptable, I can do a PR to fix this.

@bzbarsky-apple
Copy link
Contributor

In what sense are "events not going to make it for 1.0"?

@ReneJosefsen
Copy link
Contributor

I assumed that events in general was deferred for now, but there might be something I missed?

@bzbarsky-apple
Copy link
Contributor

Events in general are implemented and tested.

@andy31415
Copy link
Contributor

Fixed by 19379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants