-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In cc13x2x7_26x2x7, LogEvent seems to emanate from a thread other than the CHIP task. #19304
Comments
@andreilitvin who is taking care of cc13x2x7_26x2x7? |
@srickardti maybe based on commit logs? |
@yunhanw-google can you point me to the offending code? The only reference to logging in our In our examples we usually use a macro to call our platform logging function. Is there a better way to consolidate logging? |
|
This is not about "logging". This is about Matter events. |
This is an old section of code used for demonstration purposes. Since events are not going to make it for 1.0 I would think the easiest solution is to just remove the code that triggers the LogEvent. If that is acceptable, I can do a PR to fix this. |
In what sense are "events not going to make it for 1.0"? |
I assumed that events in general was deferred for now, but there might be something I missed? |
Events in general are implemented and tested. |
Fixed by 19379 |
I think
cc13x2x7_26x2x7
's main.cpp contains a call toLogEvent
that seems to emanate from a thread other than the CHIP task.Might want to file an issue on that.
Originally posted by @mrjerryjohns in #19285 (review)
The text was updated successfully, but these errors were encountered: