-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BitMask
instead of BitFlags
for data model encoding of bitmaps
#19008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran and
isiu-apple
May 31, 2022 19:32
PR #19008: Size comparison from eb3ac83 to fb350a9 Increases (8 builds for linux)
Decreases (1 build for linux)
Full report (26 builds for cyw30739, k32w, linux, nrfconnect, p6, telink)
|
PR #19008: Size comparison from eb3ac83 to cf0826f Increases (9 builds for linux)
Full report (29 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19008: Size comparison from eb3ac83 to bbf903f Increases (9 builds for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmeg-sfy
approved these changes
Jun 1, 2022
mrjerryjohns
reviewed
Jun 1, 2022
mrjerryjohns
approved these changes
Jun 1, 2022
bzbarsky-apple
requested changes
Jun 2, 2022
woody-apple
approved these changes
Jun 2, 2022
PR #19008: Size comparison from 43b14a6 to 5539eba Increases (10 builds for cc13x2_26x2, linux)
Decreases (25 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 3, 2022
PR #19008: Size comparison from a00e966 to a161db6 Increases (9 builds for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19008: Size comparison from a81171b to 02b9992 Increases (9 builds for linux)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19008: Size comparison from a81171b to 6f202ed Increases (9 builds for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BitFlags
were designed for boolean flags for individual values.However the spec has several types that are bitmapX with specific areas set as masks.
See #18300
Change overview
Use a BitMask class that derives from BitFlags but also adds support for setting bits based on masks.
Testing
Compile only and CI should validate. Change is mostly a noop, but changes such as #18300 can start using this.