Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowCovering: Improve Xml enum for OperationalStatus #18300

Merged
merged 20 commits into from
Jun 15, 2022
Merged

WindowCovering: Improve Xml enum for OperationalStatus #18300

merged 20 commits into from
Jun 15, 2022

Conversation

jmeg-sfy
Copy link
Contributor

@jmeg-sfy jmeg-sfy commented May 11, 2022 •
edited
Loading

Problem

What is being fixed? Examples:

  • Currently some enum are not all very clean
  • OperationalStatus header was redeclaring enum/mask now we use XML BitFlags
  • Need an update in BitFlags to support Set/Get of BitFields from Mask
  • Edit BitFlags done finally in PR 19008 ; these PR drops previous bitflags modifs

Change overview

What's in this PR

  • Use the proper enum for
    • SafetyStatus, OperationalStatus, FeatureMap
  • Use new BitMask instead of BitFlags to support mask and bitfield Get/Set value
  • Simplify support of Operational Status
  • Update All-cluster
  • Update EFR32 demo
  • Update NRF demo

Testing

How was this tested? (at least one bullet point required)

  • All units test ok !

@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

PR #18300: Size comparison from b8e9ab1 to fee6a74

Increases (4 builds for cc13x2_26x2, linux)
platform target config section b8e9ab1 fee6a74 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689863 689943 80 0.0
.text 577272 577384 112 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640479 640575 96 0.0
.text 550840 550968 128 0.0
shell LP_CC2652R7 (read only) 682142 682238 96 0.0
.text 572952 573080 128 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9474604 9480252 5648 0.1
.text 7470052 7475700 5648 0.1
Decreases (7 builds for cc13x2_26x2, p6, telink)
platform target config section b8e9ab1 fee6a74 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161904 161824 -80 -0.0
.rodata 112279 112247 -32 -0.0
all-clusters-minimal-app LP_CC2652R7 .rodata 89319 89287 -32 -0.0
shell LP_CC2652R7 (read/write) 165120 165024 -96 -0.1
.rodata 108878 108846 -32 -0.0
p6 all-clusters-app default (read/write) 2544464 2544448 -16 -0.0
.text 1502728 1502712 -16 -0.0
all-clusters-minimal-app default (read/write) 2489328 2489312 -16 -0.0
.text 1447592 1447576 -16 -0.0
telink light-switch-app tlsr9518adk80d text 552550 552548 -2 -0.0
lighting-app tlsr9518adk80d text 569270 569268 -2 -0.0
Full report (21 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section b8e9ab1 fee6a74 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689863 689943 80 0.0
(read/write) 161904 161824 -80 -0.0
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112279 112247 -32 -0.0
.text 577272 577384 112 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640479 640575 96 0.0
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89319 89287 -32 -0.0
.text 550840 550968 128 0.0
lock-ftd LP_CC2652R7 (read only) 683375 683375 0 0.0
(read/write) 159456 159456 0 0.0
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98143 98143 0 0.0
.text 584748 584748 0 0.0
lock-mtd LP_CC2652R7 (read only) 632791 632791 0 0.0
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98031 98031 0 0.0
.text 534268 534268 0 0.0
pump-app LP_CC2652R7 (read only) 664819 664819 0 0.0
(read/write) 178924 178924 0 0.0
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86315 86315 0 0.0
.text 578020 578020 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655403 655403 0 0.0
(read/write) 188444 188444 0 0.0
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84211 84211 0 0.0
.text 570708 570708 0 0.0
shell LP_CC2652R7 (read only) 682142 682238 96 0.0
(read/write) 165120 165024 -96 -0.1
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108878 108846 -32 -0.0
.text 572952 573080 128 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602546 602546 0 0.0
.app_xip_area 461492 461492 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599630 599630 0 0.0
.app_xip_area 458440 458440 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599374 599374 0 0.0
.app_xip_area 459300 459300 0 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 653744 653744 0 0.0
.bss 70044 70044 0 0.0
.data 2004 2004 0 0.0
.text 575896 575896 0 0.0
lock k32w061+release (read/write) 714788 714788 0 0.0
.bss 70484 70484 0 0.0
.data 1976 1976 0 0.0
.text 636528 636528 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9474604 9480252 5648 0.1
(read/write) 674257 674257 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610696 610696 0 0.0
.dynamic 528 528 0 0.0
.got 14928 14928 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467548 467548 0 0.0
.text 7470052 7475700 5648 0.1
thermostat-no-ble arm64 (read only) 2543900 2543900 0 0.0
(read/write) 183073 183073 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82144 82144 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160084 160084 0 0.0
.text 2146880 2146880 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429544 2429544 0 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392188 1392188 0 0.0
p6 all-clusters-app default (read/write) 2544464 2544448 -16 -0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502728 1502712 -16 -0.0
all-clusters-minimal-app default (read/write) 2489328 2489312 -16 -0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1447592 1447576 -16 -0.0
light-app default (read/write) 2421240 2421240 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379504 1379504 0 0.0
lock-app default (read/write) 2441576 2441576 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1399840 1399840 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781628 781628 0 0.0
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552550 552548 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 801640 801640 0 0.0
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569270 569268 -2 -0.0

@jmeg-sfy jmeg-sfy force-pushed the jmeg-sfy/window-covering-improve-feature branch from fee6a74 to 513814f Compare June 14, 2022 16:19
@github-actions
Copy link

github-actions bot commented Jun 14, 2022 •
edited
Loading

PR #18300: Size comparison from 4b6fc80 to 513814f

Increases (9 builds for cc13x2_26x2, esp32, linux, nrfconnect)
platform target config section 4b6fc80 513814f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659119 659231 112 0.0
.text 571760 571872 112 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645763 96 0.0
.text 555280 555408 128 0.0
lock-mtd LP_CC2652R7 (read only) 637939 637947 8 0.0
.text 538684 538692 8 0.0
shell LP_CC2652R7 (read only) 689270 689342 72 0.0
.text 578832 578944 112 0.0
esp32 all-clusters-app c3devkit (read only) 1013900 1013948 48 0.0
.flash.text 1013900 1013948 48 0.0
m5stack (read only) 1068115 1068191 76 0.0
.flash.text 1062731 1062807 76 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9580764 9586412 5648 0.1
.text 7533236 7538884 5648 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199111 1199191 80 0.0
text 822412 822524 112 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144347 1144423 76 0.0
text 792752 792864 112 0.0
Decreases (11 builds for cc13x2_26x2, efr32, esp32, nrfconnect, p6)
platform target config section 4b6fc80 513814f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191784 191672 -112 -0.1
all-clusters-minimal-app LP_CC2652R7 .rodata 90067 90035 -32 -0.0
shell LP_CC2652R7 (read/write) 157128 157056 -72 -0.0
.rodata 110126 110086 -40 -0.0
efr32 window-app BRD4161A (read/write) 133528 133520 -8 -0.0
.bss 131416 131408 -8 -0.0
esp32 all-clusters-app c3devkit (read/write) 1483522 1483490 -32 -0.0
.flash.rodata 213968 213936 -32 -0.0
m5stack (read/write) 485616 485576 -40 -0.0
.flash.rodata 244444 244404 -40 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 156128 156096 -32 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 rodata 131860 131824 -36 -0.0
lighting-app nrf52840dk_nrf52840 text 812304 812300 -4 -0.0
p6 all-clusters-app default (read/write) 2552984 2552968 -16 -0.0
.text 1511248 1511232 -16 -0.0
all-clusters-minimal-app default (read/write) 2495472 2495456 -16 -0.0
.text 1453736 1453720 -16 -0.0
Full report (38 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4b6fc80 513814f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659119 659231 112 0.0
(read/write) 191784 191672 -112 -0.1
.bss 73796 73796 0 0.0
.data 3416 3416 0 0.0
.rodata 87047 87047 0 0.0
.text 571760 571872 112 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645763 96 0.0
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90067 90035 -32 -0.0
.text 555280 555408 128 0.0
lock-ftd LP_CC2652R7 (read only) 688531 688531 0 0.0
(read/write) 153444 153444 0 0.0
.bss 71756 71756 0 0.0
.data 3280 3280 0 0.0
.rodata 98883 98883 0 0.0
.text 589164 589164 0 0.0
lock-mtd LP_CC2652R7 (read only) 637939 637947 8 0.0
(read/write) 144888 144888 0 0.0
.bss 67492 67492 0 0.0
.data 3280 3280 0 0.0
.rodata 98763 98763 0 0.0
.text 538684 538692 8 0.0
pump-app LP_CC2652R7 (read only) 669747 669747 0 0.0
(read/write) 173124 173124 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 582284 582284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660471 660471 0 0.0
(read/write) 182520 182520 0 0.0
.bss 72004 72004 0 0.0
.data 3276 3276 0 0.0
.rodata 84903 84903 0 0.0
.text 575084 575084 0 0.0
shell LP_CC2652R7 (read only) 689270 689342 72 0.0
(read/write) 157128 157056 -72 -0.0
.bss 76092 76092 0 0.0
.data 3420 3420 0 0.0
.rodata 110126 110086 -40 -0.0
.text 578832 578944 112 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612202 612202 0 0.0
.app_xip_area 467836 467836 0 0.0
.bss 87288 87288 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 609318 609318 0 0.0
.app_xip_area 464808 464808 0 0.0
.bss 87464 87464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 615382 615382 0 0.0
.app_xip_area 471928 471928 0 0.0
.bss 86464 86464 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920584 920584 0 0.0
(read/write) 133456 133456 0 0.0
.bss 131336 131336 0 0.0
.data 2116 2116 0 0.0
.text 920576 920576 0 0.0
BRD4161A+rpc (read only) 956240 956240 0 0.0
(read/write) 150328 150328 0 0.0
.bss 148008 148008 0 0.0
.data 2320 2320 0 0.0
.text 956232 956232 0 0.0
BRD4161A+rs911x (read only) 795700 795700 0 0.0
(read/write) 129736 129736 0 0.0
.bss 127612 127612 0 0.0
.data 2124 2124 0 0.0
.text 795692 795692 0 0.0
lock-app BRD4161A+wf200 (read only) 963596 963596 0 0.0
(read/write) 130076 130076 0 0.0
.bss 127988 127988 0 0.0
.data 2088 2088 0 0.0
.text 963588 963588 0 0.0
window-app BRD4161A (read only) 905472 905472 0 0.0
(read/write) 133528 133520 -8 -0.0
.bss 131416 131408 -8 -0.0
.data 2108 2108 0 0.0
.text 905464 905464 0 0.0
esp32 all-clusters-app c3devkit (read only) 1013900 1013948 48 0.0
(read/write) 1483522 1483490 -32 -0.0
.dram0.bss 69424 69424 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213968 213936 -32 -0.0
.flash.text 1013900 1013948 48 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068115 1068191 76 0.0
(read/write) 485616 485576 -40 -0.0
.dram0.bss 74952 74952 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 244444 244404 -40 -0.0
.flash.text 1062731 1062807 76 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658328 658328 0 0.0
.bss 69764 69764 0 0.0
.data 2028 2028 0 0.0
.text 580736 580736 0 0.0
lock k32w061+release (read/write) 719940 719940 0 0.0
.bss 70196 70196 0 0.0
.data 2000 2000 0 0.0
.text 641944 641944 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9580764 9586412 5648 0.1
(read/write) 690049 690049 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626288 626288 0 0.0
.dynamic 528 528 0 0.0
.got 15104 15104 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470924 470924 0 0.0
.text 7533236 7538884 5648 0.1
thermostat-no-ble arm64 (read only) 2560628 2560628 0 0.0
(read/write) 191489 191489 0 0.0
.bss 99393 99393 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82432 82432 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161356 161356 0 0.0
.text 2161472 2161472 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434816 2434816 0 0.0
.bss 209212 209212 0 0.0
.data 5864 5864 0 0.0
.text 1397460 1397460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199111 1199191 80 0.0
bss 141633 141633 0 0.0
rodata 156128 156096 -32 -0.0
text 822412 822524 112 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144347 1144423 76 0.0
bss 140824 140824 0 0.0
rodata 131860 131824 -36 -0.0
text 792752 792864 112 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1157767 1157767 0 0.0
bss 144181 144181 0 0.0
rodata 122384 122384 0 0.0
text 812304 812300 -4 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1126975 1126975 0 0.0
bss 144626 144626 0 0.0
rodata 114136 114136 0 0.0
text 788952 788952 0 0.0
nrf52840dongle_nrf52840 (read/write) 1064819 1064819 0 0.0
bss 151412 151412 0 0.0
rodata 91532 91532 0 0.0
text 740820 740820 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1061474 1061474 0 0.0
bss 140552 140552 0 0.0
rodata 114792 114792 0 0.0
text 725036 725036 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1109559 1109559 0 0.0
bss 134109 134109 0 0.0
rodata 138984 138984 0 0.0
text 757680 757680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1013518 1013518 0 0.0
bss 130512 130512 0 0.0
rodata 131452 131452 0 0.0
text 670472 670472 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1070595 1070595 0 0.0
bss 134076 134076 0 0.0
rodata 115724 115724 0 0.0
text 741912 741912 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1063351 1063351 0 0.0
bss 133869 133869 0 0.0
rodata 114624 114624 0 0.0
text 736048 736048 0 0.0
p6 all-clusters-app default (read/write) 2552984 2552968 -16 -0.0
.bss 143424 143424 0 0.0
.data 2832 2832 0 0.0
.text 1511248 1511232 -16 -0.0
all-clusters-minimal-app default (read/write) 2495472 2495456 -16 -0.0
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1453736 1453720 -16 -0.0
light-app default (read/write) 2426848 2426848 0 0.0
.bss 135752 135752 0 0.0
.data 2624 2624 0 0.0
.text 1385112 1385112 0 0.0
lock-app default (read/write) 2447256 2447256 0 0.0
.bss 135576 135576 0 0.0
.data 2600 2600 0 0.0
.text 1405520 1405520 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 787840 787840 0 0.0
bss 70892 70892 0 0.0
noinit 40416 40416 0 0.0
text 557712 557712 0 0.0
lighting-app tlsr9518adk80d (read/write) 807828 807828 0 0.0
bss 71144 71144 0 0.0
noinit 40416 40416 0 0.0
text 574404 574404 0 0.0

@andy31415 andy31415 merged commit 85e7649 into project-chip:master Jun 15, 2022
@jmeg-sfy jmeg-sfy deleted the jmeg-sfy/window-covering-improve-feature branch June 20, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

Assignees
No one assigned
Labels
app controller darwin examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmeg-sfy @andy31415 @jmartinez-silabs @restyled-commits