Add chip-trace-decoder program and get more messages logging from chip-tool and application based on examples/platform/linux #18893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex and
hawk248
|
PR #18893: Size comparison from 8ef608d to d99598b Increases above 0.2%:
Increases (13 builds for linux)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
vivien-apple
force-pushed
the
Tracer_Decoding
branch
from
d99598b to
51837c3
Compare
vivien-apple
force-pushed
the
Tracer_Decoding
branch
from
51837c3 to
e554491
Compare
woody-apple
approved these changes
Jun 2, 2022
|
/rebase |
vivien-apple
force-pushed
the
Tracer_Decoding
branch
from
e554491 to
9a71146
Compare
|
PR #18893: Size comparison from fd5e78d to 9a71146 Increases above 0.2%:
Increases (13 builds for linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
vivien-apple
force-pushed
the
Tracer_Decoding
branch
from
9a71146 to
b57132c
Compare
vivien-apple
force-pushed
the
Tracer_Decoding
branch
from
b57132c to
f158e3c
Compare
|
PR #18893: Size comparison from 55ab764 to f158e3c Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jun 7, 2022
|
It seems like the IM output text format is different from the others. The spec defines a fairly robust text format for converting TLV payloads to a human-readable format - shouldn't we just be using that to standardize uniformly? (for at least, the TLV payloads). |
This was referenced Jun 8, 2022
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jun 10, 2022
…p-tool and application based on examples/platform/linux (project-chip#18893) * [chip-tool] Get kLogCategory_Automation to be logged when using trace_log=true * Add a missing #pragma once instructions in TraceHandlers.h * Make CHIP_CONFIG_LOG_MESSAGE_MAX_SIZE configurable when building * Add support to multiple tracing streams to TraceHandlers.cpp * Add chip-trace-decoder program * Add chip-tool tracing decoder support * Add tracing decoder support to example applications based on examples/platform/linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For some of the test plans, the information that is sent onto the wire or retrieve is not obviously visible.
Ideally one would compile the application that should emits logs with
chip_log_message_max_size=2048since I noticed that some messages just don't work otherwise. The application keeps logging if it fails though, but logs an error.Change overview
This PR relies on the tracing feature from
examples/common/tracing. It adds a program to decode the trace file generated when using--trace_file <filepath>as well as a "live" trace decoder instead of dumping the raw data in the logs when using--trace_log 1.The tracing decoding works in
chip-tooland all applications usingexamples/platform/linuxfor emitted/received messages for "Secure Channel" messages and "Interaction Model" messages. It also try to not duplicate the output of interaction model messages that are received by the device currently.The PR also contains all the boiler plates for the others protocols that are not decoded yet (BDX, UserDirectedCommissioning/Echo).
Testing
I have tested live in chip-tool and the all-clusters-app for pairing operations as well as random commands/attributes reads.
I have also tested it onto the same things but when the tracing has been dumped to a file.
./out/debug/standalone/chip-tool pairing code 0x12344321 MT:-24J029Q00KA0648G00 --trace_file /tmp/trace.log./out/debug/standalone/chip-tool pairing code 0x12344321 MT:-24J029Q00KA0648G00 --trace_log 1./out/debug/standalone/chip-all-clusters-app --trace_log 1./out/debug/standalone/chip-trace-decoder --source /tmp/foo.log