Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-DA-1.3]chip-tool-Device Attestation Request Validation [DUT Commissioner] is not supported #14397

Closed
sumaky opened this issue Jan 27, 2022 · 5 comments

Comments

@sumaky
Copy link
Contributor

sumaky commented Jan 27, 2022

Problem

  1. To validate the device attestation procedure with DUT as commissioner is not supported in CHIP tool
  2. Attestation NONCE validation is not supported

Proposed Solution

  1. Provision of API's to support device attestation by enabling DUT as commissioner
  2. Method to verify DUT generates unique nonce each time
  3. API to verify with Crypto_Verify
  4. API to confirm Firmware Information data matches an entry in the Distributed Compliance Ledger
    Test Plan Link
    https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/deviceattestation.adoc
@tcarmelveilleux
Copy link
Contributor

The APIs all exist in the SDK to allow changing the responses during device attestation. The TH apps based on the placeholder app could have a DeviceAttestationCredentialsProvider implementation that has additional hook-ups with the interfaces between Test Harness and placeholder app itself, so that the responses can be varied to trigger different error situations at the commissioner as DUT.

Note that for Commissioner as DUT cases, chip-tool is never involved.

To achieve this testability, the work is entirely done in core SDK from my perspective, and the automation and integration relate to how the TH and DUT are orchestrated by CSG tests.

@vivien-apple
Copy link
Contributor

My understanding of this issue is that we need 2 things:

Is there anything else that I missed ?

@woody-apple
Copy link
Contributor

Cert Blocker Review: Assigning to @vivien-apple

@franck-apple
Copy link

should be fixed by Vivien's PR #18893. @sumaky can you please verify and close this issue?
Otherwise, please let @vivien-apple know if something is missing.

@franck-apple franck-apple assigned sumaky and unassigned vivien-apple Jun 8, 2022
@vivien-apple
Copy link
Contributor

I would assume that this is done. It I'm wrong please reopen a separate issue with the specific parts that are missing. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants