-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IdentifyQuery. #18819
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:nix-identifyquery
May 26, 2022
Merged
Remove IdentifyQuery. #18819
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:nix-identifyquery
May 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #18819: Size comparison from 9e92268 to ef2fb2a Increases above 0.2%:
Increases (5 builds for cc13x2_26x2)
Decreases (30 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (35 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
ef2fb2a
to
ffe6abb
Compare
PR #18819: Size comparison from 66ebfb2 to ffe6abb Increases above 0.2%:
Increases (5 builds for cc13x2_26x2)
Decreases (30 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (35 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
This command has been removed from Matter. See CHIP-Specifications/connectedhomeip-spec#5240 Fixes project-chip#17133
ffe6abb
to
6f8159e
Compare
isiu-apple
approved these changes
May 25, 2022
PR #18819: Size comparison from 433c5ff to 6f8159e Increases above 0.2%:
Increases (5 builds for cc13x2_26x2)
Decreases (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command has been removed from Matter. See
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5240
Fixes #17133
Problem
Command that is not in the spec.
Change overview
Remove it.
Testing
Compiled a few test apps locally.