Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of IdentifyQuery can respond with a success status for a command that expects a data response #17133

Closed
bzbarsky-apple opened this issue Apr 6, 2022 · 0 comments · Fixed by #18819
Closed

Implementation of IdentifyQuery can respond with a success status for a command that expects a data response #17133

bzbarsky-apple opened this issue Apr 6, 2022 · 0 comments · Fixed by #18819
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

See https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/5094 for the spec end of this.

The implementation of emberAfIdentifyClusterIdentifyQueryCallback will send a success status response if identifyTime is 0. This then ends up failing to be parsed by clients, because per IM that's not a valid response to the IdentifyQuery command.

Proposed Solution

Sort out the spec issue, then adjust implementation as needed.
@bzbarsky-apple bzbarsky-apple added V1.0 spec Mismatch between spec and implementation app-clusters Application cluster work labels Apr 6, 2022
@bzbarsky-apple bzbarsky-apple mentioned this issue Apr 6, 2022
Closed
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 25, 2022
@bzbarsky-apple
Remove IdentifyQuery.
ef2fb2a 
This command has been removed from Matter.  See
CHIP-Specifications/connectedhomeip-spec#5240

Fixes project-chip#17133
@bzbarsky-apple bzbarsky-apple mentioned this issue May 25, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 25, 2022
@bzbarsky-apple
Remove IdentifyQuery.
ffe6abb 
This command has been removed from Matter.  See
CHIP-Specifications/connectedhomeip-spec#5240

Fixes project-chip#17133
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 25, 2022
@bzbarsky-apple
Remove IdentifyQuery.
6f8159e 
This command has been removed from Matter.  See
CHIP-Specifications/connectedhomeip-spec#5240

Fixes project-chip#17133
bzbarsky-apple added a commit that referenced this issue May 26, 2022
@bzbarsky-apple
Remove IdentifyQuery. (#18819)
c0295ae 
This command has been removed from Matter.  See
CHIP-Specifications/connectedhomeip-spec#5240

Fixes #17133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove IdentifyQuery. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple